[Bug 1113712] New: Review Request: lua-bitop - C extension module for Lua 5.1/5.2 which adds bitwise operations on numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Bug ID: 1113712 Summary: Review Request: lua-bitop - C extension module for Lua 5.1/5.2 which adds bitwise operations on numbers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: orion@cora.nwra.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.cora.nwra.com/~orion/fedora/lua-bitop.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/lua-bitop-1.0.2-1.el7.src.rpm Description: C extension module for Lua 5.1/5.2 which adds bitwise operations on numbers.
Fedora Account System Username: orion
This package is to provide a needed dependency for lua-posix for EPEL7
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1113714
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1113714 [Bug 1113714] posix is missing dep on bit
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |i@cicku.me Assignee|nobody@fedoraproject.org |i@cicku.me
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
--- Comment #1 from Christopher Meng i@cicku.me --- Hi,
Do you want to push it to EL5?
If not please cleanup.
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
--- Comment #2 from Orion Poplawski orion@cora.nwra.com --- * Tue Jul 29 2014 - Orion Poplawski orion@cora.nwra.com - 1.0.2-2 - Drop BuildRoot - Wrap description
Spec URL: http://www.cora.nwra.com/~orion/fedora/lua-bitop.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/lua-bitop-1.0.2-2.fc20.src.rpm
If that's not sufficient, I'm afraid you'll need to be more specific.
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Christopher Meng i@cicku.me --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)". Detailed output of licensecheck:
MIT/X11 (BSD like) ------------------ LuaBitOp-1.0.2/bit.c
[x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: lua-bitop-1.0.2-2.fc22.i686.rpm lua-bitop-1.0.2-2.fc22.src.rpm lua-bitop.i686: W: spelling-error Summary(en_US) bitwise -> bit wise, bit-wise, leastwise lua-bitop.i686: W: spelling-error %description -l en_US bitwise -> bit wise, bit-wise, leastwise lua-bitop.src: W: spelling-error Summary(en_US) bitwise -> bit wise, bit-wise, leastwise lua-bitop.src: W: spelling-error %description -l en_US bitwise -> bit wise, bit-wise, leastwise 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint lua-bitop lua-bitop.i686: W: spelling-error Summary(en_US) bitwise -> bit wise, bit-wise, leastwise lua-bitop.i686: W: spelling-error %description -l en_US bitwise -> bit wise, bit-wise, leastwise 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'
Requires -------- lua-bitop (rpmlib, GLIBC filtered): libc.so.6 lua(abi) rtld(GNU_HASH)
Provides -------- lua-bitop: lua-bitop lua-bitop(x86-32)
Unversioned so-files -------------------- lua-bitop: /usr/lib/lua/5.2/bit.so lua-bitop: /usr/lib/lua/5.2/bit.so/bit.so
Source checksums ---------------- http://bitop.luajit.org/download/LuaBitOp-1.0.2.tar.gz : CHECKSUM(SHA256) this package : 1207c9293dcd52eb9dca6538d1b87352bd510f4e760938f5048433f7f272ce99 CHECKSUM(SHA256) upstream package : 1207c9293dcd52eb9dca6538d1b87352bd510f4e760938f5048433f7f272ce99
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -rvn lua-bitop-1.0.2-2.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
---------------------------- PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: lua-bitop - |Review Request: lua-bitop - |C extension module for Lua |C extension module for Lua |5.1/5.2 which adds bitwise |which adds bitwise |operations on numbers |operations on numbers Flags| |fedora-cvs?
--- Comment #4 from Orion Poplawski orion@cora.nwra.com --- Thanks
New Package SCM Request ======================= Package Name: lua-bitop Short Description: C extension module for Lua which adds bitwise operations on numbers Upstream URL: http://bitop.luajit.org/ Owners: orion Branches: epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1113712
Orion Poplawski orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |lua-bitop-1.0.2-2.el7 Resolution|--- |CURRENTRELEASE Last Closed| |2014-08-04 11:53:25
--- Comment #6 from Orion Poplawski orion@cora.nwra.com --- Checked in and built. Thanks everyone.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla