[Bug 1354018] New: Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16 - package-review

List overview All Threads
Download

newer

[Bug 1354018] New: Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

older

[Bug 1396232] New: Review...

[Bug 863836] New: Review Request:...

Red Hat Bugzilla

8 Jul 2016 8 Jul '16

12:36 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Bug ID: 1354018 Summary: Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx-1.0.1-1.fc... Description: A compact library to encode, decode and convert UTF8 / UTF16 Fedora Account System Username: jsmith

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

8 Jul 8 Jul

12:37 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Jared Smith jsmith.fedora@gmail.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1354014 [Bug 1354014] Review Request: nodejs-testjs - A compact testing module for node.js https://bugzilla.redhat.com/show_bug.cgi?id=1354016 [Bug 1354016] Review Request: nodejs-metascript - Sophisticated meta programming in JavaScript

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:10 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Jared Smith jsmith.fedora@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1271785

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1271785 [Bug 1271785] Review Request: nodejs-bcryptjs - bcrypt encryption for NodeJS

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Aug 4 Aug

5:36 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Aug 5 Aug

7:54 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Aug 12 Aug

11:31 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018 Bug 1354018 depends on bug 1354016, which changed state.

Bug 1354016 Summary: Review Request: nodejs-metascript - Sophisticated meta programming in JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=1354016

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:34 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018 Bug 1354018 depends on bug 1354014, which changed state.

Bug 1354014 Summary: Review Request: nodejs-testjs - A compact testing module for node.js https://bugzilla.redhat.com/show_bug.cgi?id=1354014

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Aug 15 Aug

11:07 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- The dependencies are all in Rawhide -- mind finishing this review?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

28 Sep 28 Sep

4:25 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com

--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- BR: npm(testjs) is missing.

/usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check + /usr/bin/node -e 'require("./")' + /usr/bin/node tests/suite.js module.js:457 throw err; ^ Error: Cannot find module 'testjs' at Function.Module._resolveFilename (module.js:455:15) at Function.Module._load (module.js:403:25) at Module.require (module.js:483:17) at require (internal/module.js:20:19) at Object.<anonymous> (/builddir/build/BUILD/package/tests/suite.js:2:12) at Module._compile (module.js:556:32) at Object.Module._extensions..js (module.js:565:10) at Module.load (module.js:473:32) at tryModuleLoad (module.js:432:12) at Function.Module._load (module.js:424:3) error: Bad exit status from /var/tmp/rpm-tmp.ZMSh4u (%check) Bad exit status from /var/tmp/rpm-tmp.ZMSh4u (%check) RPM build errors:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:46 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

--- Comment #3 from Jared Smith jsmith.fedora@gmail.com --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx-1.0.1-2.fc...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Sep 29 Sep

2:51 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

--- Comment #4 from Piotr Popieluch piotr1212@gmail.com --- updated SRPM

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx-1.0.1-2.fc...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:23 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- Approved

You should fix line ending in README.md nodejs-utfx.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-utfx/README.md

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/piotr/fedora- scm/1354018-nodejs-utfx/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/node_modules/utfx(this, [y/N]:, Is, ok), /usr/lib/node_modules/utfx/node_modules(this, [y/N]:, Is, ok), /usr/share/licenses/nodejs-utfx(this, [y/N]:, Is, ok), /usr/share/doc /nodejs-utfx(this, [y/N]:, Is, ok), /usr/lib/node_modules/utfx/dist(this, [y/N]:, Is, ok) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-utfx-1.0.1-2.fc26.noarch.rpm nodejs-utfx-1.0.1-2.fc26.src.rpm nodejs-utfx.noarch: W: only-non-binary-in-usr-lib nodejs-utfx.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-utfx/README.md 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages) ---------------------------- nodejs-utfx.noarch: W: only-non-binary-in-usr-lib nodejs-utfx.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-utfx/README.md 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Requires -------- nodejs-utfx (rpmlib, GLIBC filtered): nodejs(engine)

Provides -------- nodejs-utfx: nodejs-utfx npm(utfx)

Source checksums ---------------- https://registry.npmjs.org/utfx/-/utfx-1.0.1.tgz : CHECKSUM(SHA256) this package : 1d15dc7d06ddf61546bbf622b84d668a9d33c7c482822c206607f538821a21dd CHECKSUM(SHA256) upstream package : 1d15dc7d06ddf61546bbf622b84d668a9d33c7c482822c206607f538821a21dd

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1354018 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:23 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Piotr Popieluch piotr1212@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:24 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Oct 21 Oct

3:05 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1387531 (Node-RED)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:13 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-utfx

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:13 a.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|1269538 (IoT) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

19 Dec 19 Dec

3:42 p.m.

New subject: [Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Jared Smith jsmith.fedora@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3136

Age (days ago)

3300

Last active (days ago)

package-review@lists.fedoraproject.org

17 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla