[Bug 1026139] New: Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database - package-review

List overview All Threads
Download

newer

[Bug 1026139] New: Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

older

[Bug 1011500] New: Review Request:...

[Bug 658754] Review Request:...

Red Hat Bugzilla

4 Nov 2013 4 Nov '13

8:21 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Bug ID: 1026139 Summary: Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rdieter@math.unl.edu QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: http://rdieter.fedorapeople.org/rpms/appstream/appstream.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/appstream/appstream-0.4.0-1.fc20.src.rp... Description: AppStream-Core makes it easy to access application information from the AppStream database over a nice GObject-based interface. It uses a PackageKit plugin to automatically (re)generate the AppStream Xapian database of applications. Fedora Account System Username: rdieter

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

4 Nov 4 Nov

8:21 a.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1026118

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1026118 [Bug 1026118] enable AppStream in apper

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:23 a.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |appstream

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:45 a.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

T.C. Hollingsworth tchollingsworth@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:42 a.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

--- Comment #1 from T.C. Hollingsworth tchollingsworth@gmail.com --- Looks good overall, just a couple directory issues, at least one of which isn't your issue at all...

MUST:

[!]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates.

There are three directories that aren't owned by this package or any of its dependencies:

...

%{_datadir}/vala/vapi

This probably should be in a "vala-appstream" subpackage that Requires vala: http://www.redhat.com/archives/fedora-packaging/2009-February/msg00022.html

...

/usr/lib64/packagekit-plugins

This is actually a bug in PackageKit. It ships several files in that directory itself, but nobody owns it.

...

/usr/share/gir-1.0

% repoquery --whatprovides /usr/share/gir-1.0 | wc -l 46

All -devel packages.

I'm pretty sure all these packages should all just be requiring gobject-instrospection-devel?

SHOULD:

[x]: Rpmlint is run on all rpms the build produces.

Checking: appstream-0.4.0-1.fc19.x86_64.rpm appstream-devel-0.4.0-1.fc19.x86_64.rpm appstream-0.4.0-1.fc19.src.rpm

...

appstream.x86_64: W: name-repeated-in-summary C AppStream

This make sense in this case.

...

appstream-devel.x86_64: W: no-documentation

rpmlint really should whitelist -devel subpackages...

...

appstream.src:32: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 32)

In the commented-out Requires line.

...

appstream.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappstream.so.0.4.0 /lib64/libm.so.6

CMake overlinking as per usual.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:59 p.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/appstream/appstream.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/appstream/appstream-0.4.0-2.fc20.src.rp...

%changelog * Mon Nov 04 2013 Rex Dieter rdieter@fedoraproject.org 0.4.0-2 - -vala subpkg - own %%{_libdir}/girepository-1.0, %%{_libdir}/packagekit-plugins (until someone better comes along)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:29 p.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

T.C. Hollingsworth tchollingsworth@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #3 from T.C. Hollingsworth tchollingsworth@gmail.com --- %{_datadir}/gir-1.0 in -devel is still unowned. Please fix this before importing.

Everything else looks fine, APPROVED. :-)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Nov 8 Nov

6:37 a.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #4 from Rex Dieter rdieter@math.unl.edu --- New Package SCM Request ======================= Package Name: appstream Short Description: Utilities to generate, maintain and access the Appstream Xapian database Owners: rdieter Branches: f20 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:42 p.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:42 p.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:42 p.m.

New subject: [Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

https://bugzilla.redhat.com/show_bug.cgi?id=1026139

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- imported (and dir ownership fixed)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4274

Age (days ago)

4278

Last active (days ago)

package-review@lists.fedoraproject.org

10 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla