[Bug 2346665] New: Review Request: python-fastrlock - Fast, re-entrant optimistic lock implemented in Cython
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Bug ID: 2346665 Summary: Review Request: python-fastrlock - Fast, re-entrant optimistic lock implemented in Cython Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: Tom.Rix@amd.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/python-fastrlock.spec SRPM URL: https://trix.fedorapeople.org/python-fastrlock-0.8.3-1.fc42.src.rpm
https://github.com/scoder/fastrlock
This is needed for cupy https://github.com/cupy/cupy/blob/main/setup.py#L27
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #1 from Aaron Linder aaronclinder@outlook.com --- @trix okay I signed up for updates. let it let me know what to do.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Tom.Rix@amd.com --- (In reply to Aaron Linder from comment #1)
@trix okay I signed up for updates. let it let me know what to do.
This is just a step to get cupy going, when i have that packaged up, i'll point you at it to test.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #3 from Aaron Linder aaronclinder@outlook.com --- Okay thanks, CuPy is one of the requirements for a Video MP4 based video capture of rPPG signal which is for biosignal capturing process.
I wasn't able to build from source, but once the Wheel is available, or the rpm package, I will put some notes on here for reference
https://docs.cupy.dev/en/stable/install.html#building-cupy-for-rocm-from-sou...
It's still an experimental system, but I am going to use it for capturing rPPG signals from this library
https://github.com/phuselab/PyVHR
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/scoder/f | |astrlock
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8675782 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org)
--- Comment #5 from Tom.Rix@amd.com --- Is there something I need to do ?
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Aaron Linder aaronclinder@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #6 from Aaron Linder aaronclinder@outlook.com --- @tom.rix@amd.com
I still would like to get CuPy wheel working, during the week I ended up with a different optimization, I had to get something out the door because of deadline. I am still very interested in this accelerator working.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #7 from Aaron Linder aaronclinder@outlook.com --- @tom.rix@amd.com
Okay I solve the problem. Here is my installation
podman run -it --device=/dev/kdf --device=/dev/dri --group-add video cupy/cupy-rocm
Then
~$python3
import numpy as np import cupy as cp
Unfortunately there is no container to build from source and it seems a little tricky for me at the moment to build from source.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #8 from Aaron Linder aaronclinder@outlook.com --- (In reply to Aaron Linder from comment #7)
@tom.rix@amd.com
Okay I solve the problem. Here is my installation
podman run -it --device=/dev/kdf --device=/dev/dri --group-add video cupy/cupy-rocm
Then
~$python3
import numpy as np import cupy as cp
Unfortunately there is no container to build from source and it seems a little tricky for me at the moment to build from source.
this is only for ROCm 5.0~~
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #9 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 20 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/python-fastrlock/2346665- python-fastrlock/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13/site- packages, /usr/lib64/python3.13 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-fastrlock-0.8.3-1.fc43.x86_64.rpm python-fastrlock-0.8.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbzje191v')] checks: 32, packages: 2
python3-fastrlock.x86_64: E: zero-length /usr/lib64/python3.13/site-packages/fastrlock/__init__.pxd python-fastrlock.src: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python-fastrlock.src: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python-fastrlock.src: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') python3-fastrlock.x86_64: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python3-fastrlock.x86_64: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python3-fastrlock.x86_64: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') python3-fastrlock.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 7 errors, 1 warnings, 7 filtered, 7 badness; has taken 0.7 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-fastrlock.x86_64: E: zero-length /usr/lib64/python3.13/site-packages/fastrlock/__init__.pxd python3-fastrlock.x86_64: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python3-fastrlock.x86_64: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python3-fastrlock.x86_64: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') python3-fastrlock.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 4 errors, 1 warnings, 3 filtered, 4 badness; has taken 0.2 s
Unversioned so-files -------------------- python3-fastrlock: /usr/lib64/python3.13/site-packages/fastrlock/rlock.cpython-313-x86_64-linux-gnu.so
Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/fastrlock/fastrlock-0.8.3.t... : CHECKSUM(SHA256) this package : 4af6734d92eaa3ab4373e6c9a1dd0d5ad1304e172b1521733c6c3b3d73c8fa5d CHECKSUM(SHA256) upstream package : 4af6734d92eaa3ab4373e6c9a1dd0d5ad1304e172b1521733c6c3b3d73c8fa5d
Requires -------- python3-fastrlock (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH)
Provides -------- python3-fastrlock: python-fastrlock python3-fastrlock python3-fastrlock(x86-64) python3.13-fastrlock python3.13dist(fastrlock) python3dist(fastrlock)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2346665 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, C/C++, Generic Disabled plugins: Ocaml, SugarActivity, R, Java, fonts, PHP, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Consider packaging README.rst as documentation b) Can tests be run: https://github.com/scoder/fastrlock/blob/master/tox.ini#L21 c) Maybe helpful to do a build on koji d) Is the empty file needed: python3-fastrlock.x86_64: E: zero-length /usr/lib64/python3.13/site-packages/fastrlock/__init__.pxd
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #10 from Tom.Rix@amd.com --- Spec URL: https://trix.fedorapeople.org/python-fastrlock.spec SRPM URL: https://trix.fedorapeople.org/python-fastrlock-0.8.3-1.fc42.src.rpm
A lot of changes to get the test source and use them. Testing results i get from mock are
============================= test session starts ============================== platform linux -- Python 3.13.2, pytest-8.3.4, pluggy-1.5.0 cachedir: .tox/py313/.pytest_cache rootdir: /builddir/build/BUILD/python-fastrlock-0.8.3-build/fastrlock-0.8.3 collected 13 items fastrlock/tests/test_rlock.py ............. ============================== 13 passed in 0.14s ==============================
Readme added.
__init__.pxd, is part of the pypi/pip package
$ ls ~/.local/lib/python3.13/site-packages/fastrlock __init__.pxd __init__.py _lock.pxi __pycache__ rlock.cpython-313-x86_64-linux-gnu.so rlock.pxd rlock.pyx
and is not doing any harm, so I left it. If you feel strongly about it, i can %exclude it,
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
--- Comment #11 from Aaron Linder aaronclinder@outlook.com --- Okay it looks good, one step closer to building CuPy for ROCm for consumer cards!
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #12 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Creative Commons CC0 1.0", "*No copyright* MIT License". 19 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-fastrlock/2346665-python- fastrlock/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13, /usr/lib64/python3.13/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5669 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-fastrlock-0.8.3-1.fc43.x86_64.rpm python-fastrlock-0.8.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbxicwzbn')] checks: 32, packages: 2
python3-fastrlock.x86_64: E: zero-length /usr/lib64/python3.13/site-packages/fastrlock/__init__.pxd python-fastrlock.src: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python-fastrlock.src: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python-fastrlock.src: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') python3-fastrlock.x86_64: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python3-fastrlock.x86_64: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python3-fastrlock.x86_64: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') 2 packages and 0 specfiles checked; 7 errors, 0 warnings, 7 filtered, 7 badness; has taken 0.6 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-fastrlock.x86_64: E: zero-length /usr/lib64/python3.13/site-packages/fastrlock/__init__.pxd python3-fastrlock.x86_64: E: spelling-error ('cimport', '%description -l en_US cimport -> comport, import, c import') python3-fastrlock.x86_64: E: spelling-error ('cython', '%description -l en_US cython -> python, Python') python3-fastrlock.x86_64: E: spelling-error ('cimports', '%description -l en_US cimports -> comports, imports, c imports') 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 3 filtered, 4 badness; has taken 0.2 s
Unversioned so-files -------------------- python3-fastrlock: /usr/lib64/python3.13/site-packages/fastrlock/rlock.cpython-313-x86_64-linux-gnu.so
Source checksums ---------------- https://github.com/scoder/fastrlock/archive/v0.8.3.tar.gz : CHECKSUM(SHA256) this package : 8cf3898b945c2f44eeb52ffce57b91104e89752f7b01345c975fdfbbaa7c38c6 CHECKSUM(SHA256) upstream package : 8cf3898b945c2f44eeb52ffce57b91104e89752f7b01345c975fdfbbaa7c38c6
Requires -------- python3-fastrlock (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH)
Provides -------- python3-fastrlock: python-fastrlock python3-fastrlock python3-fastrlock(x86-64) python3.13-fastrlock python3.13dist(fastrlock) python3dist(fastrlock)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2346665 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: SugarActivity, PHP, R, Perl, Java, fonts, Haskell, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Please change Source: %{url}/archive/v0.8.3.tar.gz to Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz See packaging guidelines for how to reference source
b) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=130690479
c) Approved, please fix (a) before import. d) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2354311 would be appreciated if time allows.
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #13 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-fastrlock
https://bugzilla.redhat.com/show_bug.cgi?id=2346665
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|RELEASE_PENDING |CLOSED Last Closed| |2025-03-29 12:30:09
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com