https://bugzilla.redhat.com/show_bug.cgi?id=1789940
Bug ID: 1789940 Summary: Review Request: Pound - Reverse proxy and load balancer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: breno@tembosocial.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://src.fedoraproject.org/fork/brandfbb/rpms/Pound/tree/epel8 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/brandfbb/Pound-2.8-patrodyne... Description:
The package Pound was retired about a year ago. It failed to build and at that time the maintainer didn't give any feedback on it[1].
Since then, the Pound project was forked and has been maintained[2]. I would like to maintain the package in EPEL. I've made some tests and I believe I have a working spec file for it. It was also tested against koji, epel 8 playground [3].
I am now following the Claiming Ownership of a Retired Package procedure.
I am in the packager group, sponsored by nirik and my mentor is smooge.
Thanks.
1 - https://bugzilla.redhat.com/show_bug.cgi?id=1674583 2 - https://github.com/patrodyne/pound 3 - https://koji.fedoraproject.org/koji/taskinfo?taskID=40203731
Fedora Account System Username:brandfbb
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Why the Epoch?
- Why no parallel building?
make all → %make_build all
- make install DESTDIR=%{buildroot} → %make_install
- Don't use %{__install}, macro prefixed by __ are generally for rpm private use
- Please be more descriptive for the service description:
"Pound user" → "User for the Pound reverse proxy and load balancer"
- Why is there this stuff:
Requires(post): systemd-sysv Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units
You just need BuildRequires: systemd-rpm-macros for Fedora. Not sure what it is on EPEL8, test BuildRequires: systemd-rpm-macros first then if not available use BuildRequires: systemd-devel
- https://www.apsis.ch/pound/ is 403? Isn't there another official site? Using the fork as main page may be better: https://github.com/patrodyne/pound
- License seems to include an exception:
License: GPLv3 with exceptions
- License mist be included with %license not %doc:
%files %doc CHANGELOG FAQ README.md %license GPL.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Disregards the Epoch comment.
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
--- Comment #3 from Breno breno@tembosocial.com --- Spec URL: https://src.fedoraproject.org/fork/brandfbb/rpms/Pound/tree/epel8 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/brandfbb/Pound-2.8-patrodyne... Description:
Hi Robert-André, thanks for your feedback. I've updated the spec file with your corrections and ran another build.
The diff can be seen here[1].
- Breno 1 - https://src.fedoraproject.org/fork/brandfbb/rpms/Pound/c/b63a0a0f789e1e3b51b...
Fedora Account System Username:brandfbb
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
Breno brandfbb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NOTABUG Last Closed| |2021-03-30 12:52:39
--- Comment #5 from Breno brandfbb@gmail.com --- This request has been attended a long time ago. Closing the ticket.
package-review@lists.fedoraproject.org