Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
Summary: Review Request: scummvm - Interpreter for several adventure games Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/scummvm.spec SRPM URL: http://people.atrpms.net/~hdegoede/scummvm-0.9.1-1.fc7.src.rpm Description: ScummVM is an implementation of the SCUMM (Script Creation Utility for Maniac Mansion) engine used in various Lucas Arts games such as Monkey Island and Day of the Tentacle. At this time ScummVM should be considered ALPHA software, as it's still under heavy development. Be aware that while many games will work with few major bugs, crashes can happen. Also note that saved games can, and probably will, be incompatible between releases.
Also ScummVM is capable of playing several non-SCUMM games.
---
As discussed on f-e-l, scummvm is moving from Livna to FE since there have been released two Free games for it. There is one downside to being in FE.
I've had to disable mp3 and mpeg2 video support. mp3 support is not a problem since scummvm also supports ogg and the involved media packs are available in both ogg and mp3 format. However the loose of mpeg2 video playback is unfortunate as that means that the cutscenes in the Broken Sword game cannot be played. I believe this is a small disadvantage as it influences only one game and that the advantages of being in FE outway this disadvantage.
I'll request upstream to add theora support and to also provide theora versions of the involved media packs fixing this.
I'll also be submitting several game packages for scumm today and I'll add their bug numbers to this bug, so you will have something to test with when reviewing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-05 03:26 EST ------- Beneath a Steel Sky (floppy version) review is in bug 214057 .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |214057 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name
------- Additional Comments From opensource@till.name 2006-11-05 04:19 EST ------- Why is configure invoked with "--disable-fluidsynth"? Fluidsynth is available in Extras.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-05 07:01 EST ------- Because it can also use fluidsynth through alsa and I didn't want to drag it in as a dep. Especially since fluidsynth needs a good free GM soundfont2 file, which currently is not available in FE AFAIK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |214091 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-05 12:18 EST ------- And Beneath a Steel Sky (CD version) review is in bug 214091.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |214113 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |chris.stone@gmail.com OtherBugsDependingO|163776 |163778 nThis| | Alias| |scummvm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-06 03:51 EST ------- And the last 2: Flight of the Amazon Queen is bug 214113 Flight of the Amazon Queen (CD version) is bug 214150
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |214150 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From matthias@rpmforge.net 2006-11-06 04:52 EST ------- Quick comments : - You don't need to use "--add-category X-Fedora" any more (it's useless) - For all the icons/hicolor files, I'd use "install -D" to remove all mkdir lines - The scummvm-icons could maybe be extracted at prep time with ImageMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-06 09:22 EST ------- (In reply to comment #6)
Quick comments :
- You don't need to use "--add-category X-Fedora" any more (it's useless)
I know, but AFAIK the guidelines haven't been updated with regards to this, so I'm keeping this as is for all my packages for now to keep things consistent. I'll start fixing this to match the new guidelines when there are new guidelines and as / when packages need updating fro something more important.
- For all the icons/hicolor files, I'd use "install -D" to remove all mkdir lines
And right you would be, however I'm used to doing it this way, maybe its time to change my habbits? But this works and is much easier to read for people who are not known with the more obscure install cmdline options.
- The scummvm-icons could maybe be extracted at prep time with ImageMagick
I've tried but the .ico file contains 8, 16 and 32 bit versions of each icon (the 128x128 is only available in 32 bit) and ImageMagick fails on extracting the 32 bit ones (the colors are all messed up).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From chris.stone@gmail.com 2006-11-06 18:49 EST ------- Hans,
I have a scummvm-tools package from Livna. Do you plan on Obsoleting this package or providing your own scummvm-tools package? I am in the process of starting a review, rpmlint is linting about not using --libdir in your %configure. See rpmlint -I configure-without-libdir-spec for more information.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-07 02:45 EST ------- (In reply to comment #8)
Hans,
I have a scummvm-tools package from Livna. Do you plan on Obsoleting this package or providing your own scummvm-tools package?
The plan is to move this to FE too, that is the last scumm related package, I still need to send a mail to Andreas to coordinate this, then update the livna package to the 0.9 release of the tools and submit it for review seperately.
I am in the process of starting a review, rpmlint is linting about not using --libdir in your %configure. See rpmlint -I configure-without-libdir-spec for more information.
That is because the configure script in scummvm isn't a autoconf configure script but a custom bashscript which doesn't understand -libdir, that is also the reason why %configure isn't used.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-11-07 17:55 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output E: scummvm configure-without-libdir-spec
Okay, covered in comment #9. Should mention why you are not using libdir in comments though. - package named according to guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec file in American english - spec file legible - source match upstream 30a82ad466bae223875e66ee14b94904 scummvm-0.9.1.tar.bz2 - package successfully compiles and builds on FC5 x86_64 - all build dependencies listed in BR - package does not use locales - package does not contain shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - package contains proper %clean - macro usage consistent - package contains code - package does not contain large documentation - files in %doc do not affect runtime - no header or libraries files or devel subpackage required - no pkgconfig files - no .la files - package contains proper .desktop scriptlets - package does not own files or directories owned by other packages
APPROVED
==== SHOULD ==== - please add to configure comments something about no --libdir since rpmlint gives an Error on this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scummvm - Interpreter for several adventure games Alias: scummvm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-08 05:23 EST ------- Should fixed, imported and build, Thanks!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla