Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Bug ID: 915331 Summary: Review Request: rubygem-rubeyond - A development framework for Ruby Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dpierce@redhat.com
Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-rubeyond.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-rubeyond-0.1-1.fc18.src.rpm Description: Rubeyond provides addition general classes, mixins and functions to round out the standard library that ships with the Ruby language. Fedora Account System Username: mcpierce
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|extras-qa@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- Assigning.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- Okay, seems a simple package.
* License - It seems that License tag should be "GPLv3+". As you seems to be the upstream, please check this.
* Create ./%{gem_dir} before gem install --local - Please create ./%{gem_dir} before calling gem install, otherwise unneeded .gem directory will be created. ! Note Also see below.
! Note: migration to ruby 2.0.0 A. ruby(abi) v.s. ruby(release) - F-18/17 ruby requirement uses ruby(abi), while f19-ruby ruby requirement uses ruby(release). You can handle this like this:
%if 0%{?fedora} >= 19 Requires: ruby(release) BuildRequires: ruby(release) %else Requires: ruby(abi) = %{rubyabi} Requires: ruby BuildRequires: ruby(abi) = %{rubyabi} BuildRequires: ruby %endif
B. mkdir -p .%{gem_dir} and gem install --local .... - Now this can be handled by %gem_install macro. Note that I backported %gem_install macro into F-18/F-17 rubygems rpm (i.e. /etc/rpm/macros.rubygems in F-18/F-17). These rubygems have not pushed into stable repository yet, however these rubygems have override tag, so now you can use %gem_install macro on koji even on F-18 and F-17.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- Please check the above before importing. No blocker.
------------------------------------------------------------- This package (rubygem-rubeyond) is APPROVED by mtasaka -------------------------------------------------------------
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Darryl L. Pierce dpierce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Darryl L. Pierce dpierce@redhat.com --- Thank you for the review!
New Package SCM Request ======================= Package Name: rubygem-rubeyond Short Description: A development framework for Ruby Owners: mcpierce Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #6 from Mamoru TASAKA mtasaka@fedoraproject.org --- Note that for rawhide, ruby(release) is provided by ruby 2.0.x, so you need $ fedpkg build --target f19-ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-rubeyond-0.1-1.1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-rubeyond-0.1-1.1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-rubeyond-0.1-1.1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-rubeyond-0.1-1.1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-rubeyond-0.1-1.1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-03-08 01:48:12
--- Comment #10 from Mamoru TASAKA mtasaka@fedoraproject.org --- Closing.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- rubygem-rubeyond-0.1-1.1.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915331
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- rubygem-rubeyond-0.1-1.1.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org