[Bug 2117112] New: Review Request: python-zope-hookable - Efficient creation of hookable objects
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Bug ID: 2117112 Summary: Review Request: python-zope-hookable - Efficient creation of hookable objects Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathan@almalinux.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jonathanspw.fedorapeople.org/python-zope-hookable.spec SRPM URL: python-zope-hookable-5.1.0-1.fc38.src.rpm
Description: Efficient creation of hookable objects
Fedora Account System Username: jonathanspw
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nb@fedoraproject.org Assignee|nobody@fedoraproject.org |nb@fedoraproject.org Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Nick Bebout nb@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Nick Bebout nb@fedoraproject.org --- Looks good. Approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Zope Public License 2.1", "Zope Public License 2.1". 26 files have unknown license. Detailed output of licensecheck in /home/nebebout/2117112-python-zope- hookable/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.11/site- packages/zope [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-zope-hookable [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Unversioned so-files -------------------- python3-zope-hookable: /usr/lib64/python3.11/site-packages/zope/hookable/_zope_hookable.cpython-311-x86_64-linux-gnu.so
Source checksums ---------------- https://files.pythonhosted.org/packages/source/z/zope.hookable/zope.hookable... : CHECKSUM(SHA256) this package : 8fc3e6cd0486c6af48e3317c299def719b57538332a194e0b3bc6a772f4faa0e CHECKSUM(SHA256) upstream package : 8fc3e6cd0486c6af48e3317c299def719b57538332a194e0b3bc6a772f4faa0e
Requires -------- python3-zope-hookable (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) python3.11dist(setuptools) rtld(GNU_HASH)
python-zope-hookable-debugsource (rpmlib, GLIBC filtered):
Provides -------- python3-zope-hookable: python-zope-hookable python3-zope-hookable python3-zope-hookable(x86-64) python3.11-zope-hookable python3.11dist(zope-hookable) python3dist(zope-hookable)
python-zope-hookable-debugsource: python-zope-hookable-debugsource python-zope-hookable-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2117112 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic, C/C++ Disabled plugins: fonts, Haskell, Ocaml, PHP, Java, R, SugarActivity, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-zope-hookable
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #4 from Miro Hrončok mhroncok@redhat.com --- Further feedback, as I was the original reviewer for bz2090791 but then got cut off by Nick without involving me here :(
rm -rf src/%{name}.egg-info
This is most likely not needed and should not be in the spec file just because some older packages have it.
Source0: %{pypi_source}
Using %{pypi_source} without the name argument is deprecated.
Two things here:
1. the URL cannot be copied from the spec and pasted to a browser, which is not nice for a packager who has the spec in front of them and need to go to the website 2. upstream lists http://github.com/zopefoundation/zope.hookable as their website, not PyPI and I belive we should use the same URL as upstream
Summary: Efficient creation of hookable objects
The second summary could be DRY'ed by using:
Summary: %{summary}
The big %if/%else between EPEL and Fedora could use a few empty lines around the %else statement to make it clearer it's not part of the %install section.
-k "not test_pure_python"
This could use an explanation in a comment.
%{buildroot}/%{python3_sitearch}/zope/hookable
This is unusual after %pytet --pyargs. Is it indeed needed? What about plain zope.hookable here?
And finally, my favorite:
%global pypi_name zope.hookable
Is this worth having just for the 3 usages in the spec when everywhere else we need to use zope-hookable or zope/hookable anyway?
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
--- Comment #5 from Jonathan Wright jonathan@almalinux.org --- (In reply to Miro Hrončok from comment #4)
Further feedback, as I was the original reviewer for bz2090791 but then got cut off by Nick without involving me here :(
I started on the package before realizing he had one pending review. We chatted on IRC and I offered him my spec but he said just submit it and he'd review. Sorry about that.
rm -rf src/%{name}.egg-info
This is most likely not needed and should not be in the spec file just because some older packages have it.
Removed. Came across the specific docs on that today actually.
Source0: %{pypi_source}
Using %{pypi_source} without the name argument is deprecated.
Added the name.
Two things here:
- the URL cannot be copied from the spec and pasted to a browser, which is
not nice for a packager who has the spec in front of them and need to go to the website 2. upstream lists http://github.com/zopefoundation/zope.hookable as their website, not PyPI and I belive we should use the same URL as upstream
Corrected both. I had gotten the impression that URLs full of variables were fine because "more variables" but I did find it annoying trying to then use those URLs to grab sources.
Summary: Efficient creation of hookable objects
The second summary could be DRY'ed by using:
Summary: %{summary}
Thanks
The big %if/%else between EPEL and Fedora could use a few empty lines around the %else statement to make it clearer it's not part of the %install section.
Fixed so it's more clear.
-k "not test_pure_python"
This could use an explanation in a comment.
Removed that exclude because those tests actually pass.
%{buildroot}/%{python3_sitearch}/zope/hookable
This is unusual after %pytet --pyargs. Is it indeed needed? What about plain zope.hookable here?
plain zope.hookable works. Fixed.
And finally, my favorite:
%global pypi_name zope.hookable
Is this worth having just for the 3 usages in the spec when everywhere else we need to use zope-hookable or zope/hookable anyway?
Personally I like the variables so I've opted to leave it here. I've seen them both ways and even seen the variable in specs slightly simpler than this. :shrug:
As always, thank you for the feedback!
https://src.fedoraproject.org/rpms/python-zope-hookable/blob/rawhide/f/pytho...
https://bugzilla.redhat.com/show_bug.cgi?id=2117112
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ASSIGNED |CLOSED Last Closed| |2022-09-08 19:54:26
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com