[Bug 445501] New: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=445501
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rjones@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-augeas.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-augeas-0.4-1.fc8.src.rpm Description: OCaml bindings for Augeas configuration API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
------- Additional Comments From rjones@redhat.com 2008-05-07 04:06 EST ------- rpmlint is clean.
Requires:
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(VersionedDependencies) <= 3.0.3-1 libaugeas.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) ocaml(Callback) = e5ca1fb5990fac2b7b17cbb1712cffe2 ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(runtime) = 3.10.0
Provides:
dllmlaugeas.so()(64bit) ocaml(Augeas) = 03863c2006cbc18d8007602c209b6668 ocaml-augeas = 0.4-1.fc8
Files in the main package:
/usr/lib64/ocaml/augeas /usr/lib64/ocaml/augeas/META /usr/lib64/ocaml/augeas/augeas.cmi /usr/lib64/ocaml/augeas/mlaugeas.cma /usr/lib64/ocaml/stublibs/dllmlaugeas.so /usr/lib64/ocaml/stublibs/dllmlaugeas.so.owner /usr/share/doc/ocaml-augeas-0.4 /usr/share/doc/ocaml-augeas-0.4/COPYING.LIB
Files in the -devel subpackage:
/usr/lib64/ocaml/augeas/augeas.cmx /usr/lib64/ocaml/augeas/augeas.mli /usr/lib64/ocaml/augeas/libmlaugeas.a /usr/lib64/ocaml/augeas/mlaugeas.a /usr/lib64/ocaml/augeas/mlaugeas.cmxa /usr/share/doc/ocaml-augeas-devel-0.4 /usr/share/doc/ocaml-augeas-devel-0.4/html /usr/share/doc/ocaml-augeas-devel-0.4/html/Augeas.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_attributes.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_class_types.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_classes.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_exceptions.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_methods.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_module_types.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_modules.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_types.html /usr/share/doc/ocaml-augeas-devel-0.4/html/index_values.html /usr/share/doc/ocaml-augeas-devel-0.4/html/style.css /usr/share/doc/ocaml-augeas-devel-0.4/html/type_Augeas.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
dlutter@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |dlutter@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
------- Additional Comments From dlutter@redhat.com 2008-05-07 18:30 EST ------- MUST items:
- MUST: rpmlint must be run on every package. The output should be posted in the review. OK
- MUST: The package must be named according to the Package Naming Guidelines. OK
- MUST: The spec file name must match the base package %{name}, in the format %{name}.spec OK
- MUST: The package must meet the Packaging Guidelines. OK
- MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
- MUST: The License field in the package spec file must match the actual license. OK (Though upstream should be encouraged to include a license that mentions the exceptions)
- MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK
- MUST: The spec file must be written in American English. OK
- MUST: The spec file for the package MUST be legible. OK
- MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
- MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. OK (checked for i386 and x86_64)
- MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. OK
- MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. N/A (no translations)
- MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. N/A
- MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. Refer to the Guidelines for examples. OK
- MUST: A package must not contain any duplicate files in the %files listing. OK
- MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK
- MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK
- MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. OK
- MUST: The package must contain code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines. OK
- MUST: Large documentation files should go in a -doc subpackage. N/A
- MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK
- MUST: Header files must be in a -devel package. N/A
- MUST: Static libraries must be in a -static package. N/A
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). N/A
- MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. N/A
- MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK
- MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. OK
- MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. N/A
- MUST: Packages must not own files or directories already owned by other packages. OK
- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK
- MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD Items:
- SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. No translations included
- SHOULD: The reviewer should test that the package builds in mock. See MockTricks for details on how to do this. OK
- SHOULD: The package should compile and build into binary rpms on all supported architectures. OK for i386/x86_64, not checked for others
- SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. OK
- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. N/A
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
dlutter@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
------- Additional Comments From dlutter@redhat.com 2008-05-07 18:30 EST ------- Summary:
- upstream should include an explanation of the LGPL exceptions of the license
Other than that, the package is APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
------- Additional Comments From rjones@redhat.com 2008-05-08 04:26 EST ------- I'll add the exception to COPYING.LIB in a moment ...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From rjones@redhat.com 2008-05-08 09:34 EST ------- New Package CVS Request ======================= Package Name: ocaml-augeas Short Description: OCaml bindings for Augeas configuration API Owners: rjones Branches: F-8 F-9 InitialCC: rjones Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-05-08 13:44 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-augeas - OCaml bindings for Augeas configuration API
https://bugzilla.redhat.com/show_bug.cgi?id=445501
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE
------- Additional Comments From rjones@redhat.com 2008-05-08 14:17 EST ------- Built for F-10.
F-8: It turns out there's no augeas in F-8, but I'm going to add one shortly. F-9: Doesn't yet build because augeas hasn't made it into the repository yet. I'll return to this when F-9 is released.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla