[Bug 1270776] New: Review Request: restsharp - Simple REST and HTTP API Client - package-review

List overview All Threads
Download

newer

[Bug 1270776] New: Review Request: restsharp - Simple REST and HTTP API Client

older

[Bug 1312609] New: Review Request:...

[Bug 860703] New: Review Request:...

Red Hat Bugzilla

12 Oct 2015 12 Oct '15

4:26 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Bug ID: 1270776 Summary: Review Request: restsharp - Simple REST and HTTP API Client Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: projects.rg@smart.ms QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://raphgro.fedorapeople.org/review/openra/restsharp.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/restsharp-105.2.3-1.fc23.src.... Description: Simple REST and HTTP API Client Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11413777

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

12 Oct 12 Oct

4:27 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Raphael Groner projects.rg@smart.ms changed:

--- Comment #1 from Raphael Groner projects.rg@smart.ms --- error CS0246: The type or namespace name `NUnit' could not be found. Are you missing an assembly reference? => Disabled %check for now cause no idea why it doesn't work.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1159091 [Bug 1159091] Review Request: openra - Libre/Free Real Time Strategy project that recreates the famous Command & Conquer titles

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:34 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- raphgro's scratch build of restsharp-105.2.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11413777

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Oct 14 Oct

7:17 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #3 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/openra/restsharp.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/restsharp-105.2.3-2.fc23.src....

%changelog * Wed Oct 14 2015 Raphael Groner <> - 105.2.3-2 - use patches for csproj preparation - unbundle + enable nunit

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11444702

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:19 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- raphgro's scratch build of restsharp-105.2.3-2.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11444702

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Feb 3 Feb

3:01 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Christian Dersch lupinix@mailbox.org changed:

--- Comment #5 from Christian Dersch lupinix@mailbox.org --- Taken

TODO I already recognized: Please move restsharp.pc to a -devel subpackage as required by Guidelines https://fedoraproject.org/wiki/Packaging:Mono?rd=Packaging/Mono#-devel_packa...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Feb 4 Feb

10:34 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #6 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- raphgro's scratch build of restsharp-105.2.3-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12857375

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #7 from Raphael Groner projects.rg@smart.ms --- Spec URL: https://raphgro.fedorapeople.org/review/openra/restsharp.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/restsharp-105.2.3-3.fc23.src....

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12858849

%changelog * Thu Feb 04 2016 Raphael Groner projects.rg@smart.ms - 105.2.3-3 - split devel subpackage, add mono as requirement in pkgconfig - fix folder ownership of _monodir/name - add license breakdown

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:34 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #8 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- raphgro's scratch build of restsharp-105.2.3-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12858849

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Feb 6 Feb

2:39 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Christian Dersch lupinix@mailbox.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #9 from Christian Dersch lupinix@mailbox.org --- Package looks fine :) Approved!

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 108 files have unknown license. Detailed output of licensecheck in /home/review/1270776-restsharp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified.

==> Patches are Fedora specific for unbundling etc.

[-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ==> http://koji.fedoraproject.org/koji/taskinfo?taskID=12858849

[x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: restsharp-105.2.3-3.fc24.x86_64.rpm restsharp-devel-105.2.3-3.fc24.x86_64.rpm restsharp-105.2.3-3.fc24.src.rpm restsharp.x86_64: E: no-binary ===> False positive

restsharp.x86_64: W: only-non-binary-in-usr-lib restsharp-devel.x86_64: W: only-non-binary-in-usr-lib restsharp-devel.x86_64: W: no-documentation restsharp.src:40: W: macro-in-comment %patch2 restsharp.src:56: E: hardcoded-library-path in %{buildroot}/usr/lib

===> Should be false positive in case of mono

restsharp.src: W: patch-not-applied Patch2: %{name}-disable-nuget.patch 3 packages and 0 specfiles checked; 2 errors, 5 warnings.

Rpmlint (installed packages) ---------------------------- restsharp.x86_64: E: no-binary ===> False positive

restsharp.x86_64: W: only-non-binary-in-usr-lib restsharp-devel.x86_64: W: only-non-binary-in-usr-lib restsharp-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 3 warnings.

Requires -------- restsharp (rpmlib, GLIBC filtered): mono(System) mono(System.Core) mono(System.Xml) mono(System.Xml.Linq) mono(mscorlib)

restsharp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig(mono) restsharp(x86-64)

Provides -------- restsharp: mono(RestSharp) restsharp restsharp(x86-64)

restsharp-devel: pkgconfig(restsharp) restsharp-devel restsharp-devel(x86-64)

Source checksums ---------------- https://github.com/restsharp/RestSharp/archive/105.2.3.tar.gz#/restsharp-105... : CHECKSUM(SHA256) this package : 1ace876278078ea2b40220c049179a551c5dc8fafcc0f2fb9218d1529e74d879 CHECKSUM(SHA256) upstream package : 1ace876278078ea2b40220c049179a551c5dc8fafcc0f2fb9218d1529e74d879

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1270776 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:07 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST

--- Comment #10 from Raphael Groner projects.rg@smart.ms --- Thanks for your review!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:08 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias|restsharp |

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:55 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/restsharp

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:55 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- restsharp-105.2.3-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-01a328bcee

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Feb 7 Feb

2:26 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:19 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- restsharp-105.2.3-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-01a328bcee

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Feb 18 Feb

3:50 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- restsharp-105.2.3-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eedc45335e

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:50 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Feb 21 Feb

10 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- restsharp-105.2.3-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 a.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- restsharp-105.2.3-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-eedc45335e

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

28 Feb 28 Feb

9:25 p.m.

New subject: [Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3042

Age (days ago)

3182

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla