Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892597
Bug ID: 892597 Summary: Review Request: glite-lb-types - Build-time component for gLite L&B Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: valtri@civ.zcu.cz
Spec URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.2-1/glite-lb-types.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.2-1/glite-lb-types-2.0.2-... Description: Auxiliary build-time component defining LB event types and job status fields. Fedora Account System Username: valtri
Notes: - I'm upstream maintainer - contains perl modules - koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4844709
https://bugzilla.redhat.com/show_bug.cgi?id=892597
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |perl-devel@lists.fedoraproj | |ect.org
--- Comment #1 from František Dvořák valtri@civ.zcu.cz --- Spec URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-1/glite-lb-types.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-1/glite-lb-types-2.0.7-... Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5540505
New upstream version and packaging fixes.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
--- Comment #2 from Petr Šabata psabata@redhat.com --- Taking the review.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #3 from Petr Šabata psabata@redhat.com --- You'll need to buildrequire the following: - perl (called in spec) - perl(Getopt::Long), ./configure:26 - perl(POSIX), ./configure:27
Don't use absolute paths in your spec. Call perl simply 'perl' (preferred) or use the %{__perl} macro.
Put the installled C header file in a devel subpackage, as mandated by the packaging guidelines.
Since your Summary and %description are identical, consider using the %{summary} macro.
The %check section doesn't run anything and can be dropped.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #4 from František Dvořák valtri@civ.zcu.cz --- Thanks for the review, I'll incorporate the changes.
About the header file in separate subpackage: there is mentioned in Perl section the header files shouldn't be split off (but maybe this is a different case?): https://fedoraproject.org/wiki/Packaging:Perl#.h_files_in_module_packages
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #5 from Petr Šabata psabata@redhat.com --- You're right, keep that part as is :)
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #6 from František Dvořák valtri@civ.zcu.cz --- Spec URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-2/glite-lb-types.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-types-2.0.7-2/glite-lb-types-2.0.7-... Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5551324
New packaging with the changes.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Šabata psabata@redhat.com --- Ok, looks good. Approving.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from František Dvořák valtri@civ.zcu.cz --- New Package SCM Request ======================= Package Name: glite-lb-types Short Description: Build-time component for gLite L&B Owners: valtri Branches: f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.7-2.el6
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |glite-lb-types-2.0.7-2.fc19 Resolution|--- |ERRATA Last Closed| |2013-07-16 23:00:31
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.10-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/glite-lb-types-2.0.10-3.el7
https://bugzilla.redhat.com/show_bug.cgi?id=892597
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- glite-lb-types-2.0.10-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
package-review@lists.fedoraproject.org