https://bugzilla.redhat.com/show_bug.cgi?id=1932616
Bug ID: 1932616 Summary: Review Request: rttr - Run Time Type Reflection Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kwizart@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dl.kwizart.net/review/rttr.spec SRPM URL: https://dl.kwizart.net/review/rttr-0.9.6-2.fc33.src.rpm Description: Run Time Type Reflection Fedora Account System Username: kwizart
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=62649886
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sergio@serjux.com Assignee|nobody@fedoraproject.org |sergio@serjux.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #1 from Sergio Basto sergio@serjux.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license_8md.html is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4608000 bytes in 255 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated", "*No copyright* Expat License", "*No copyright* Public domain". 71 files have unknown license. Detailed output of licensecheck in /home/sergio/fedora- scm/1932616-rttr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/rttr [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/rttr [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in librttr [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4679680 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: rttr-0.9.6-2.fc35.x86_64.rpm librttr-0.9.6-2.fc35.x86_64.rpm librttr-devel-0.9.6-2.fc35.x86_64.rpm rttr-0.9.6-2.fc35.src.rpm rttr.x86_64: E: no-binary rttr.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rttr/README.md librttr.x86_64: E: non-readable /usr/share/doc/index.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/access__levels_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/access__levels_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/annotated.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/argument_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/argument_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/array__range_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/array__range_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/associative__mapper_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/associative__mapper_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/bc_s.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/bdwn.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/bootstrap/css/bootstrap.min.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/bootstrap/js/bootstrap.min.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/building__install_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/building_install_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classes.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1argument-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1argument.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1array__range-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1array__range.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1basic__string__view-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1basic__string__view.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1constructor-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1constructor.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1destructor-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1destructor.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1enum__flags-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1enum__flags.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1enumeration-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1enumeration.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1instance-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1instance.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1library-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1library.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1method-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1method.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1parameter__info-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1parameter__info.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1property-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1property.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration_1_1bind-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration_1_1bind.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration_1_1bind.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration_1_1class__-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1registration_1_1class__.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1type-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1type.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__associative__view-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__associative__view.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__associative__view_1_1const__iterator-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__associative__view_1_1const__iterator.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__sequential__view-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__sequential__view.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__sequential__view_1_1const__iterator-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/classrttr_1_1variant__sequential__view_1_1const__iterator.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/closed.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/constructor_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/constructor_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/custom-bootstrap.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/custom-doxygen.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/default__arguments_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/default_arguments_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/destructor_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/destructor_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/dir_9950a74130ece602e761643b15cf9815.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/dir_e68e8157741866f444e17edd764ebbae.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/dir_f5cf7324fde9d3df625992c311710e35.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/doc.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/doxy-boot.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/doxygen.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/doxygen.svg 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/dynsections.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/enum__flags_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/enum__flags_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/enumeration_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/enumeration_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/favicon.ico 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/filter__item_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/filter__item_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/five__minute__tutorial_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/five_minute_tutorial_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/folderclosed.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/folderopen.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/PTS55F-demo.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/PTS55F-webfont.eot 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/PTS55F-webfont.svg 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/PTS55F-webfont.ttf 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/PTS55F-webfont.woff 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/specimen_files/PTS55F-cleartype.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/specimen_files/easytabs.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/specimen_files/grid_12-825-55-15.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/specimen_files/specimen_stylesheet.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/ptsans_regular_macroman/stylesheet.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/SourceCodePro-Regular-webfont.eot 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/SourceCodePro-Regular-webfont.svg 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/SourceCodePro-Regular-webfont.ttf 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/SourceCodePro-Regular-webfont.woff 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/demo.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/fonts/source_code_pro_regular/stylesheet.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_b.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_c.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_d.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_e.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_f.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_b.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_c.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_d.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_e.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_f.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_g.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_i.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_l.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_m.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_n.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_o.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_p.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_r.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_s.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_t.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_u.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_v.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_func_~.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_g.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_i.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_k.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_l.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_m.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_n.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_o.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_p.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_r.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_rela.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_s.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_t.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_type.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_u.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_v.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_vars.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_w.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_z.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/functions_~.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/hierarchy.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/index.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/instance_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/instance_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/jquery.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/jquery.min.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/library_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/library_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/license_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/license_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/main__page_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/menu.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/menudata.js 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/meta__data_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/method_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/method_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/namespacemembers.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/namespacemembers_enum.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/namespacemembers_func.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/namespacemembers_type.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/namespacerttr.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/nav_f.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/nav_g.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/nav_h.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/open.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/pages.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/parameter__info_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/parameter__info_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/parameter__names_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/parameter_names_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/policies_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/policy_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/policy_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/property_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/property_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/query__info__type_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__class__hierachy_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__classes_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__enums_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__hello__world_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__methods_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__plugins_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register__properties_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_classes_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_enums_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_hello_world_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_metadata_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_methods_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_plugins.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_policies_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_properties_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/register_variant_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/registration_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/registration_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/registration__friend_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/registration__friend_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr__cast_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr__cast_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr__enable_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr__enable_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr_type_class_hierachy_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr_type_get_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr_type_info_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/rttr_type_rttr_cast_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/sequential__mapper_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/sequential__mapper_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/splitbar.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/string__view_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/string__view_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1associative__container__mapper-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1associative__container__mapper.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1ctor-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1ctor.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1meth-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1meth.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1prop-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1policy_1_1prop.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1sequential__container__mapper-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1sequential__container__mapper.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1wrapper__mapper-members.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/structrttr_1_1wrapper__mapper.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/sync_off.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/sync_on.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tab_a.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tab_b.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tab_h.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tab_s.png 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tabs.css 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tutorial_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/tutorial_page.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/type_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/type_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/using__rttr__cast_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/using__rttr__type_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant_8md.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant__associative__view_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant__associative__view_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant__sequential__view_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/variant__sequential__view_8h_source.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/wrapper__mapper_8h.html 400 librttr.x86_64: E: non-readable /usr/share/doc/rttr-0-9-6/wrapper__mapper_8h_source.html 400 librttr-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 255 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name rttr (none): E: no installed packages by name librttr 0 packages and 0 specfiles checked; 0 errors, 0 warnings. (none): E: no installed packages by name librttr-devel
Source checksums ---------------- https://www.rttr.org/releases/rttr-0.9.6-src.tar.gz : CHECKSUM(SHA256) this package : f62caee43016489320f8a69145c9208cddd72e451ea95618bc26a49a4cd6c990 CHECKSUM(SHA256) upstream package : f62caee43016489320f8a69145c9208cddd72e451ea95618bc26a49a4cd6c990
Requires -------- rttr (rpmlib, GLIBC filtered):
librttr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
librttr-devel (rpmlib, GLIBC filtered): librttr(x86-64) librttr_core.so.0.9.6()(64bit)
Provides -------- rttr: bundled(nonius) rttr rttr(x86-64)
librttr: librttr librttr(x86-64) librttr_core.so.0.9.6()(64bit)
librttr-devel: librttr-devel librttr-devel(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1932616 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Python, R, SugarActivity, Ocaml, Haskell, PHP, Java, Perl, fonts, Ruby
IMHO , 1 - %{_docdir}/index.html and or %{_docdir}/rttr-0-9-6/ should be move to the main sub-package or to doc sub-package file and the that sub-package should be noarch. 2 - html files should be readable
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #2 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- Spec URL: https://dl.kwizart.net/review/rttr.spec SRPM URL: https://dl.kwizart.net/review/rttr-0.9.6-3.fc33.src.rpm Description: Run Time Type Reflection Fedora Account System Username: kwizart
Changelog: - Drop main package - Split docs
Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #3 from Sergio Basto sergio@serjux.com --- Created attachment 1759462 --> https://bugzilla.redhat.com/attachment.cgi?id=1759462&action=edit rttr.spec.patch
Hi,
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license_8md.html is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
/usr/share/doc/rttr-doc/rttr-0-9-6/license_8md.html /usr/share/doc/rttr-doc/rttr-0-9-6/license_page.html these files are fine
so no issues
but please fix doc file permissions :
-find __doc -type f -exec chmod 0640 {} ';' +find __doc -type f -exec chmod 0644 {} ';'
Also notice the name convention is not the standard on Fedora packages should be rttr-libs and rttr-devel .
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #4 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- Thanks for spotting this issue. I've fixed locally.
The packaging guideline enforces the name of the source package to be the same as the archive name. But it's possible for a library only binary package to use lib prefix (and libfoo-devel for the related -devel package). rpm -qi librttr will give you hint about which source package this librtt binary package was created from. I've found curl package that already follow this convention. (using libcurl and libcurl-devel). So I don't think this break assumption.
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Sergio Basto sergio@serjux.com --- (In reply to Nicolas Chauvet (kwizart) from comment #4)
But it's possible for a library only binary package to use lib prefix (and libfoo-devel for the related -devel package).
it is possible but is the Debian convention , not the "RedHat" or Fedora convention , and I prefer the RedHat / fedora one .
rpm -qi librttr will give you hint about which source package this librtt binary package was created from.
IMHO , is just less intuitive .
I've found curl package that already follow this convention. (using libcurl and libcurl-devel). So I don't think this break assumption.
Looking for curl.spec I see many things that would change .
Package APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #6 from Sergio Basto sergio@serjux.com --- by Step 7 of documentation https://fedoraproject.org/wiki/New_package_process_for_existing_contributors
you need do: fedpkg request-repo rttr 1932616
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #7 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- Sure, done one day ago https://pagure.io/releng/fedora-scm-requests/issue/32359 I will wait next week, probably some vacation.
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
--- Comment #8 from Mohan Boddu mboddu@bhujji.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rttr
https://bugzilla.redhat.com/show_bug.cgi?id=1932616
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-03-01 20:58:51
package-review@lists.fedoraproject.org