[Bug 579919] New: Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Summary: Review Request: isight-firmware-tools - Firmware
                    extraction tools for Apple Built-in iSight camera
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.montleon.com/isight-firmware-tools.spec
SRPM URL: http://www.montleon.com/isight-firmware-tools-1.5.90-1.fc13.src.rpm
Description: iSight Firmware Tools provide tools to manipulate firmware for
Built-in iSight cameras found on Apple machines since iMac G5 (November 2005).

This package was orphaned in January and is not available in Fedora 13 Alpha.
See https://bugzilla.redhat.com/show_bug.cgi?id=579137 for more.

This is also my first package and I will need a sponsor if it is approved. I do
already have a Fedora account and have applied for membership to the packager
group.

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Chen Lei  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Chen Lei  2010-05-01 06:28:42 EDT ---
I suggest you to submit some new packages for review, then you can pick up this
package from pkgdb without review request.

See http://fedoraproject.org/wiki/PackageMaintainers/Join

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Fabian Deutsch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

--- Comment #2 from Fabian Deutsch  2010-05-04 06:42:50 EDT ---
rpmlint says something:
$ rpmlint -v isight-firmware-tools.spec 
isight-firmware-tools.spec:40: W: macro-in-comment %doc
isight-firmware-tools.spec: I: checking-url
http://bersace03.free.fr/ift/isight-firmware-tools-1.5.90.tar.gz (timeout 10
seconds)
isight-firmware-tools.spec: W: invalid-url Source0:
http://bersace03.free.fr/ift/isight-firmware-tools-1.5.90.tar.gz HTTP Error
404: Not Found
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

- macro-in-comment: you can fix this by removing the % in line 40.

- invalid-url: The source URL does not exist, you will have to give a correct
url.
(http://launchpad.net/isight-firmware-tools/main/1.6/+download/%%7Bname%7D-%%...
maybe?)

- To sanitize the specfile, it woul dbe nice to replace $RPM_BUILD_ROOT with
%{buildroot}, so you use the %{...} all the time.

- You need to add a builddep on intltool

- Currently th isight udev rule is included with the following line:
%config(noreplace) %{_sysconfdir}/udev/rules.d/isight.rules
so existing udev rules will not be overwritten. I wonder why that is ...
In my case (F13/Rawhide) the isight rule does not match the current udev
syntax, so a warning is generated ...:
SYSFS{}= will be removed in a future udev version, please use ATTR{}= to match
the event device, or ATTRS{}= to match a parent device, in
/etc/udev/rules.d/isight.rules:1
This should also be addressed.

After at least adding the builddep, the package builds fine in koji.

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

--- Comment #3 from Jason  2010-05-16 17:13:11 EDT ---
I have updated the spec file and I think it addresses everything; rpmlint is
now much more quiet. I also created a patch to fix the udev rule and opened a
bug and submitted the patch upstream.

http://www.montleon.com/isight-firmware-tools.spec
http://www.montleon.com/isight-firmware-tools-1.5.90-2.fc13.src.rpm

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

--- Comment #4 from Chen Lei  2010-05-18 04:45:19 EDT ---
(In reply to comment #3)
> I have updated the spec file and I think it addresses everything; rpmlint is
> now much more quiet. I also created a patch to fix the udev rule and opened a
> bug and submitted the patch upstream.
> http://www.montleon.com/isight-firmware-tools.spec
> http://www.montleon.com/isight-firmware-tools-1.5.90-2.fc13.src.rpm

In order to get sponsored, one simple package is normally not enough.

See http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Jason Montleon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Jason Montleon  2010-05-18 09:16:26 EDT ---
I applied for the Fedora Packager CVS Commit Group (packager) group when I
initially submitted the package and was sponsored.

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Chen Lei  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

--- Comment #6 from Chen Lei  2010-05-18 09:45:25 EDT ---
(In reply to comment #5)
> I applied for the Fedora Packager CVS Commit Group (packager) group when I
> initially submitted the package and was sponsored.

The package don't need a review, goto
https://admin.fedoraproject.org/pkgdb/acls/name/isight-firmware-tools, logging
and Taking Ownership of this package.

See
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#Package_C...
to add F13 branch.

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Jason Montleon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Jason Montleon  2010-05-18 13:10:06 EDT ---
Package Change Request
======================
Package Name: isight-firmware-tools
New Branches: F-13
Owners: jmontleon

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #8 from Dennis Gilmore  2010-05-18 14:23:33 EDT ---
CVS Done

[Bug 579919] Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=579919

Chen Lei  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE