[Bug 1194931] New: Review Request: nodejs-each-async - Async concurrent iterator (async forEach) - package-review

List overview All Threads
Download

newer

[Bug 1194931] New: Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

older

[Bug 1233984] New: Review Request:...

[Bug 1194897] New: Review Request:...

Red Hat Bugzilla

20 Feb 2015 20 Feb '15

5:29 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Bug ID: 1194931 Summary: Review Request: nodejs-each-async - Async concurrent iterator (async forEach) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: piotr1212@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://piotrp.fedorapeople.org/nodejs-each-async.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-each-async-1.1.1-1.fc21.src.rpm Description: Async concurrent iterator (async forEach) Fedora Account System Username: piotrp

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

20 Feb 20 Feb

5:30 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1194927, 1194926

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1194926 [Bug 1194926] Review Request: nodejs-set-immediate-shim - Simple setImmediate shim https://bugzilla.redhat.com/show_bug.cgi?id=1194927 [Bug 1194927] Review Request: nodejs-onetime - Only call a function once

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Feb 27 Feb

5:26 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Mar 8 Mar

8:46 a.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #1 from Piotr Popieluch piotr1212@gmail.com --- updated Source0 to comply with github guidelines Spec URL: https://piotrp.fedorapeople.org/nodejs-each-async.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-each-async-1.1.1-2.fc21.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Mar 13 Mar

12:04 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931 Bug 1194931 depends on bug 1194927, which changed state.

Bug 1194927 Summary: Review Request: nodejs-onetime - Only call a function once https://bugzilla.redhat.com/show_bug.cgi?id=1194927

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 May 23 May

12:13 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Zuzana Svetlikova zsvetlik@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Jun 5 Jun

6:57 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931 Bug 1194931 depends on bug 1194926, which changed state.

Bug 1194926 Summary: Review Request: nodejs-set-immediate-shim - Simple setImmediate shim https://bugzilla.redhat.com/show_bug.cgi?id=1194926

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Jun 7 Jun

5:39 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Zuzana Svetlikova zsvetlik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

--- Comment #2 from Zuzana Svetlikova zsvetlik@redhat.com --- There is missing BuildRequires on npm(set-immediate-shim) and npm(onetime) should be outside the conditional. Is there a reason why the tests are turned off?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Jun 13 Jun

2:59 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #3 from Piotr Popieluch piotr1212@gmail.com --- - added set-immediate-shim to BR. - all Requires: are handled automatically by nodejs-packaging so not needed to specify outside the conditional. Tests are turned of due to circular dependencies. will enable tests as soon as all missing deps are in Fedora

Spec URL: https://piotrp.fedorapeople.org/nodejs-each-async.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-each-async-1.1.1-2.fc22.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Jun 15 Jun

8:18 a.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #4 from Zuzana Svetlikova zsvetlik@redhat.com --- I believe all the dependencies are in fedora stable repository, so you can turn the tests on.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:22 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- You are correct, BR's are now included. tests succeed. Updates spec and srpm (without version bump, same url)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Jun 16 Jun

6:23 a.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Zuzana Svetlikova zsvetlik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #6 from Zuzana Svetlikova zsvetlik@redhat.com --- Seems fine.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-each-async-1.1.1-2.fc22.noarch.rpm nodejs-each-async-1.1.1-2.fc22.src.rpm nodejs-each-async.noarch: W: spelling-error Summary(en_US) forEach -> for Each, for-each, reach nodejs-each-async.noarch: W: spelling-error %description -l en_US forEach -> for Each, for-each, reach nodejs-each-async.noarch: W: only-non-binary-in-usr-lib nodejs-each-async.noarch: W: dangling-symlink /usr/lib/node_modules/each-async/node_modules/onetime /usr/lib/node_modules/onetime nodejs-each-async.noarch: W: dangling-symlink /usr/lib/node_modules/each-async/node_modules/set-immediate-shim /usr/lib/node_modules/set-immediate-shim nodejs-each-async.src: W: spelling-error Summary(en_US) forEach -> for Each, for-each, reach nodejs-each-async.src: W: spelling-error %description -l en_US forEach -> for Each, for-each, reach 2 packages and 0 specfiles checked; 0 errors, 7 warnings.

Rpmlint (installed packages) ---------------------------- nodejs-each-async.noarch: W: spelling-error Summary(en_US) forEach -> for Each, for-each, reach nodejs-each-async.noarch: W: spelling-error %description -l en_US forEach -> for Each, for-each, reach nodejs-each-async.noarch: W: only-non-binary-in-usr-lib nodejs-each-async.noarch: W: dangling-symlink /usr/lib/node_modules/each-async/node_modules/onetime /usr/lib/node_modules/onetime nodejs-each-async.noarch: W: dangling-symlink /usr/lib/node_modules/each-async/node_modules/set-immediate-shim /usr/lib/node_modules/set-immediate-shim 1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Requires -------- nodejs-each-async (rpmlib, GLIBC filtered): nodejs(engine) npm(onetime) npm(set-immediate-shim)

Provides -------- nodejs-each-async: nodejs-each-async npm(each-async)

Source checksums ---------------- https://github.com/sindresorhus/each-async/archive/65f7f663e0e1a323c11bd0e03... : CHECKSUM(SHA256) this package : 97323445b091729789936265371aa98df1ea03ee9b7bf3410e1638a3ca9b6497 CHECKSUM(SHA256) upstream package : 97323445b091729789936265371aa98df1ea03ee9b7bf3410e1638a3ca9b6497

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -m fedora-22-x86_64 -b 1194931 Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:41 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #7 from Piotr Popieluch piotr1212@gmail.com --- New Package SCM Request ======================= Package Name: nodejs-each-async Short Description: Async concurrent iterator (async forEach) Upstream URL: https://github.com/sindresorhus/each-async Owners: piotrp Branches: f21 f22 el6 epel7

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:52 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:39 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:40 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-each-async-1.1.1-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-each-async-1.1.1-2.fc22

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Jun 18 Jun

4:04 a.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #10 from Zuzana Svetlikova zsvetlik@redhat.com --- Can you build this for f21 too?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:03 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-each-async-1.1.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-each-async-1.1.1-2.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Jun 20 Jun

7:29 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-each-async-1.1.1-2.fc21 has been pushed to the Fedora 21 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Jul 3 Jul

1:42 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Fedora Update System updates@fedoraproject.org changed:

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-each-async-1.1.1-2.fc21 has been pushed to the Fedora 21 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:45 p.m.

New subject: [Bug 1194931] Review Request: nodejs-each-async - Async concurrent iterator (async forEach)

https://bugzilla.redhat.com/show_bug.cgi?id=1194931

Fedora Update System updates@fedoraproject.org changed:

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-each-async-1.1.1-2.fc22 has been pushed to the Fedora 22 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3672

Age (days ago)

3805

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla