[Bug 487263] New: Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review request: preferences-menus - Categorized submenus for the Preferences
menu

https://bugzilla.redhat.com/show_bug.cgi?id=487263

           Summary: Review request: preferences-menus - Categorized
                    submenus for the Preferences menu
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: mclasen(a)redhat.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Spec URL: http://people.redhat.com/mclasen/preferences-menus.spec
SRPM URL: http://people.redhat.com/mclasen/preferences-menus-1-1.fc11.src.rpm

Description:

This package recreates the Preferences submenus that Fedora used to have
by default in F10 and earlier.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade(a)gmail.com
         AssignedTo|nobody(a)fedoraproject.org    |panemade(a)gmail.com
               Flag|                            |fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263





--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-02-25 01:19:03 EDT
---
1) Good to add versioned requires

2) From http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream , 
    Will you please add comment in SPEC file. Otherwise I see no way to verify
source here.

3) From review guidelines,
   SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

4) Though for such small package where no upstream release happened, it looks
not really needed but good to follow guidelines
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps
==> Add -p to install command

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263





--- Comment #2 from Matthias Clasen <mclasen(a)redhat.com&gt;  2009-02-25 09:43:30 EDT
---
I've added the versioned requires, add a comment and even did the -p.

Then, I've queried upstream (myself), but upstream said no.

New files in the same location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Matthias Clasen <mclasen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora_requires_release_not
                   |                            |e+




--- Comment #3 from Matthias Clasen <mclasen(a)redhat.com&gt;  2009-02-25 22:13:47 EDT
---
We should probably release-note this:

The Preferences menu does no longer have submenus. This change was done since
deep menu hierarchies are difficult to navigate for many users, and the
category-based submenus were not terribly obvious. If you are used to the
submenus, and prefer to keep the Peferences menu organized in this way, install
the preferences-menus package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-02-25 22:41:03 EDT
---
(In reply to comment #2)
>  I've added the versioned requires, add a comment and even did the
> -p.
>   
OK.

>  Then, I've queried upstream (myself), but upstream said no.
 Nice comment.

>  
>  New files in the same location. 
thanks.

koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1182091
+ rpmlint is Not silent but ok to accept.
preferences-menus.noarch: W: no-documentation
preferences-menus.noarch: W: no-url-tag
+ Rest looks following packaging guidelines.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Matthias Clasen <mclasen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #5 from Matthias Clasen <mclasen(a)redhat.com&gt;  2009-02-25 23:42:42 EDT
---
New Package CVS Request
=======================
Package Name: preferences-menus 
Short Description: Categorized submenus for the Preferences menu
Owners: mclasen
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Kevin Fenzi <kevin(a)tummy.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




--- Comment #6 from Kevin Fenzi <kevin(a)tummy.com&gt;  2009-02-26 19:09:39 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 487263] Review request: preferences-menus - Categorized submenus for the Preferences menu

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263


Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




--- Comment #7 from Parag AN(पराग) <panemade(a)gmail.com&gt;  2009-03-04 00:11:18 EDT
---
looks this package is already built for requested branches therefore closing
this review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.