Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libnss-pgsql - NSS library that interface with PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Summary: Review Request: libnss-pgsql - NSS library that interface with PostgreSQL Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: madko@linuxed.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, mtasaka@ioa.s.u-tokyo.ac.jp, musuruan@gmail.com, felipe.contreras@gmail.com, itamar@ispbrasil.com.br, erik-fedora@vanpienbroek.nl, jussi.lehtola@iki.fi, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.linuxed.net/~madko/fedora/libnss-pgsql.spec SRPM URL: http://www.linuxed.net/~madko/fedora/libnss-pgsql-1.4.0-2.fc10.src.rpm
Description: Name Service Switch library that interface with PostgreSQL.
more info on http://pgfoundry.org/projects/sysauth/
Having 1 rpmlint warning on this package: W: shared-lib-calls-exit /usr/lib64/libnss_pgsql.so.2.0.0 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-01-23 11:16:33 EDT --- For 1.4.0-2
* Latest version - The last stable version (1.4.0) seems to have been released 3 years ago. While the latest version is still beta (1.5.0-beta), it was released last August (i.e. 5 months ago) and as the last stable version seems old, I think using 1.5.0 beta seems preferable for Fedora. How do you think?
* autotool recall - build.log shows: ------------------------------------- 46 + ./configure --build=i386-redhat-linux-gnu ...... 47 checking for a BSD-compatible install... 48 /usr/bin/install -c 49 checking whether build environment is sane... 50 yes .... 372 + make -j4 373 cd . && /builddir/build/BUILD/libnss-pgsql-1.4.0/autoconf/missing aclocal-1.4 374 WARNING: `aclocal-1.4' is missing on your system. You should only need it if 375 you modified `acinclude.m4' or `configure.in'. You might want 376 to install the `Automake' and `Perl' packages. Grab them from 377 any GNU archive site. 378 cd . && /builddir/build/BUILD/libnss-pgsql-1.4.0/autoconf/missing automake-1.4 --gnu Makefile 379 cd . && /builddir/build/BUILD/libnss-pgsql-1.4.0/autoconf/missing autoconf 380 WARNING: `automake-1.4' is missing on your system. You should only need it if 381 you modified `Makefile.am', `acinclude.m4' or `configure.in'. 382 You might want to install the `Automake' and `Perl' packages. 383 Grab them from any GNU archive site. 384 WARNING: `autoconf' is missing on your system. You should only need it if 385 you modified `configure.in'. You might want to install the 386 `Autoconf' and `GNU m4' packages. Grab them from any GNU 387 archive site. 388 /bin/sh ./config.status --recheck 389 running /bin/sh ./configure --build=i386-redhat-linux-gnu .... .... 710 cd . \ 711 && CONFIG_FILES=Makefile CONFIG_HEADERS= /bin/sh ./config.status 712 config.status: creating Makefile 713 config.status: executing default-1 commands 714 cd . && /builddir/build/BUILD/libnss-pgsql-1.4.0/autoconf/missing autoheader
------------------------------------- Here autotools are automatically called after calling make command, this is not expected. This is usually because timestamps on some files related to autotools are wrong. Please fix so that autotools are not called automatically after make.
* Documents - Please add the following files to %doc. ------------------------------------- AUTHORS COPYING ChangeLog README -------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #2 from Edouard Bourguignon madko@linuxed.net 2009-01-23 12:52:23 EDT --- * We can give a try to the beta version, I didn't notice the 1.4.0 was so old. I try to follow the naming guidelines for beta version, hope I'm right.
* Now beta is built without autotools being automatically called
* Missing documents have been added
But there is still the warning about the shared-lib-calls-exit...
Here are the links: SPEC: http://www.linuxed.net/~madko/fedora/libnss-pgsql.spec SRPM: http://www.linuxed.net/~madko/fedora/libnss-pgsql-1.5.0-0.1.beta.fc10.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-01-24 11:03:59 EDT --- Created an attachment (id=329912) --> (https://bugzilla.redhat.com/attachment.cgi?id=329912) patch to remove exit() call in the library
For 1.5.0-0.1.beta1:
* SourceURL - SourceURL is not correct. 605 should be 1878
* About shared-lib-calls-exit rpmlint - As $ rpmlint -I shared-lib-calls-exit shows, libraries should not call exit() inner themselves. The attached patch will remove this rpmlint. If you are happy with my patch please apply the patch. However I won't regard this rpmlint as a blocker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #4 from Edouard Bourguignon madko@linuxed.net 2009-01-25 11:47:41 EDT --- * SourceURL has been fixed * Your patch has been included. I'm on the way to upstream it
Here are the links: SPEC: http://www.linuxed.net/~madko/fedora/libnss-pgsql.spec SRPM: http://www.linuxed.net/~madko/fedora/libnss-pgsql-1.5.0-0.2.beta.fc10.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-01-26 12:59:46 EDT --- Okay.
-------------------------------------------------------- This package (libnss-pgsql) is APPROVED by mtasaka --------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Edouard Bourguignon madko@linuxed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Edouard Bourguignon madko@linuxed.net 2009-01-26 14:03:01 EDT --- New Package CVS Request ======================= Package Name: libnss-pgsql Short Description: Name Service Switch library that interface with PostgreSQL Owners: madko Branches: F-10 F-9 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-01-26 17:53:55 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #8 from Edouard Bourguignon madko@linuxed.net 2009-01-27 03:09:15 EDT --- thank you
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-01-29 18:03:00 EDT --- libnss-pgsql-1.5.0-0.2.beta.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update libnss-pgsql'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1095
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-01-29 18:11:50 EDT --- libnss-pgsql-1.5.0-0.2.beta.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libnss-pgsql'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1186
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE
--- Comment #11 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-01-30 09:56:24 EDT --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:27:38 EDT --- libnss-pgsql-1.5.0-0.2.beta.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |1.5.0-0.2.beta.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:30:56 EDT --- libnss-pgsql-1.5.0-0.2.beta.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481173
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.5.0-0.2.beta.fc9 |1.5.0-0.2.beta.fc10
package-review@lists.fedoraproject.org