https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Bug ID: 1287080 Summary: Review Request: perl-Test-Class-Most - Test Classes the easy way Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most.... SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most-...
Description: When people write test classes with the excellent Test::Class, you often see the following at the top of the code:
package Some::Test::Class;
use strict; use warnings; use base 'My::Test::Class'; use Test::More; use Test::Exception;
# and then the tests ...
With the module, you can do this:
use Test::Class::Most parent => 'My::Test::Class';
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
--- Comment #1 from Petr Šabata psabata@redhat.com --- * Consider a better description. One without code. E.g. something along the lines of `reduce boilerplate when writing tests based on Test::Class'.
* Missing a BR: lib, t/test_class_load.t:9
* Add a version constraint to the explicitly required Test::Most, 0.31+.
* Also require Test::Class 0.38+ and filter out the underspecified dependency.
* Use a lowercase `c' in `classes' in your summary. Alternatively, insert a double colon like `Test::Classes the easy way'.
No other issues.
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1287121
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1287121 [Bug 1287121] Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Petr Šabata from comment #1)
- Consider a better description. One without code. E.g. something along the lines of `reduce boilerplate when writing tests based on Test::Class'.
Updated
- Missing a BR: lib, t/test_class_load.t:9
Added
- Add a version constraint to the explicitly required Test::Most, 0.31+.
- Also require Test::Class 0.38+ and filter out the underspecified
dependency.
Added
- Use a lowercase `c' in `classes' in your summary. Alternatively, insert a double colon like `Test::Classes the easy way'.
Updated
The updated files are on the same link.
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata psabata@redhat.com --- Ack, all four addressed. Approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |perl-Test-Class-Most - Test |perl-Test-Class-Most - Test |Classes the easy way |classes the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Test-Class-Most
https://bugzilla.redhat.com/show_bug.cgi?id=1287080
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Test-Class-Most-0.08-1 | |.fc24 Resolution|--- |RAWHIDE Last Closed| |2015-12-02 09:41:43
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org