https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Bug ID: 1171263 Summary: Review Request: nodejs-istanbul - A JS code coverage tool written in JS Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: piotr1212@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://piotrp.fedorapeople.org/nodejs-istanbul.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-istanbul-0.3.2-1.fc21.src.rpm Description: A JS code coverage tool written in JS Fedora Account System Username: piotrp
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1171221
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171221 [Bug 1171221] Review Request: nodejs-handlebars - Build semantic templates effectively with no frustration
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171302
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171302 [Bug 1171302] Review Request: nodejs-sentence-case - Sentence case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171303
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171303 [Bug 1171303] Review Request: nodejs-upper-case - Upper case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171306
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171306 [Bug 1171306] Review Request: nodejs-camel-case - Camel case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171309
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171309 [Bug 1171309] Review Request: nodejs-upper-case-first - Upper case the first character of a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171311
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171311 [Bug 1171311] Review Request: nodejs-lower-case - Lowercase a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171314
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171314 [Bug 1171314] Review Request: nodejs-snake-case - Snake case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171320
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171320 [Bug 1171320] Review Request: nodejs-title-case - Title case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171323
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171323 [Bug 1171323] Review Request: nodejs-swap-case - Swap the case of a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171327
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171327 [Bug 1171327] Review Request: nodejs-path-case - Path case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171334
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171334 [Bug 1171334] Review Request: nodejs-pascal-case - Pascal case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171335
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171335 [Bug 1171335] Review Request: nodejs-param-case - Param case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171336
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171336 [Bug 1171336] Review Request: nodejs-is-upper-case - Check if a string is upper cased
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171338
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171338 [Bug 1171338] Review Request: nodejs-is-lower-case - Check if a string is lower cased
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171345
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171345 [Bug 1171345] Review Request: nodejs-constant-case - Constant case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171350
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171350 [Bug 1171350] Review Request: nodejs-change-case - Convert a string between camelCase, PascalCase, Title Case, snake_case and more
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1123537
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1123537 [Bug 1123537] Review Request: nodejs-handlebars - Mustache extension for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1171263 Bug 1171263 depends on bug 1171221, which changed state.
Bug 1171221 Summary: Review Request: nodejs-handlebars - Build semantic templates effectively with no frustration https://bugzilla.redhat.com/show_bug.cgi?id=1171221
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review:
+ Package built successful in mock (f22 x86_64)
+ rpmlint on generated rpms gave output nodejs-entities.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ Source verified with upstream as (sha256sum) srpm tarball: 1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced upstream tarball: 1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced
- License is "BSD" and not "MIT.
+ License text is included in its own LICENSE file.
+ follows nodejs packaging guidelines.
Suggestions: 1) Group tag is optional, can be removed.
2) Fix license tag
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- oops! my bad. I have many tabs open and I wrote wrong review above. Here is correct one
Review: - Package built successful in mock (f22 x86_64)
+ Source istanbul-0.3.2.tgz verified with upstream as (sha256sum) srpm tarball: 95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d upstream tarball: 95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d
+ License is "BSD" and included in its own LICENSE file.
+ follows nodejs packaging guidelines.
Suggestions: 1) Group tag is optional, can be removed.
2) tests are failing with error Cannot find module '../dist/cjs/handlebars' Error: Cannot find module '../dist/cjs/handlebars'
Please fix the tests or disable them by filing upstream issue with using tests.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #3 from Piotr Popieluch piotr1212@gmail.com --- Seems like a bug in nodejs-handlebars, tests did succeed here (with my variant of handlebars)
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1171403
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1171403 [Bug 1171403] dist dir not packaged
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-handlebars-2.0.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-handlebars-2.0.0-3.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- I tried above handlebars update but for me local build still complains same Cannot find module '../dist/cjs/handlebars' Error: Cannot find module '../dist/cjs/handlebars'
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- Ah and after disabling tests in nodejs-istanbul.spec, building it, I got a file name conflict Error: Transaction check error: file /usr/bin/istanbul from install of nodejs-istanbul-0.3.2-1.fc21.noarch conflicts with file from package istanbul-0.2.2-22.fc21.x86_64
Maybe you should install it as istanbul-js
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ASSIGNED
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- I found packaging issue with nodejs-handlebars and reported in bug 1172471.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #8 from Piotr Popieluch piotr1212@gmail.com --- Thank you. I was actually looking into it right now, you beat me ;)
updated spec and srpm: Spec URL: https://piotrp.fedorapeople.org/nodejs-istanbul.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-istanbul-0.3.2-3.fc21.src.rpm
- Renamed binary name to prevent conflict - Temporary disabled tests because of RHBZ#1172471 - Removed group tag - Added rm -rf node_modules
Only actually using istanbul gives me the same error as the test because of missing dist dir:
➜ rpmbuild /usr/bin/istanbul-js Cannot find module '../dist/cjs/handlebars' Error: Cannot find module '../dist/cjs/handlebars' at Function.Module._resolveFilename (module.js:338:15) at Function.Module._load (module.js:280:25) at Module.require (module.js:364:17) at require (module.js:380:17) at Object.<anonymous> (/usr/lib/node_modules/handlebars/index.js:6:18) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17)
Error: Could not register report from file html.js at /usr/lib/node_modules/istanbul/lib/util/factory.js:60:27 at Array.forEach (native) at Object.Factory.loadStandard (/usr/lib/node_modules/istanbul/lib/util/factory.js:53:29) at Object.<anonymous> (/usr/lib/node_modules/istanbul/lib/register-plugins.js:11:8) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17) at require (module.js:380:17)
Should we wait on https://bugzilla.redhat.com/show_bug.cgi?id=1172471 before approving?
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- I don't think we need to wait for bug 1172471 and also I need this package badly for some of my upcoming nodejs package reviews.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Piotr Popieluch piotr1212@gmail.com --- New Package SCM Request ======================= Package Name: nodejs-istanbul Short Description: A JS code coverage tool written in JS Upstream URL: https://github.com/gotwarlost/istanbul Owners: piotrp Branches: f19 f20 f21 el6 epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-istanbul-0.3.2-3.el7
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-12-19 15:04:45
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-istanbul-0.3.2-3.fc2 | |0 Resolution|NEXTRELEASE |ERRATA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-istanbul-0.3.2-3.fc2 |nodejs-istanbul-0.3.2-3.fc2 |0 |1
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1171263 Bug 1171263 depends on bug 1171403, which changed state.
Bug 1171403 Summary: dist dir not packaged https://bugzilla.redhat.com/show_bug.cgi?id=1171403
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1171263 Bug 1171263 depends on bug 1123537, which changed state.
Bug 1123537 Summary: Review Request: nodejs-handlebars - Mustache extension for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=1123537
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1171263
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- nodejs-istanbul-0.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org