https://bugzilla.redhat.com/show_bug.cgi?id=1911296
Bug ID: 1911296 Summary: Review Request: python-enrich - Enrich adds few missing features to the wonderful rich library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: chedi.toueiti@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://chedi.fedorapeople.org/python-enrich-1.2.6-1.fc33.src.rpm SRPM URL: https://chedi.fedorapeople.org/python-enrich.spec Description: Enrich adds few missing features to the wonderful rich library Fedora Account System Username: chedi
https://bugzilla.redhat.com/show_bug.cgi?id=1911296
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jamatos@fc.up.pt Assignee|nobody@fedoraproject.org |jamatos@fc.up.pt Doc Type|--- |If docs needed, set a value Flags| |fedora-review+
--- Comment #1 from José Matos jamatos@fc.up.pt --- The license is correct and appropriated for Fedora. The spec file is simple and correct.
fedora-review has no complaint.
The only quirk that I found in the srpm is the description a bit confusing. I suggest something like:
python-enrich extends the python rich library...
This can be fixed on import. The package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1911296
--- Comment #2 from chedi toueiti chedi.toueiti@gmail.com --- @José
First, thanks for taking the time to review this package. As for the description, I know it's a little bit confusing but the original pypi package name is simply enrich.
I think most fedora python package user are in the know that the package name starting with python?- rarely reflects the original pypi name.
https://bugzilla.redhat.com/show_bug.cgi?id=1911296
--- Comment #3 from Igor Raits igor.raits@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-enrich
https://bugzilla.redhat.com/show_bug.cgi?id=1911296
chedi toueiti chedi.toueiti@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1911296
chedi toueiti chedi.toueiti@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-07-13 14:17:25
package-review@lists.fedoraproject.org