[Bug 2363929] New: Review Request: perl-File-ShareDir-Tiny - Locate per-dist and per-module shared files
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Bug ID: 2363929 Summary: Review Request: perl-File-ShareDir-Tiny - Locate per-dist and per-module shared files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cra@fea.st QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... Description: Quite often you want or need your Perl module (CPAN or otherwise) to have access to a large amount of read-only data that is stored on the file-system at run-time.
On a linux-like system, this would be in a place such as /usr/share, however Perl runs on a wide variety of different systems, and so the use of any one location is unreliable.
This module provides a more portable way to have (read-only) data for your module.
Fedora Account System Username: cra
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #1 from Charles R. Anderson cra@fea.st --- perl-Crypt-Argon2-0.030 build now requires:
perl-Dist-Build-0.020-1.fc43
which requires:
perl-ExtUtils-Builder-0.017-1.fc43 perl-ExtUtils-Builder-Compiler-0.031-1.fc43 perl-File-ShareDir-Tiny-0.001-1.fc43
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://metacpan.org/dist/F | |ile-ShareDir-Tiny Keywords| |AutomationTriaged
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8994406 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Charles R. Anderson cra@fea.st changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2363933
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2363933 [Bug 2363933] Review Request: perl-Dist-Build - Modern module builder with author tools not included
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Peter Oliver mavit@mavit.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mavit@mavit.org.uk
--- Comment #3 from Peter Oliver mavit@mavit.org.uk --- Swap you for a review of https://bugzilla.redhat.com/show_bug.cgi?id=2360688 ?
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |jplesnik@redhat.com CC| |jplesnik@redhat.com
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires
FIX: Add build-require 'coreutils' it is needed for %{_fixperms} TODO: Please replace perl-blib by 'perl(blib)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version.
$ rpm -qp --requires perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 2 perl(Exporter) >= 5.57 1 perl(File::Spec::Functions) 1 perl-libs 1 perl(strict) 1 perl(warnings) FIX: Remove duplicit definition of run-require perl(Exporter).
Otherwise binary requires are Ok.
$ rpm -qp --provides perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort | uniq -c 1 perl(File::ShareDir::Tiny) = 0.001 1 perl-File-ShareDir-Tiny = 0.001-2.fc43 Binary provides are Ok.
$ rpmlint ./perl-File-ShareDir-Tiny* ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4
perl-File-ShareDir-Tiny.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 9 filtered, 1 badness; has taken 0.3 s Rpmlint is ok
TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.
Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.
Resolution: NOT Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #5 from Charles R. Anderson cra@fea.st --- (In reply to Jitka Plesnikova from comment #4)
FIX: Add build-require 'coreutils' it is needed for %{_fixperms} TODO: Please replace perl-blib by 'perl(blib)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
The above items are all fixed:
Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny...
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #7 from Charles R. Anderson cra@fea.st --- Corrected URLs:
Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny...
(In reply to Fedora Review Service from comment #6)
There seems to be some problem with the following file. SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny... 0.001-3.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2104196 --> https://bugzilla.redhat.com/attachment.cgi?id=2104196&action=edit The .spec file difference from Copr build 8994406 to 9450914
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9450914 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #10 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Charles R. Anderson from comment #5)
(In reply to Jitka Plesnikova from comment #4)
FIX: Add build-require 'coreutils' it is needed for %{_fixperms} TODO: Please replace perl-blib by 'perl(blib)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
10a11 + BuildRequires: coreutils 12c13 - BuildRequires: perl-blib --- + BuildRequires: perl(blib) 19c20 - BuildRequires: perl(ExtUtils::MakeMaker) --- + BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 29d29 - Requires: perl(Exporter) >= 5.57 62,63c62,65 - %{perl_vendorlib}/* - %{_mandir}/man3/* --- + %dir %{perl_vendorlib}/File + %dir %{perl_vendorlib}/File/ShareDir + %{perl_vendorlib}/File/ShareDir/Tiny.pm + %{_mandir}/man3/File::ShareDir::Tiny.3pm*
Changes look good.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #11 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-File-ShareDir-Tiny
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-f6a84afc2c (perl-File-ShareDir-Tiny-0.001-3.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6a84afc2c
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-904e1c360b (perl-File-ShareDir-Tiny-0.001-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-904e1c360b
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-0c6eabaca6 (perl-File-ShareDir-Tiny-0.001-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-0c6eabaca6
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #15 from Charles R. Anderson cra@fea.st --- FEDORA-2025-512353a61b (perl-File-ShareDir-Tiny-0.001-3.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-512353a61b
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Charles R. Anderson cra@fea.st changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|MODIFIED |CLOSED Last Closed| |2025-08-27 00:57:10
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-f6a84afc2c has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f6a84afc2c *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6a84afc2c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-904e1c360b has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-904e1c360b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-904e1c360b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-0c6eabaca6 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-0c6eabaca6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-0c6eabaca6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-0c6eabaca6 (perl-File-ShareDir-Tiny-0.001-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-904e1c360b (perl-File-ShareDir-Tiny-0.001-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2363929
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-f6a84afc2c (perl-File-ShareDir-Tiny-0.001-3.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com