[Bug 1900145] New: Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Bug ID: 1900145 Summary: Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bruno@victoria.frmug.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 476234 Target Milestone: --- Classification: Fedora
Spec URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder.spec SRPM URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder-0.16.2-0.20201118030309.s2659M.fc33.src.rpm Description: ProjectBuilder is a perl module providing set of functions to help develop packages for projects and deal with different Operating systems (Linux distributions, Solaris, ...). It implements a Continuous Packaging approach. Fedora Account System Username: bcornec
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=476234 [Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Bruno Cornec bruno@victoria.frmug.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Bruno Cornec bruno@victoria.frmug.org --- I'm the upstream maintainer of this SW.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Bruno Cornec bruno@victoria.frmug.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1900146
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1900146 [Bug 1900146] Review Request: perl-MondoRescue - perl modules for MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Bruno Cornec bruno@victoria.frmug.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|476234 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=476234 [Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jplesnik@redhat.com Flags| |needinfo?(bruno@victoria.fr | |mug.org)
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Do you want to add the package to EPEL 7? If not, there is a lot of code which can be removed.
Btw. the source link does not work.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1900146 Depends On|1900146 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1900146 [Bug 1900146] Review Request: perl-MondoRescue - perl modules for MondoRescue
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Bruno Cornec bruno@victoria.frmug.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bruno@victoria.fr | |mug.org) |
--- Comment #3 from Bruno Cornec bruno@victoria.frmug.org --- Yes this SW works for a large set of LInux distributions (CentOS, RHEL, Fedora included) I'm not sure why the links are not working for you however, as I just checked again and they do for me.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com
--- Comment #4 from Petr Pisar ppisar@redhat.com --- The Url value works, but the server redirects to http://trac.project-builder.org/. Please add the trailing slash to the Url value in the spec file. Source value does not work. The spec file links to ftp://ftp.project-builder.org/test/src/ProjectBuilder-0.16.2.0.20201118030309.tar.gz, but there is no such file on the server. The only similar file there is ProjectBuilder-0.16.2.0.20210106113635.tar.gz. Please update your spec file the new upstream release.
I also recommend you reading Fedora packaging guide lines https://docs.fedoraproject.org/en-US/packaging-guidelines/ and update your spec file accordingly:
Group and BuildRoot tags should not used https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Release value must use %{?dist} macro https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/. You need to specify all build-time dependencies (perl-interpreter for perl program, make for make, findutils for find, coreutils for rm, and perl(FOO) for any FOO Perl module used from your tests). You should use %{make_build} and %{make_install} macros instead of "make %{?_smp_mflags}" and "make DESTDIR=${RPM_BUILD_ROOT} install". Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ and https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker how to package Perl code in Fedora. You should remove %clean section. You should remove %defattr(-,root,root,-) from %files section. You have to use %license macro for the COPYING file https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Also, if it's possible, it'd be *greatly* preferred if the links are HTTPS instead of HTTP or FTP.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #6 from code@musicinmybrain.net --- In addition to the good suggestions already given here, please consider applying the fedora-review tool to your own package, as a lot of the things that need to be changed are ones it will flag automatically.
https://bugzilla.redhat.com/show_bug.cgi?id=1900145
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Bruno Cornec bruno@victoria.frmug.org's needinfo: Bug 1900145: Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue https://bugzilla.redhat.com/show_bug.cgi?id=1900145
--- Comment #8 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com