https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Bug ID: 1224420 Summary: Review Request: iio-sensor-proxy - IIO accelerometer sensor to input device proxy Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy-1.0-1.fc... Description: IIO accelerometer sensor to input device proxy. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- initial inspection looks good, just one small non-blocking suggestion:
1. consider using %{_udevrulesdir} macro instead of home-brewed %{udevdir}/rules.d
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (In reply to Rex Dieter from comment #1)
initial inspection looks good, just one small non-blocking suggestion:
- consider using %{_udevrulesdir} macro instead of home-brewed
%{udevdir}/rules.d
Fixed
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/iio-sensor-proxy-1.0-2.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Rex Dieter rdieter@math.unl.edu --- naming: ok
sources: ok c63fd69023a52adf369a371d22cc2ece iio-sensor-proxy-1.0.tar.xz
2. %build SHOULD be verbose, please add %configure --disable-silent-rules or use %make_build V=1
macros: ok
scriptlets ok
3. license: NOT ok, most(many?) sources are GPLv2 only, so MUST use: License: GPLv2
builds/installs/uninstalls: ok
Only real blocker is the minor licensing tag, since it's mostly cosmetic, please fix prior to importing.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Igor Gnatenko i.gnatenko.brain@gmail.com --- New Package SCM Request ======================= Package Name: iio-sensor-proxy Short Description: IIO accelerometer sensor to input device proxy Upstream URL: https://github.com/hadess/iio-sensor-proxy Owners: ignatenkobrain hadess Branches: f22
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- iio-sensor-proxy-1.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/iio-sensor-proxy-1.0-3.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- iio-sensor-proxy-1.0-3.fc22 has been pushed to the Fedora 22 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- iio-sensor-proxy-1.0-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/iio-sensor-proxy-1.0-6.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1224420
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |iio-sensor-proxy-1.0-6.fc22 Resolution|--- |ERRATA Last Closed| |2015-07-03 14:49:48
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- iio-sensor-proxy-1.0-6.fc22 has been pushed to the Fedora 22 stable repository.
package-review@lists.fedoraproject.org