https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Bug ID: 1078371 Summary: Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tchollingsworth@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: http://patches.fedorapeople.org/js-future/SPECS/js-jquery1.spec SRPM: http://patches.fedorapeople.org/js-future/SRPMS/js-jquery1-1.11.0-0.1.fc20.s... FAS: patches Description: jQuery is a fast, small, and feature-rich JavaScript library. It makes things like HTML document traversal and manipulation, event handling, animation, and Ajax much simpler with an easy-to-use API that works across a multitude of browsers. With a combination of versatility and extensibility, jQuery has changed the way that millions of people write JavaScript.
This version of jQuery should be used for web applications which need to support legacy browsers such as IE6.
-- This is an experimental package that does not yet meet Fedora standards. It uses npm to install build dependencies to work around ones missing from the distribution. However, the package is otherwise fully built during the rpmbuild process and the binary RPM is identical to what would be produced by a proper spec.
Please use it to test dependent packages. It is also available in this copr: http://copr.fedoraproject.org/coprs/patches/js-future
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1078359 (js-reviews) Whiteboard| |NotReady
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |603937, 858027, 959946, | |974725 (ghc-pretty-show), | |1006575, 1008083 (hoogle) CC| |gregor@freenet.de
--- Comment #1 from T.C. Hollingsworth tchollingsworth@gmail.com --- *** Bug 857992 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=603937 [Bug 603937] ipython bundles libraries https://bugzilla.redhat.com/show_bug.cgi?id=858027 [Bug 858027] Review Request: jquery-ui - JavaScript library of interface components based on jQuery https://bugzilla.redhat.com/show_bug.cgi?id=959946 [Bug 959946] phpMyAdmin-4.1.9 is available https://bugzilla.redhat.com/show_bug.cgi?id=974725 [Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values https://bugzilla.redhat.com/show_bug.cgi?id=1006575 [Bug 1006575] ipython: please package new upstream version (1.1) https://bugzilla.redhat.com/show_bug.cgi?id=1008083 [Bug 1008083] Review Request: hoogle - Haskell API Search
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1078364, 977125, 977141
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=977125 [Bug 977125] Review Request: nodejs-grunt-contrib-uglify - Minify files with UglifyJS https://bugzilla.redhat.com/show_bug.cgi?id=977141 [Bug 977141] Review Request: nodejs-grunt-init - Generate project scaffolding from a template https://bugzilla.redhat.com/show_bug.cgi?id=1078364 [Bug 1078364] Review Request: js-sizzle - A pure-JavaScript CSS selector engine
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |js-jquery1
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 Bug 1078371 depends on bug 977141, which changed state.
Bug 977141 Summary: Review Request: nodejs-grunt-init - Generate project scaffolding from a template https://bugzilla.redhat.com/show_bug.cgi?id=977141
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1078903
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1078903 [Bug 1078903] jQuery
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1078368
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 Bug 1078371 depends on bug 977125, which changed state.
Bug 977125 Summary: Review Request: nodejs-grunt-contrib-uglify - Minify files with UglifyJS https://bugzilla.redhat.com/show_bug.cgi?id=977125
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1086729
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1086729 [Bug 1086729] builds page is unusable without allowing 3rd party javascript
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 Bug 1078371 depends on bug 977125, which changed state.
Bug 977125 Summary: Review Request: nodejs-grunt-contrib-uglify - Minify files with UglifyJS https://bugzilla.redhat.com/show_bug.cgi?id=977125
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 Bug 1078371 depends on bug 977125, which changed state.
Bug 977125 Summary: Review Request: nodejs-grunt-contrib-uglify - Minify files with UglifyJS https://bugzilla.redhat.com/show_bug.cgi?id=977125
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
--- Comment #2 from T.C. Hollingsworth tchollingsworth@gmail.com --- Ready for review now.
Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-1.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #3 from T.C. Hollingsworth tchollingsworth@gmail.com --- I've now fixed an annoying bug in grunt and can drop the hack I added in %prep to make it build. This now requires the most recent nodejs-grunt to build.
Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-2.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1103414
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1103414 [Bug 1103414] Review Request: js-jquery-migrate - APIs and features removed from jQuery core
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #4 from T.C. Hollingsworth tchollingsworth@gmail.com --- Fixed based on feedback from the js-sizzle review:
Spec: http://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: http://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-3.fc20.src.rpm
* Tue Jun 03 2014 T.C. Hollingsworth tchollingsworth@gmail.com - 1.11.1-3 - follow the github SourceURL guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 Bug 1078371 depends on bug 1078364, which changed state.
Bug 1078364 Summary: Review Request: js-sizzle - A pure-JavaScript CSS selector engine https://bugzilla.redhat.com/show_bug.cgi?id=1078364
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #5 from Jens Petersen petersen@redhat.com --- Mock build fails like js-query:
+ ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.js /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.js + ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.js /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.min.js + ln /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.map /builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/jquery-1.min.map ln: failed to access '/builddir/build/BUILDROOT/js-jquery1-1.11.1-3.fc22.x86_64/usr/share/javascript/jquery/1.11.1/jquery.min.map': No such file or directory エラー: /var/tmp/rpm-tmp.G748eQ の不正な終了ステータス (%install) RPM ビルドのエラー: /var/tmp/rpm-tmp.G748eQ の不正な終了ステータス (%install) Child return code was: 1
Something (dep?) missing?
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #6 from T.C. Hollingsworth tchollingsworth@gmail.com --- I was missing the '-s' argument to 'ln' in a few places. But in further testing I discovered that source maps don't work with those particular symlinks, and they really seem to be overkill, so I just removed them instead.
--
Spec: https://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery1-1.11.1-4.fc20.src.rpm
* Tue Oct 21 2014 T.C. Hollingsworth tchollingsworth@gmail.com - 1.11.1-4 - drop unneccessary symlinks
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- Review:
+ mock build is successful for f22.
+ rpmlint output on rpms gave js-jquery1.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry js-jquery1.noarch: W: spelling-error %description -l en_US extensibility -> sensibility, extensible js-jquery1.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry js-jquery1.src: W: spelling-error %description -l en_US extensibility -> sensibility, extensible 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ Source verified with upstream as (sha256sum) srpm tarball :ba7e5a7fb659691ec2bb23c1a949c99d47633dff48dab774702ae1d9cfddda8b upstream tarball :ba7e5a7fb659691ec2bb23c1a949c99d47633dff48dab774702ae1d9cfddda8b
+ License "MIT" is valid and is included in its own file as %doc
+ rest looks following packaging guidelines.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from T.C. Hollingsworth tchollingsworth@gmail.com --- New Package SCM Request ======================= Package Name: js-jquery1 Short Description: JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers Upstream URL: https://jquery.com/ Owners: patches jamielinux Branches: f21 f20 f19 epel7 el6 el5 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- not built on koji yet??
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #11 from Jens Petersen petersen@redhat.com --- ping? :)
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tchollingsworth@gmail.com Flags| |needinfo?(tchollingsworth@g | |mail.com)
--- Comment #12 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Ping2?
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) |
--- Comment #13 from T.C. Hollingsworth tchollingsworth@gmail.com --- Sorry for the delay, I was really waiting for the trio of packages to push everything out to all Fedora releases, but I really should have built this for rawhide immediately sorry.
I would build it right now, but dist-git is down. :-(
In the meantime, here's the latest upstream release:
--
Spec: https://patches.fedorapeople.org/jquery/js-jquery1.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery1-1.11.2-1.fc20.src.rpm
* Thu Feb 19 2015 T.C. Hollingsworth tchollingsworth@gmail.com - 1.11.2-1 - new upstream release 1.11.2
http://blog.jquery.com/2014/12/18/jquery-1-11-2-and-2-1-3-released-safari-fa...
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-02-19 09:08:20
--- Comment #14 from T.C. Hollingsworth tchollingsworth@gmail.com --- Built for rawhide and branched: http://koji.fedoraproject.org/koji/packageinfo?packageID=19341
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #15 from Jens Petersen petersen@redhat.com --- Congrats
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc20,js-jquery1-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc21,js-jquery1-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el6,js-jquery1-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el7,js-jquery1-1.1...
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |js-jquery-2.1.3-1.el6 Resolution|RAWHIDE |ERRATA
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.el6, js-jquery1-1.11.2-2.el6, js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|js-jquery-2.1.3-1.el6 |js-jquery-2.1.3-1.el7
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.el7, js-sizzle-2.1.1-1.jquery.2.1.2.el7, js-jquery1-1.11.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|js-jquery-2.1.3-1.el7 |js-jquery-2.1.3-1.fc21
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.fc21, js-sizzle-2.1.1-1.jquery.2.1.2.fc21, js-jquery1-1.11.2-2.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1078371
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|js-jquery-2.1.3-1.fc21 |js-jquery-2.1.3-1.fc20
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- js-jquery-2.1.3-1.fc20, js-jquery1-1.11.2-2.fc20, js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org