[Bug 2317961] New: Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Bug ID: 2317961
           Summary: Review Request: huion-switcher - Utility to switch
                    Huion tablets into tablet mode
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://people.freedesktop.org/~whot/rpms/huion-switcher.spec
SRPM URL:
https://people.freedesktop.org/~whot/rpms/huion-switcher-0.5.0-1.fc42.src.rp...
Description: Utility to switch Huion tablets into tablet mode
Fedora Account System Username: whot

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

--- Comment #1 from Parag AN(पराग)  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions:
1) The license written for this package is "GPL-2.0-only AND MIT AND MIT OR
Apache-2.0"
but I think it should be written as "GPL-2.0-only AND MIT AND (MIT OR
Apache-2.0)"

2) SPEC file in SRPM and SPEC file given in link itself does not match. Check
more at the bottom of this review comment.

3) Resubmit this package SRPM and SPEC links for final approval of this package

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2". 8 files have unknown license. Detailed output of licensecheck in
     /home/test/2317961-huion-switcher/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 1749 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.

Rpmlint
-------
Checking: huion-switcher-0.5.0-1.fc42.x86_64.rpm
          huion-switcher-0.5.0-1.fc42.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpdmt_9v16')]
checks: 32, packages: 2

2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0
badness; has taken 0.5 s

Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:

Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:

Source checksums
----------------
https://github.com/whot/huion-switcher/archive/refs/tags/0.5.0.tar.gz :
  CHECKSUM(SHA256) this package     :
a595efecc78ee227bb1ac8ebf48bccea5c2b57a2553e88de3428dbbc3d438c04
  CHECKSUM(SHA256) upstream package :
a595efecc78ee227bb1ac8ebf48bccea5c2b57a2553e88de3428dbbc3d438c04

Requires
--------
huion-switcher (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libusb-1.0.so.0()(64bit)
    rtld(GNU_HASH)
    udev

Provides
--------
huion-switcher:
    huion-switcher
    huion-switcher(x86-64)

Diff spec file in url and in SRPM
---------------------------------
--- /home/test/2317961-huion-switcher/srpm/huion-switcher.spec  2024-11-04
11:33:37.965730159 +0530
+++ /home/test/2317961-huion-switcher/srpm-unpacked/huion-switcher.spec
2024-10-11 05:30:00.000000000 +0530
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.7.2)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %bcond_without check
 %global udevdir %(pkg-config --variable=udevdir udev)
@@ -59,3 +69,6 @@

%changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Fri Oct 11 2024 John Doe  - 0.5.0-1
+- Uncommitted changes
+## END: Generated by rpmautospec

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2317961 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Haskell, SugarActivity, fonts, Python, Java, C/C++, R, Ocaml,
Perl, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #2 from Peter Hutterer  ---
Thanks heaps for the review. I've fixed:

- License is now "GPL-2.0-only AND MIT AND (MIT OR Apache-2.0)"
- superfluous %changelog removed though fedora-review still complains about the
diff. this appears to be a result of autorelease/autochangelog being replaced
and the diff not being aware of it

Either way, both re-uploaded to the same URLS:

Spec URL: https://people.freedesktop.org/~whot/rpms/huion-switcher.spec
SRPM URL:
https://people.freedesktop.org/~whot/rpms/huion-switcher-0.5.0-1.fc42.src.rp...

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/whot/hui
                   |                            |on-switcher
           Keywords|                            |AutomationTriaged

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8225077
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Parag Nemade  ---
Looks good now :)

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Peter Hutterer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]          |[e-mail]

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #5 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/huion-switcher

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #6 from Peter Hutterer  ---
Thanks again for the review, much appreciated!

fwiw, I've reassigned this to your RH account, otherwise I can't get past the
SCM request - assignee and reviewer differ.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #7 from Fedora Update System  ---
FEDORA-2024-4b2b58689f (huion-switcher-0.5.0-1.fc42) has been submitted as an
update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4b2b58689f

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Peter Hutterer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
   Fixed In Version|                            |huion-switcher-0.5.0-1.fc42
        Last Closed|                            |2024-11-07 21:46:00

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|RAWHIDE                     |ERRATA

--- Comment #8 from Fedora Update System  ---
FEDORA-2024-4b2b58689f (huion-switcher-0.5.0-1.fc42) has been pushed to the
Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #9 from Fedora Update System  ---
FEDORA-2024-5b7b41247a (huion-switcher-0.5.0-1.fc41) has been submitted as an
update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5b7b41247a

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #10 from Fedora Update System  ---
FEDORA-2024-089c61bbd9 (huion-switcher-0.5.0-1.fc40) has been submitted as an
update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-089c61bbd9

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #11 from Fedora Update System  ---
FEDORA-2024-089c61bbd9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-089c61bbd9 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-089c61bbd9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #12 from Fedora Update System  ---
FEDORA-2024-5b7b41247a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-5b7b41247a *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5b7b41247a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #13 from Fedora Update System  ---
FEDORA-2024-089c61bbd9 (huion-switcher-0.5.0-1.fc40) has been pushed to the
Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2317961] Review Request: huion-switcher - Utility to switch Huion tablets into tablet mode

https://bugzilla.redhat.com/show_bug.cgi?id=2317961

--- Comment #14 from Fedora Update System  ---
FEDORA-2024-5b7b41247a (huion-switcher-0.5.0-1.fc41) has been pushed to the
Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.