https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Bug ID: 1011041 Summary: Review Request: python3-py3dns - Python3 DNS library Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: rbean@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://ralph.fedorapeople.org//python3-py3dns.spec SRPM URL: http://ralph.fedorapeople.org//python3-py3dns-3.0.4-1.fc19.src.rpm
Description: Python3 DNS library
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
--- Comment #1 from Ralph Bean rbean@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5971634
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1010829
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@gmail.com Assignee|nobody@fedoraproject.org |cickumqt@gmail.com Flags| |fedora-review?
--- Comment #2 from Christopher Meng cickumqt@gmail.com --- 1. It would be better to use "https://launchpad.net/py3dns/" as URL tag.
2. Missing BuildRequires: python3-setuptools
3. %description needs work, after looking into lp homepage, you should change:
This Python 3 module provides an DNS API for looking up DNS entries from within Python 3 modules and applications. This module is a simple, lightweight implementation.
4. fedora-review passed.
PACKAGE APPROVED.
CHANGE 1-3 MENTIONED ABOVE BEFORE IMPORT.
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
--- Comment #3 from Ralph Bean rbean@redhat.com --- Thanks Christopher.
I will fix #1 and #3.
#2 I think is not actually correct -- py3dns is one of the few python packages that doesn't actually require setuptools.
Can you also set the fedora-review flag to "+"?
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
--- Comment #4 from Christopher Meng cickumqt@gmail.com --- (In reply to Ralph Bean from comment #3)
Thanks Christopher.
I will fix #1 and #3.
#2 I think is not actually correct -- py3dns is one of the few python packages that doesn't actually require setuptools.
Can you also set the fedora-review flag to "+"?
Why it doesn't need it...?
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #5 from Ralph Bean rbean@redhat.com --- Ah, look in the setup.py file of the project. Most python packages use "from setuptools import setup" to declare their package. setuptools is third party and so must be included as a separate package.
py3dns uses "from distutils.core import setup". distutils is in the python standard library and so requires no external package.
https://bugzilla.redhat.com/show_bug.cgi?id=1011041
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-11-09 02:57:19
--- Comment #9 from Christopher Meng cickumqt@gmail.com --- Hmm...not sure why I didn't understand in comment 4, I will keep clearheaded from now on...
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla