[Bug 2258880] New: Review Request: rust-argon2 - Pure Rust implementation of the Argon2 password hashing function with support for the Argon2d, Argon2i, and Argon2id algorithmic variants
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Bug ID: 2258880 Summary: Review Request: rust-argon2 - Pure Rust implementation of the Argon2 password hashing function with support for the Argon2d, Argon2i, and Argon2id algorithmic variants Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust-argon2.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-argon2-0.5.2-1.fc38.src.rpm
Description: Pure Rust implementation of the Argon2 password hashing function with support for the Argon2d, Argon2i, and Argon2id algorithmic variants.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ar | |gon2 Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6913614 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Two issues:
1. The summary is *way too long*, please trim it in the package and in this bug's title.
2. Using ExcludeArch is a very big hammer and should almost *never* be done for library-only crates, since it will prevent dependent packages from building on this architecture as well. In this case, please report an issue with the upstream project. The RustCrypto people are very pleasant to work with, in my experience. It might just be that the test fixtures assume little-endian byte order, or it might be that the code is actually broken on big-endian architectures. Either would be good to know.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #3 from Michel Lind michel@michel-slm.name --- Makes sense, thanks. I'll just disable tests on s390x for now and file the issue upstream
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #4 from Michel Lind michel@michel-slm.name --- Filed https://github.com/RustCrypto/password-hashes/issues/481 and updated the spec and SRPM
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2009347 --> https://bugzilla.redhat.com/attachment.cgi?id=2009347&action=edit The .spec file difference from Copr build 6913614 to 6923231
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6923231 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Upstream has fixed the big-endian support and released a new version - can you update this package? https://github.com/RustCrypto/password-hashes/blob/master/argon2/CHANGELOG.m...
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2283849
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283849 [Bug 2283849] Review Request: rust-rusty_paserk - Platform Agnostic Serializable Keys
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ | |needinfo?(michel@michel-slm | |.name) Status|ASSIGNED |POST Assignee|decathorpe@gmail.com |zebob.m@gmail.com CC| |zebob.m@gmail.com
--- Comment #8 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Assuming you bump the package to the latest version and restore the normal checks:
Rust Package Review
This package was generated using rust2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[!] The latest version is packaged or packaging an earlier version is justified. [x] The License tag reflects the package contents and uses the correct identifiers. [x] The package builds successfully in mock. [x] Package is installable (checked by fedora-review). [x] There are no relevant rpmlint errors. [x] The package runs tests in %check. [x] The package's binaries don't conflict with binaries already in the distribution. [x] There are no %{_bindir}/* wildcards in %files. [x] The package complies with the Rust and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
[ ] Add the package to release-monitoring.org [ ] Add the package to Koschei [ ] Give rust-sig privileges (at least commit) on the package [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? Assignee|zebob.m@gmail.com |decathorpe@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(michel@michel-slm | |.name) | Status|POST |ASSIGNED
--- Comment #9 from Michel Lind michel@michel-slm.name --- This probably should not be marked as POST huh
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #10 from Michel Lind michel@michel-slm.name --- Spec URL: https://salimma.fedorapeople.org/specs/rust-argon2.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-argon2-0.5.3-1.fc40.src.rpm
summary shortened, tests reenabled on all platforms
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2038340 --> https://bugzilla.redhat.com/attachment.cgi?id=2038340&action=edit The .spec file difference from Copr build 6923231 to 7673137
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7673137 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #13 from Michel Lind michel@michel-slm.name --- This was generated straight with rust2rpm, with this rust2rpm.toml
[package] # original summary too long summary = "Pure Rust implementation of the Argon2 password hashing function"
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #14 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #15 from Michel Lind michel@michel-slm.name --- Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-argon2
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-36a4a9743b (rust-argon2-0.5.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-36a4a9743b
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-03 19:41:28
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-36a4a9743b (rust-argon2-0.5.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-f879eb60f9 (rust-argon2-0.5.3-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f879eb60f9
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-f879eb60f9 (rust-argon2-0.5.3-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f879eb60f9
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-08a90622e0 (rust-argon2-0.5.3-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-08a90622e0
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-0b38e08abe has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0b38e08abe *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0b38e08abe
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-08a90622e0 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-08a90622e0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-08a90622e0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-f879eb60f9 has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f879eb60f9
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-0b38e08abe (rust-argon2-0.5.3-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-08a90622e0 (rust-argon2-0.5.3-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2258880
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-f879eb60f9 (rust-argon2-0.5.3-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com