[Bug 967333] New: Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Bug ID: 967333
           Summary: Review Request: rubygem-code_analyzer - Helps build
                    custom code analyzer tools
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL:
http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_ana...
SRPM URL:
http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_ana...
Description: Helps build custom code analyzer tools
Fedora Account System Username: anujmore

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

--- Comment #1 from Anuj More  ---
Builds on mock:
https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-code_analyzer...
rpmlint does not complain: 
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #2 from Josef Stribny  ---
I will take it for a review.

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

--- Comment #3 from Josef Stribny  ---
* mark LICENSE as %doc

* move README.md to the -doc sub-package
  - it's not needed at runtime

* move Gemfile and Rakefile to -doc sub-package rather than excluding them

* fix Summary
  "Helps build custom code analyzer tools" sounds a bit better to me. But
please put the summary as a short description here in Bugzilla next time so
it's the same as in spec.

* fix Description (missing "which IS")
  - e.g.: The code analyzer tool which is extracted from rails_best_practices
helps you easily build your own tool for code analysis.

Otherwise, it builds and runs just fine. Please fix the spec file so I can
approve.

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

--- Comment #4 from Anuj More  ---
Updated:

Spec URL:
http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_ana...
SRPM URL:
http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_ana...

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #5 from Josef Stribny  ---
Looks good now. 2 minor things that would be nice to do:

* Description of -doc sub-package should end with a dot "." as a normal English
sentence, please add it.

* Be more specific when listing files
  %doc %{gem_instdir}/*.gemspec > %doc %{gem_instdir}/%{gem_name}.gemspec

Since those are not blockers I APPROVE this package. Please fix above mentioned
issues before pushing.

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(anujmorex@gmail.c
                   |                            |om)

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

John Skeoch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]         |[e-mail]

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |201449 (FE-DEADREVIEW)
           Assignee|[e-mail]           |[e-mail]

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.

[Bug 967333] Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967333

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NOTABUG
              Flags|fedora-review+              |
                   |needinfo?(anujmorex@gmail.c |
                   |om)                         |
        Last Closed|                            |2016-01-04 03:55:48

--- Comment #7 from Vít Ondruch  ---
Closing this stalled review.