[Bug 2051212] New: Review Request: rust-wasmtime - High-level API to expose the Wasmtime runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Bug ID: 2051212 Summary: Review Request: rust-wasmtime - High-level API to expose the Wasmtime runtime Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-wasmtime.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-wasmtime-0.33.0-1.fc35.src.rpm
Description: High-level API to expose the Wasmtime runtime.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2051191, 2051157, 2051022 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2051022 [Bug 2051022] Review Request: rust-wasmtime-runtime - Runtime library support for Wasmtime https://bugzilla.redhat.com/show_bug.cgi?id=2051157 [Bug 2051157] Review Request: rust-wasmtime-jit - JIT-style execution for WebAsssembly code in Cranelift https://bugzilla.redhat.com/show_bug.cgi?id=2051191 [Bug 2051191] Review Request: rust-wasmtime-cranelift - Integration between Cranelift and Wasmtime
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2051222
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2051222 [Bug 2051222] Review Request: rust-wiggle - Runtime components of wiggle code generator
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2051227
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2051227 [Bug 2051227] Review Request: rust-wasmtime-wast - Wast testing support for wasmtime
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@gmail.com Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |alebastr89@gmail.com
--- Comment #2 from Aleksei Bavshin alebastr89@gmail.com --- - The `vtune` optional feature depends on `wasmtime-jit/vtune` which you've already removed and is broken. Please, update the metadata patch to remove it (it's fine to do that before import). % rg --glob Cargo.toml vtune
2051212-rust-wasmtime/rpms-unpacked/rust-wasmtime-devel-0.33.0-1.fc37.noarch.rpm/usr/share/cargo/registry/wasmtime-0.33.0/Cargo.toml 126:vtune = ["wasmtime-jit/vtune"] - Deprecation warning is already fixed in v0.34.0.
LGTM
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! I have a .rust2rpm.conf file for dropping the uffd and vtune features, but that's not shipped with the SRPM. I'll make sure to import that file.
https://pagure.io/releng/fedora-scm-requests/issue/42897 https://pagure.io/releng/fedora-scm-requests/issue/42898 https://pagure.io/releng/fedora-scm-requests/issue/42899 https://pagure.io/releng/fedora-scm-requests/issue/42900
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmtime
https://bugzilla.redhat.com/show_bug.cgi?id=2051212 Bug 2051212 depends on bug 2051022, which changed state.
Bug 2051022 Summary: Review Request: rust-wasmtime-runtime - Runtime library support for Wasmtime https://bugzilla.redhat.com/show_bug.cgi?id=2051022
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2051212 Bug 2051212 depends on bug 2051191, which changed state.
Bug 2051191 Summary: Review Request: rust-wasmtime-cranelift - Integration between Cranelift and Wasmtime https://bugzilla.redhat.com/show_bug.cgi?id=2051191
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2051212 Bug 2051212 depends on bug 2051157, which changed state.
Bug 2051157 Summary: Review Request: rust-wasmtime-jit - JIT-style execution for WebAsssembly code in Cranelift https://bugzilla.redhat.com/show_bug.cgi?id=2051157
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2022-03-10 22:32:56
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1932198
Will be submitted to bodhi and built for stable branches shortly.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com