[Bug 2165224] New: Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

Bug ID: 2165224
           Summary: Review Request: rust-fallible_collections - Crate
                    which adds fallible allocation api to std collections
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/blinxen/rust-fallible_col...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/blinxen/rust-fallible_col...

Description:

Implement Fallible collections on allocation errors, quite as describe in RFC
2116.
This was used in the turbofish OS hobby project to mitigate
the lack of faillible allocation in rust.

Fedora Account System Username: blinxen

The purpose of this package review is to unretire the fallible_collections
crate. See https://pagure.io/releng/issue/11245.

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5344965
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |POST
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Fabio Valentini  ---
Oh, another library that was rewritten from C in Rust. :D

Reading the upstream README, I recommend that use use cargo-c to build the
shared library.
In my experience, it is the least painful option for building C-style shared
libraries, especially because it handles setting SONAME and generating headers
and pkg-config files.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Once releng has processed the unretirement, please also request an f37 branch
for this package. It makes it much easier for Rust SIG members to update things
if there's not "holes" (i.e. this package would be present in rawhide and f36,
but not f37, which would be weird). I also recommend to re-enable tracking for
the package in koschei for the rawhide and f37 branches once they have been
created.

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

--- Comment #3 from Fabio Valentini  ---
I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder
library).
It might be helpful to look at its spec file to see how to use cargo-c for
Fedora RPM builds:
https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec...

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

--- Comment #4 from [e-mail] ---
> I forgot to add: We already use cargo-c for building rav1e (an AV1 encoder library).
> It might be helpful to look at its spec file to see how to use cargo-c for Fedora RPM builds:
> https://src.fedoraproject.org/rpms/rust-rav1e/blob/rawhide/f/rust-rav1e.spec...

Thanks for the tip!! Much appreciated since I am still new to the packaging
scene :D.

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

--- Comment #5 from Fabio Valentini  ---
It appears that build of this crate failed in koji - do you need help with
debugging the failure?

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

--- Comment #6 from [e-mail] ---
Help would be very much appreciated! I was trying to debug it myself, but I
think I don't understand the underlying problem.
I have created the following issue in the upstream repository:
https://github.com/vcombey/fallible_collections/issues/35
I documented my findings findings there. The only build that is failing, is the
i686 build.

[Bug 2165224] Review Request: rust-fallible_collections - Crate which adds fallible allocation api to std collections

https://bugzilla.redhat.com/show_bug.cgi?id=2165224

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2023-02-12 20:55:07

--- Comment #7 from [e-mail] ---
The package now builds successfully for all targeted branches. Closing this
review.