[Bug 526311] New: Review Request: mysql-mmm - Multi-Master Replication Manager for MySQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mysql-mmm - Multi-Master Replication Manager for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Summary: Review Request: mysql-mmm - Multi-Master Replication Manager for MySQL Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: wdierkes@rackspace.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://5dollarwhitebox.org/tmp/mysql-mmm.spec SRPM URL: http://5dollarwhitebox.org/tmp/mysql-mmm-1.2.6-3.3.src.rpm
Description:
This is my first package, and I need a sponsor.
---
MMM (MySQL Multi-Master Replication Manager) is a set of flexible scripts to perform monitoring/failover and management of MySQL Master-Master replication configurations (with only one node writable at any time). The toolset also has the ability to read balance standard master/slave configurations with any number of slaves, so you can use it to move virtual IP addresses around a group of servers depending on whether they are behind in replication.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
BJ Dierkes wdierkes@rackspace.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #1 from BJ Dierkes wdierkes@rackspace.com 2009-10-02 11:55:59 EDT --- Please note, I am more interested in maintaining this package for Fedora EPEL. As it is more of a production/server application its more suitable for RHEL+EPEL... that said I have no qualms with maintaining for both EPEL and Fedora Core.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Ruben Kerkhof ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ruben@rubenkerkhof.com AssignedTo|nobody@fedoraproject.org |ruben@rubenkerkhof.com
--- Comment #2 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-10-11 06:58:26 EDT --- Hi BJ,
I'll review your package, and I'm willing to sponsor you.
I haven't used mmm before, so I'm trying your packages now. As soon as I got a setup working I'll do a formal review.
Please start with running rpmlint over the packages, there are a lot of errors and warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br
--- Comment #3 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-10-11 07:17:01 EDT --- (In reply to comment #1)
BJ Dierkes
Do you have a fedora account [1] ?
[1] - https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account
after you got a fedora account, can you join fedora packager group in FAS and try to build it using koji ?
Requires: initscripts -- all machines have it, no need to Requires.
Requires: perl-DBD-MySQL -> replace this with mysql-server
/sbin/chkconfig mmm_agent on -> fedora packaging rules doesn't allow services enabled by default.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #4 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-10-12 06:22:52 EDT --- Itamar,
Requires: perl-DBD-MySQL -> replace this with mysql-server
Why? The monitor doesn't need mysql-server installed.
A better idea is to remove the Requires altogether, and let rpm figure it out.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #5 from BJ Dierkes wdierkes@rackspace.com 2009-10-12 08:20:32 EDT --- (In reply to comment #3)
Do you have a fedora account [1] ?
I do (derks).
after you got a fedora account, can you join fedora packager group in FAS and try to build it using koji ?
I have applied to the packager group in FAS and will attempt to build this with koji once that is approved. I'm already all setup on my mock development machine at work with ssl certs and everything to talk to Koji, and have verified that to work (just haven't submitted anything yet).
Requires: initscripts -- all machines have it, no need to Requires. Requires: perl-DBD-MySQL -> replace this with mysql-server
/sbin/chkconfig mmm_agent on -> fedora packaging rules doesn't allow services enabled by default.
I will make these changes promptly once I'm back in the office.
Thank you for taking the time to work with me on this. I will admit, the sources kind of limited me to how it is being installed... meaning, the development practice doesn't follow the FHS and expects everything installed to /usr/share/mmm or similar. I couldn't see any feasible way around that without patching every source file.
Requires: perl-DBD-MySQL -> replace this with mysql-server
Why? The monitor doesn't need mysql-server installed.
Not sure where this requirement originated from (it may have been before I took over packaging it). I agree though, mysql-server wouldn't be a good replacement as the monitor generally runs on a stand-alone box that is not one of the database servers. I'll look into it further.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Ruben Kerkhof ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag| |fedora-review?
--- Comment #6 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-10-12 10:55:56 EDT --- I've just approved your sponsorship requests, and removed the FE-NEEDSPONSOR blocker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #7 from BJ Dierkes wdierkes@rackspace.com 2009-10-20 00:26:24 EDT --- Per discussion with Ruben, I have scratched 1.2 and start almost complete fresh with the mysql-mmm-2.0 branch.
http://5dollarwhitebox.org/tmp/mysql-mmm-2.0.9-1.src.rpm http://5dollarwhitebox.org/tmp/mysql-mmm.spec
Installation is much cleaner with 2.x and follows FHS. I haven't had a chance to fully test it but plan on it in the coming days. Please review if you like, I will be working to get the build in koji shortly. Additionally, looks as though I will need to maintain perl-Net-ARP as well which is fine with me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
BJ Dierkes wdierkes@rackspace.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from BJ Dierkes wdierkes@rackspace.com 2009-10-20 13:51:05 EDT --- New Package CVS Request ======================= Package Name: mysql-mmm Short Description: Multi-Master Replication Manager for MySQL Owners: derks Branches: F-11 F-12 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #9 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-10-20 13:53:39 EDT --- (In reply to comment #8)
not yet ready for cvs, wait for review flag + from ruben
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
BJ Dierkes wdierkes@rackspace.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |531912
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #10 from BJ Dierkes wdierkes@rackspace.com 2009-11-03 19:06:06 EDT --- This has been updated due to source change upstream, as well as a number of added patches/changes to clean up a few things:
http://5dollarwhitebox.org/tmp/mysql-mmm.spec http://5dollarwhitebox.org/tmp/mysql-mmm-2.0.10-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #11 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-11-07 13:36:38 EDT --- Since this are all architecture-independent perl libraries, you have to add BuildArch: noarch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #12 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-11-10 16:22:39 EDT --- I've almost got a master-master configuration running under mysql-mmm. I bumped into a few small things, mainly because I've never used mmm before and the documentation is pretty sparse.
- the monitor subpackage is missing a dependency on dbd::mysql - starting the agent with the default configuration caused it to die with an error, but it was restarted over and over again. I just got 2GB of emails from the agent :-) We might want to create more sensible defaults for logging in Fedora... - The upstream init scripts are ok, but a bit verbose. It would be nice if you created a Fedora specific init script, using the functions from /etc/init.d/functions.
I'll do a proper review when I get mysql-mmm running.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #13 from BJ Dierkes wdierkes@rackspace.com 2009-11-10 18:00:49 EDT --- (In reply to comment #11)
Since this are all architecture-independent perl libraries, you have to add BuildArch: noarch.
Not sure how I missed that, but it has been added.
(In reply to comment #12)
- the monitor subpackage is missing a dependency on dbd::mysql
Was removed based on comment #4 ;). Added back in.
- starting the agent with the default configuration caused it to die with an
error, but it was restarted over and over again. I just got 2GB of emails from the agent :-) We might want to create more sensible defaults for logging in Fedora...
I ran into the same issue. I believe setting the IP for db1 in mmm_common.conf to 127.0.0.1 by default will atleast keep the process from dying and causing havoc with logs/email. I did added comments to the config to encourage the IP be set right, but I know I always try starting the process before anything else. Regardless, I've reported the following upstream when I first came across it:
https://bugs.launchpad.net/mysql-mmm/+bug/473446
- The upstream init scripts are ok, but a bit verbose. It would be nice if you
created a Fedora specific init script, using the functions from /etc/init.d/functions.
I will look into rewriting/cleaning up the init scripts.
Thanks Ruben.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #14 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-11-11 10:47:34 EDT ---
- the monitor subpackage is missing a dependency on dbd::mysql
Was removed based on comment #4 ;). Added back in.
rpm uses /usr/lib/rpm/perldeps.pl to find perl packages. That script parses perl code for 'use' statements. It missed dbd::mysql in this case.
I ran into the same issue. I believe setting the IP for db1 in mmm_common.conf to 127.0.0.1 by default will atleast keep the process from dying and causing havoc with logs/email. I did added comments to the config to encourage the IP be set right, but I know I always try starting the process before anything else. Regardless, I've reported the following upstream when I first came across it:
I've added a log4perl config file to my setup:
[ruben@db2 ~]$ sudo cat /etc/mysql-mmm/mmm_agent_log.conf log4perl.logger = INFO, FileInfo
log4perl.appender.FileInfo = Log::Log4perl::Appender::File log4perl.appender.FileInfo.Threshold = INFO log4perl.appender.FileInfo.filename = /var/log/mysql-mmm/mmmd_agent.log log4perl.appender.FileInfo.recreate = 1 log4perl.appender.FileInfo.layout = PatternLayout log4perl.appender.FileInfo.layout.ConversionPattern = %d %5p %m%n
This takes care of the mail problem. Something like this might be a nice default for Fedora, but we'll have to rotate that log too.
Regards,
Ruben
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #15 from BJ Dierkes wdierkes@rackspace.com 2009-11-17 14:44:08 EDT --- I have added a patch to lib/Common/Lib.pm to essentially do the same thing your mmm_agent_log.conf does, but makes it the global default for all services (not just agent). I've also reworked the patch I submitted upstream for the infinit loop on error condition.
http://5dollarwhitebox.org/tmp/mysql-mmm-2.0.10-2.src.rpm http://5dollarwhitebox.org/tmp/mysql-mmm.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Bug 526311 depends on bug 531912, which changed state.
Bug 531912 Summary: Review Request: perl-Net-ARP - Create and Send ARP Packets https://bugzilla.redhat.com/show_bug.cgi?id=531912
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #16 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-11-19 05:35:04 EDT --- Great, nice work!
Ok, another couple comments: * package is still x86_64, should be noarch * mysql-mmm-monitor still needs the DBD::MySQL Requires * I don't mind the Provides, but use %{version}-%{release} * The files section contains 2 entries for /var/run/mysql-mmm * Replace /var/log/mysql-mmm with %{_localstatedir}/log/mysql-mmm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #17 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-11-19 06:02:45 EDT --- Oh, and 2 more ;-)
%post agent /sbin/chkconfig --add mysql-mmm-agent /sbin/chkconfig mysql-mmm-agent off if [ $1 -eq 2 ] ; then /sbin/service mysql-mmm-agent status >/dev/null if [ $? = 0 ]; then /sbin/service mysql-mmm-agent restart fi fi
This sets the mysql-mmm-agent service to off at an update of the package.
%preun agent if [ $1 = 0 ]; then
Use -eq here
%preun monitor if [ $1 = 0 ]; then
Same here
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #18 from BJ Dierkes wdierkes@rackspace.com 2009-11-19 14:57:47 EDT --- I apologize for a few of these. I had a hard drive crash and lost the current stuff I was working with, and forgot to re-implement some of the changes. These should all be handled. Note that perl-DBD-MySQL actually provides perl(DBD::mysql) which was added for the monitor subpackage.
I also re-wrote the init scripts for agent/monitor so they are a lot cleaner and use init.d/functions, as well as implement a condrestart that is now used in %post.
http://5dollarwhitebox.org/tmp/mysql-mmm.spec http://5dollarwhitebox.org/tmp/mysql-mmm-2.0.10-3.src.rpm
%changelog * Thu Nov 19 2009 BJ Dierkes wdierkes@rackspace.com - 2.0.10-3 - BuildArch: noarch - Monitor subpackage Requires: perl(DBD::mysql) - Provides full version-release for mmm, mysql-master-master - Removed redundant /var/run/mysql-mmm entry - Use _localstatedir macro for /var/log/mysql-mmm file listing - Fixed logic in post and postun scripts to properly handle install/upgrade conditions. - Post scripts now perform condrestart - Added Source3: mysql-mmm-agent.init - Added Source4: mysql-mmm-monitor.init
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #19 from BJ Dierkes wdierkes@rackspace.com 2009-12-08 12:16:59 EDT --- Hello, Can I get an update on this review? Just want to make sure nothing is waiting on me. Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #20 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-12-10 05:19:13 EDT --- Sorry, I was AFK for a while.
Last comments: - Provides need a full version-release in the subpackages - rpmlint is not clean:
[ruben@slice SPECS]$ rpmlint ../RPMS/noarch/mysql-mmm-*3* mysql-mmm.noarch: I: enchant-dictionary-not-found en_US mysql-mmm.noarch: E: non-standard-dir-perm /var/log/mysql-mmm 0750 mysql-mmm.noarch: E: non-standard-dir-perm /var/lib/mysql-mmm 0750 mysql-mmm.noarch: E: non-readable /etc/mysql-mmm/mmm_common.conf 0640 mysql-mmm.noarch: E: zero-length /usr/share/doc/mysql-mmm-2.0.10/README mysql-mmm.noarch: E: non-standard-dir-perm /var/run/mysql-mmm 0750 mysql-mmm-agent.noarch: W: no-documentation mysql-mmm-agent.noarch: E: non-readable /etc/mysql-mmm/mmm_agent.conf 0640 mysql-mmm-agent.noarch: E: subsys-not-used /etc/init.d/mysql-mmm-agent mysql-mmm-monitor.noarch: W: no-documentation mysql-mmm-monitor.noarch: E: non-readable /etc/mysql-mmm/mmm_mon.conf 0640 mysql-mmm-monitor.noarch: E: subsys-not-used /etc/init.d/mysql-mmm-monitor mysql-mmm-tools.noarch: W: no-documentation
Most errors are harmless in my opinion, except for the directory permissions on /var/lib/mysql-mmm and /var/run/mysql-mmm, there's no harm in making them 0755.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #21 from BJ Dierkes wdierkes@rackspace.com 2009-12-10 13:38:01 EDT --- I've fixed the rpmlint errors except for the following:
$ !rpmli rpmlint -i RPMS/noarch/mysql-mmm-*4* mysql-mmm.noarch: E: non-readable /etc/mysql-mmm/mmm_common.conf 0640 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball).
mysql-mmm-agent.noarch: E: non-readable /etc/mysql-mmm/mmm_agent.conf 0640 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball).
mysql-mmm-monitor.noarch: E: non-readable /etc/mysql-mmm/mmm_mon.conf 0640 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball).
4 packages and 0 specfiles checked; 3 errors, 0 warnings.
Is it _really_ preferred that everyone can read all config files, or can I ignore these? Seems that would be a security issue if config files have sensitive information like passwords.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
--- Comment #22 from BJ Dierkes wdierkes@rackspace.com 2009-12-10 14:08:17 EDT --- Latest build fixing the above issues, with exception of changing the mode of the config files:
http://5dollarwhitebox.org/tmp/mysql-mmm.spec http://5dollarwhitebox.org/tmp/mysql-mmm-2.0.10-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Ruben Kerkhof ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #23 from Ruben Kerkhof ruben@rubenkerkhof.com 2009-12-11 07:59:09 EDT --- I think it's safe to ignore the last 3 rpmlint errors since the files contain database passwords.
I've looked at mysql-mmm-2.0.10-4 and see no further issues.
This package is approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
BJ Dierkes wdierkes@rackspace.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #24 from BJ Dierkes wdierkes@rackspace.com 2009-12-11 12:33:29 EDT --- New Package CVS Request ======================= Package Name: mysql-mmm Short Description: Multi-Master Replication Manager for MySQL Owners: derks Branches: F-11 F-12 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #25 from Kevin Fenzi kevin@tummy.com 2009-12-14 12:48:44 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526311
Ruben Kerkhof ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla