https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Bug ID: 1295260 Summary: Review Request: php-mnapoli-phpunit-easymock - Helpers to build PHPUnit mocks Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn@iwin.ski QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/d5ec0ad336c6951a258a108bdd4c...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-mnapoli-phpunit-easymock-0.2.0-1...
Description: Helpers to build PHPUnit mocks.
Autoloader: /usr/share/php/EasyMock/autoload.php
Fedora Account System Username: siwinski
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-mnapoli-phpunit-easymoc | |k
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1295258 (php-di)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1295258 [Bug 1295258] Review Request: php-di - The dependency injection container for humans
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- remi's scratch build of php-mnapoli-phpunit-easymock-0.2.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12399967
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Dependencies: php-composer(phpunit/phpunit-mock-objects) >= 2.0 php-composer(phpunit/phpunit-mock-objects) < 3.0
This will be a major issue soon (as I plan to update PHPUnit to 5.1.x soon)
So: https://github.com/mnapoli/phpunit-easymock/issues/3
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@famillecollet.com Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #3 from Remi Collet fedora@famillecollet.com --- Created attachment 1111392 --> https://bugzilla.redhat.com/attachment.cgi?id=1111392&action=edit phpci.log
phpCompatInfo version 5.0.0 DB built Dec 29 2015 09:34:25 CET static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Created attachment 1111393 --> https://bugzilla.redhat.com/attachment.cgi?id=1111393&action=edit review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1295260
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #5 from Remi Collet fedora@famillecollet.com --- [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php(php-common)
Trivial fix:
-%dir %{phpdir}/ - %{phpdir}/ +%{phpdir}/EasyMock
Would be nice if you can test (using php-di build) against PHPUnit 5 and thus drop max version.
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #6 from Shawn Iwinski shawn@iwin.ski --- THANKS Remi!
Changes: - Updated to 0.2.1 - Fixed directory ownsership in %files
Diff: https://github.com/siwinski/rpms/commit/461a682cb068f02ef207349cab9bb007ded4...
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/461a682cb068f02ef207349cab9b...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-mnapoli-phpunit-easymock-0.2.1-1...
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Remi Collet fedora@famillecollet.com --- +- Fixed directory ownsership in %%files
Typo ! ;)
[x]: Package does not own files or directories owned by other packages.
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #8 from Shawn Iwinski shawn@iwin.ski --- (In reply to Remi Collet from comment #7)
+- Fixed directory ownsership in %%files
Typo ! ;)
Darnit! LOL. I'll fix after initial import.
THANKS for the review, pointing out the typo, and the upstream "fix".
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-mnapoli-phpunit-easymock
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-01-04 23:28:27
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-di-symfony2-bridge-1.1.0-1.el7 php-di-5.2.0-1.el7 php-di-invoker-1.2.0-1.el7 php-mnapoli-phpunit-easymock-0.2.1-1.el7 php-di-phpdoc-reader-2.0.1-1.el7 php-container-interop-1.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2cc24c1200
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-di-symfony2-bridge-1.1.0-1.el7 php-di-5.2.0-1.el7 php-di-invoker-1.2.0-1.el7 php-mnapoli-phpunit-easymock-0.2.1-1.el7 php-di-phpdoc-reader-2.0.1-1.el7 php-container-interop-1.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2cc24c1200
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-di-symfony2-bridge-1.1.0-1.fc22 php-di-5.2.0-1.fc22 php-di-invoker-1.2.0-1.fc22 php-mnapoli-phpunit-easymock-0.2.1-1.fc22 php-di-phpdoc-reader-2.0.1-1.fc22 php-container-interop-1.1.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d61abd66d
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-di-symfony2-bridge-1.1.0-1.fc23 php-di-5.2.0-1.fc23 php-di-invoker-1.2.0-1.fc23 php-mnapoli-phpunit-easymock-0.2.1-1.fc23 php-di-phpdoc-reader-2.0.1-1.fc23 php-container-interop-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-24c3e6b59c
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-63cd5fa5f4
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7, php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7, php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2cc24c1200
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.fc22, php-di-5.2.0-1.fc22, php-di-invoker-1.2.0-1.fc22, php-di-phpdoc-reader-2.0.1-1.fc22, php-di-symfony2-bridge-1.1.0-1.fc22, php-mnapoli-phpunit-easymock-0.2.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d61abd66d
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.fc23, php-di-5.2.0-1.fc23, php-di-invoker-1.2.0-1.fc23, php-di-phpdoc-reader-2.0.1-1.fc23, php-di-symfony2-bridge-1.1.0-1.fc23, php-mnapoli-phpunit-easymock-0.2.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-24c3e6b59c
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.fc23, php-di-5.2.0-1.fc23, php-di-invoker-1.2.0-1.fc23, php-di-phpdoc-reader-2.0.1-1.fc23, php-di-symfony2-bridge-1.1.0-1.fc23, php-mnapoli-phpunit-easymock-0.2.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-01-04 23:28:27 |2016-01-20 16:56:23
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.fc22, php-di-5.2.0-1.fc22, php-di-invoker-1.2.0-1.fc22, php-di-phpdoc-reader-2.0.1-1.fc22, php-di-symfony2-bridge-1.1.0-1.fc22, php-mnapoli-phpunit-easymock-0.2.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-container-interop-1.1.0-1.el7, php-di-5.2.0-1.el7, php-di-invoker-1.2.0-1.el7, php-di-phpdoc-reader-2.0.1-1.el7, php-di-symfony2-bridge-1.1.0-1.el7, php-mnapoli-phpunit-easymock-0.2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1295260
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|php-mnapoli-phpunit-easymoc | |k |
package-review@lists.fedoraproject.org