Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-XML-FeedPP - Parse/write/merge/edit RSS/RDF/Atom syndication feeds
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Summary: Review Request: perl-XML-FeedPP - Parse/write/merge/edit RSS/RDF/Atom syndication feeds Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kanarip@kanarip.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://git.ergo-project.org/?p=kolab-fedora.git;a=blob_plain;f=el5/custom-el... SRPM URL: http://koji.ergo-project.org/packages/perl-XML-FeedPP/0.41/1.el5/src/perl-XM... Description: Parse/write/merge/edit RSS/RDF/Atom syndication feeds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |607873
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |607878
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Mark Chappell tremble@tremble.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tremble@tremble.org.uk AssignedTo|nobody@fedoraproject.org |tremble@tremble.org.uk Flag| |fedora-review?
--- Comment #1 from Mark Chappell tremble@tremble.org.uk 2010-06-25 10:40:39 EDT --- - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Versioned MODULE_COMPAT_ Requires [x] Non-Versioned CPAN URL tag [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: local mock (i386) [x] Rpmlint output:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable. [x] Buildroot is correct Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. Upstream: dd08f2bdb0850ae9470c5ae0a948d21d SRPM: dd08f2bdb0850ae9470c5ae0a948d21d [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: epel-5-i386 (local mock due to deps) [x] Package should compile and build into binary rpms on all supported architectures. Tested on: epel-5-i386 (local mock due to deps) [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=43, Tests=1367, 3 wallclock secs ( 2.09 cusr + 0.30 csys = 2.39 CPU)
=== COMMENTS ===
Package looks good, again provisionally APPROVED, will set flag once perl-XML-TreePP is approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Mark Chappell tremble@tremble.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Mark Chappell tremble@tremble.org.uk 2010-06-27 07:37:55 EDT --- Note: 0.42 appears to be available.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
--- Comment #3 from Jeroen van Meeuwen kanarip@kanarip.com 2010-06-27 07:59:47 EDT --- I cannot find 0.42 on cpan.org, where did you find 0.42?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
--- Comment #4 from Mark Chappell tremble@tremble.org.uk 2010-06-27 08:29:22 EDT --- Ah, sorry that was XML-Feed not XML-FeedPP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Jeroen van Meeuwen kanarip@kanarip.com 2010-06-28 05:23:23 EDT --- New Package CVS Request ======================= Package Name: perl-XML-FeedPP Short Description: Parse/write/merge/edit RSS/RDF/Atom syndication feeds Owners: kanarip Branches: EL-4 EL-5 EL-6 F-12 F-13 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2010-06-28 12:44:11 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607877
Mike B. michiel.beijen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michiel.beijen@gmail.com
Bug 607877 depends on bug 607878, which changed state.
Bug 607878 Summary: Review Request: perl-XML-TreePP - Pure Perl implementation for parsing/writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=607878
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ASSIGNED |CLOSED
package-review@lists.fedoraproject.org