[Bug 663092] New: Review Request: oxygen-gtk - Oxygen GTK theme - package-review

List overview All Threads
Download

newer

[Bug 663092] New: Review Request: oxygen-gtk - Oxygen GTK theme

older

[Bug 668001] New: Review Request:...

[Bug 661833] New: Review Request:...

Red Hat Bugzilla

14 Dec 2010 14 Dec '10

6:03 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: oxygen-gtk - Oxygen GTK theme

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Summary: Review Request: oxygen-gtk - Oxygen GTK theme Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://rdieter.fedorapeople.org/rpms/oxygen-gtk/oxygen-gtk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/oxygen-gtk/oxygen-gtk-1.0.0-1.fc13.src.... Description: Oxygen-Gtk is a port of the default KDE widget theme (Oxygen), to gtk.

It's primary goal is to ensure visual consistency between gtk-based and qt-based applications running under KDE. A secondary objective is to also have a stand-alone nice looking gtk theme that would behave well on other Desktop Environments.

Unlike other attempts made to port the KDE oxygen theme to gtk, this attempt does not depend on Qt (via some Qt to Gtk conversion engine), nor does render the widget appearance via hard-coded pixmaps, which otherwise breaks every time some setting is changed in KDE.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

14 Dec 14 Dec

6:03 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Rex Dieter rdieter@math.unl.edu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:19 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2010-12-14 12:19:18 EST --- Is this related to bug 642238?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:28 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2010-12-14 12:28:13 EST --- No, it is not.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Dec 15 Dec

4:40 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #3 from Mohamed El Morabity pikachu.2014@gmail.com 2010-12-15 10:40:12 EST --- cairo-devel as BR is useless, since it is already required by gtk2-devel.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Dec 22 Dec

7:49 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Dmitrij S. Kryzhevich krege@land.ru changed:

--- Comment #4 from Dmitrij S. Kryzhevich krege@land.ru 2010-12-22 01:49:36 EST --- And this is a review.

Good. =========== # rpmlint oxygen-gtk-1.0.0-1.fc14.src.rpm oxygen-gtk-1.0.0-1.fc14.x86_64.rpm oxygen-gtk.src: W: spelling-error %description -l en_US pixmaps -> pix maps, pix-maps, bitmaps oxygen-gtk.x86_64: W: spelling-error %description -l en_US pixmaps -> pix maps, pix-maps, bitmaps 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint output could be ignored. The package is named according to the Package Naming Guidelines. The spec file name must match the base package %{name}.

------- Spec name correct, but. Gtk engines are named as gtk-NAME-engine. Could we rename package into gtk-oxygen-engine? There are no guides for it, just common usage. -------

* The package meets the Packaging Guidelines. * The package is licensed with a Fedora approved license and meet the Licensing Guidelines. * The License field in the package spec file matchs the actual license. * File, containing the text of the license for the package, included in %doc. * The spec file is written in American English. * The spec file for the package is legible. * The sources used to build the package matchs the upstream source with md5sum 441398b4569ce0282c39e5c21cb16dfc. * The package built on F14 x86_64. * There are no locales. * There are no need in ldconfig. * There are no bundle copies of system libraries. * A package owns all directories that it creates. * All files are not listed more than once in the spec file's %files listings. * Permissions on files are set properly. * Package consistently use macros. * The package contains code. * There are no large documentation * Everything included as %doc does not affect the runtime of the application. * No need in -devel. * Package does not own files or directories already owned by other packages. * All filenames in rpm packages are valid UTF-8.

SHOULD: * The package built in mock. * The package works as described.

Not so good ======= 1) All required build dependencies are listed in BuildRequires, but cairo-devel is dependence for gtk2-devel and not needed to be call explicitly. 2) Runtime dependence. We can't be sure there are all needed icons installed with gtk2. Main icon theme is hicolor-icons-theme, if we have gtk2, we have it. But this theme containe not all icons. oxygen-icon-theme, ie, containe them. {gnome,nuvolla,...}-icon-theme - the same, but not hicolor-i-t. Somehow we need anything to make sure - we have sufficient icon set. Second is not a blocker.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3 Jan 3 Jan

4:57 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2011-01-03 10:57:35 EST --- re: naming I'd rather not rename, to avoid confusion with another similar project, see bug #642238

otherwise, you consider an extraneous BR a review blocker? OK, I'll remove cairo-devel

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:03 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2011-01-03 11:03:56 EST --- The icon thing *should* be ok as-is, my understanding is that oxygen-gtk simply checks for the existence of any icon-theme preference in kde's kdeglobals, and uses that, if present.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:10 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2011-01-03 11:10:09 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/oxygen-gtk/oxygen-gtk.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/oxygen-gtk/oxygen-gtk-1.0.0-2.fc14.src....

%changelog * Mon Jan 03 2011 Rex Dieter rdieter@fedoraproject.org - 1.0.0-2 - drop extraneous BR: cairo-devel

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Jan 4 Jan

10:12 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #8 from Jaroslav Reznik jreznik@redhat.com 2011-01-04 04:12:44 EST --- (In reply to comment #5)

...

re: naming I'd rather not rename, to avoid confusion with another similar project, see bug #642238

otherwise, you consider an extraneous BR a review blocker? OK, I'll remove cairo-devel

Wouldn't be better to have only ONE oxygen gtk engine? And I think native one should be preferred solution for us instead of hacks painting widgets by other toolkit.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Jan 5 Jan

7:17 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #9 from Magnus Tuominen magnus.tuominen@gmail.com 2011-01-05 13:17:53 EST --- Created attachment 471919 --> https://bugzilla.redhat.com/attachment.cgi?id=471919 fix to combobox

Uploading patch to fix KDE bug #261971

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 Jan 10 Jan

7:01 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Dmitrij S. Kryzhevich krege@land.ru changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #10 from Dmitrij S. Kryzhevich krege@land.ru 2011-01-10 01:01:22 EST --- Sorry for delay.

Rename: you said "no", OK. BR: OK.

============= APPROVED. =============

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Jan 11 Jan

5:35 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #11 from Rex Dieter rdieter@math.unl.edu 2011-01-11 11:35:06 EST --- Thanks!

New Package SCM Request ======================= Package Name: oxygen-gtk Short Description: Oxygen GTK theme Owners: rdieter Branches: f13 f14 el6 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:19 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu 2011-01-11 13:19:46 EST --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:33 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:33 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-01-11 14:33:34 EST --- oxygen-gtk-1.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/oxygen-gtk-1.0.0-2.fc14

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:34 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-01-11 14:34:08 EST --- oxygen-gtk-1.0.0-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/oxygen-gtk-1.0.0-2.fc13

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Jan 14 Jan

12:34 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-01-13 18:34:40 EST --- oxygen-gtk-1.0.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update oxygen-gtk'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/oxygen-gtk-1.0.1-1.fc13

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Jan 22 Jan

12:02 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-01-21 18:02:36 EST --- oxygen-gtk-1.0.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:02 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:08 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

--- Comment #17 from Fedora Update System updates@fedoraproject.org 2011-01-21 18:08:31 EST --- oxygen-gtk-1.0.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:08 a.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|oxygen-gtk-1.0.1-1.fc13 |oxygen-gtk-1.0.1-1.fc14

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Dec 8 Dec

7:19 p.m.

New subject: [Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=663092

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4975

Age (days ago)

5334

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla