Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876865
--- Comment #6 from Pete Travis <me(a)petetravis.com> ---
(In reply to comment #5)
Thanks for updates!
Some more:
rpmlint issues:
brewtarget.x86_64: W: invalid-license WTFPLv2
brewtarget.x86_64: W: invalid-license LGPLv2.1
According to
https://fedoraproject.org/wiki/Licensing:
Main?rd=Licensing#Software_License_List
the correct short names are LGPLv2+ and WTFPL
Corrected. After reading through a few licensing pages, I have a better
understanding of the requirement here - the shortnames are more generalized
than I thought.
brewtarget.x86_64: W: no-manual-page-for-binary brewtarget
There is in fact a man page available in
brewtarget-1.2.5/doc/brewtarget.1
Add that by doing e.g. in %install
install -D 0644 doc/brewtarget.1 ${buildroot}%{_mandir}/man1/brewtarget.1
Good point, thanks for that.
%{_mandir}/man1/brewtarget.1*
in %files.
Done. I assume the wildcard is to accommodate future, additional manpages, so
why not '%{_mandir}/man*/brewtarget*' ?
Pedantic space and empty lines hang ups:
- no empty lines before %description
- remove leading space in make %{?_smp_mflags} line
- just a single empty line before %install and %changelog
- one empty line between each item in %changelog
Done.
BTW: the reason for %{version} in source0 is to avoid trouble when
updating version and forgetting to update source0, you only need it the
filename, not in the url.
I've been reading through reviews and doing some mock ones of my own - I see
this convention is standard and I've corrected my URL accordingly.
Thanks again, Terje. I really appreciate the help.
Updated URLS:
SPEC:
http://randomuser.org/brewtarget/brewtarget.spec
SRPM:
http://randomuser.org/brewtarget/brewtarget-1.2.5-3.fc17.src.rpm
KOJI:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4698972
--
You are receiving this mail because:
You are on the CC list for the bug.