https://bugzilla.redhat.com/show_bug.cgi?id=978010
Bug ID: 978010 Summary: Review Request: perl-Wx-GLCanvas - Interface to wxWidgets' OpenGL canvas Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhroncok@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: https://raw.github.com/hroncok/SPECS/master/perl-Wx-GLCanvas.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Wx-GLCanvas-0.09-1.fc18.src....
Description: A wrapper for wxWidgets' wxGLCanvas, used to display OpenGL graphics.
Fedora Account System Username: churchyard
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #1 from Petr Šabata psabata@redhat.com --- Ok, the deps are all wrong :)
What you actually need to BR: perl, perl(Exporter), perl(lib), perl(strict), perl(Wx::build::MakeMaker), and wxGTK-devel
ExtUtils::MakeMaker is only used if Wx::build::MakeMaker is not present. Alien::wxWidgets and Wx are not required for build in your case.
I don't understand how the package builds without the wx/* files since they're all included in GLCanvas.xs. Could you explain that? Also, why do you remove the directory?
You'll need to buildrequire many more modules in the %{?with_tests} conditional block: perl(base), lib/Wx/GLCanvas.pm:17 perl(Test::More), t/zz_pod.t:4 perl(Wx), lib/Wx/GLCanvas.pm:16 perl(Wx::ScrolledWindow), lib/Wx/GLCanvas.pm:17
Protip: You could use Test::NeedsDisplay to provide an Xvfb display for the tests, running them everywhere, every time. https://metacpan.org/module/ADAMK/Test-NeedsDisplay-1.07/lib/Test/NeedsDispl...
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #2 from Miro Hrončok mhroncok@redhat.com --- Sorry for the messed deps.
Thanks for the protip.
wx dir contains bundled things, that should be included from /usr/include/wx-2.8/wx (see -I/usr/include/wx-2.8 in spec).
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://raw.github.com/hroncok/SPECS/master/perl-Wx-GLCanvas.spec SRPM URL: http://churchyard.fedorapeople.org/SRPMS/perl-Wx-GLCanvas-0.09-2.fc19.src.rp...
I've redone BRs. The protip with Test::NeedsDisplay destroys the package. It forces the installation to use /usr/local
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Petr Šabata psabata@redhat.com --- Alright, I'm going to approve this.
However, drop the Test::NeedsDisplay and xorg-x11-server-Xvfb dependencies if they don't work for you before you push this.
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #5 from Miro Hrončok mhroncok@redhat.com --- Of course, I forgot to do that. Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Miro Hrončok mhroncok@redhat.com --- New Package SCM Request ======================= Package Name: perl-Wx-GLCanvas Short Description: Interface to wxWidgets' OpenGL canvas Owners: churchyard Branches: f18 f19 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Wx-GLCanvas-0.09-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Wx-GLCanvas-0.09-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=978010
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Wx-GLCanvas-0.09-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Wx-GLCanvas-0.09-2.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Wx-GLCanvas-0.09-2.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Wx-GLCanvas-0.09-2.fc1 | |8 Resolution|--- |ERRATA Last Closed| |2013-08-01 23:40:45
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Wx-GLCanvas-0.09-2.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=978010
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Wx-GLCanvas-0.09-2.fc1 |perl-Wx-GLCanvas-0.09-2.fc1 |8 |9
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Wx-GLCanvas-0.09-2.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org