[Bug 225638] New: Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225638

Summary: Merge Review: cdparanoia
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: cdparanoia

http://cvs.fedora.redhat.com/viewcvs/devel/cdparanoia/
Initial Owner: [e-mail]

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cdparanoia

https://bugzilla.redhat.com/show_bug.cgi?id=225638

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-08-31 12:03 EST -------
Please find an updated spec file and a patch to the current spec file containing
some suggested changes and fixes :
http://thias.fedorapeople.org/merge-review/cdparanoia/

- Move .so symlink to the devel sub-package (#203620).
- Reorder and clean up the spec file.
- Remove use of "ver" and "realver".
- Convert spec file to UTF-8 and escape all macros in changelog.
- Add highest known version to the cdparanoia-III obsoletes.
- Include install patch to have DESTDIR work and libs +x for correct debuginfo.

It's quite a major cosmetic cleanup overall :-)

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cdparanoia

https://bugzilla.redhat.com/show_bug.cgi?id=225638

------- Additional Comments From [e-mail]  2007-09-12 07:23 EST -------
Ping? It would be nice to get this package cleaned up for Fedora 8.

If you'd like a co-maintainer for this package, also just let me know, I'd be
interested. It could also be interesting to get the latest 10pre version during
the Fedora 9 development for it to get some more testing.

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cdparanoia

https://bugzilla.redhat.com/show_bug.cgi?id=225638

------- Additional Comments From [e-mail]  2007-10-22 11:14 EST -------
Too late for Fedora 8... ping again?

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225638

Matthias Saou  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Matthias Saou   2008-12-22 16:42:11 EDT ---
CC'ing ajax, since he seems to have updated the package quite a bit lately.

I've updated the cleaned up spec file found here :
http://thias.fedorapeople.org/merge-review/cdparanoia/

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225638

Matthias Saou  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail])

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225638

--- Comment #5 from Matthias Saou   2009-12-08 12:26:33 EDT ---
> From the spec, something got done at some point, all hope is not lost! (thanks,

ajax ;-)) :

* Tue Feb 10 2009 Adam Jackson 
- Merge review cleanups (not finished, #225638)

Nevertheless, I've taken the liberty to at least partially continue the changes
by including all of the obvious and unavoidable ones. Here is the detail :
- Don't prefix summaries with "A" nor suffix them with a dot.
- Move .so symlink to the devel sub-package (#203620).
- Add highest known version to the cdparanoia-III obsoletes.
- Remove incorrect buildroot removal from %%build.
- Use acceptable %%clean section.
- Provide cdparanoia-static in the devel sub-package since the *.a is there.
- Use single-command scriplet syntax for /sbin/ldconfig calls.
- Escape all macros in changelog.
- Include license file since it is present with the sources.

I'll rebase my other changes (cosmetic cleanups and install patch) against this
new spec file.

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225638

Bug 225638 depends on bug 203620, which changed state.

Bug 203620 Summary: cdpranoia-libs .so should be in -devel
https://bugzilla.redhat.com/show_bug.cgi?id=203620

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 225638] Merge Review: cdparanoia

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225638

--- Comment #6 from Matthias Saou   2009-12-08 12:45:39 EDT ---
The latest suggested changes to the package against the latest spec are here :
http://thias.fedorapeople.org/merge-review/cdparanoia/