Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Perl-Critic-Pulp - Some add-on perlcritic policies
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Summary: Review Request: perl-Perl-Critic-Pulp - Some add-on perlcritic policies Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ppisar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Pulp/perl-Perl-Critic-Pulp.s... SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Pulp/perl-Perl-Critic-Pulp-4... Description: This is a collection of add-on policies for Perl::Critic. They're under a "pulp" theme plus other themes according to their purpose (see "POLICY THEMES" in Perl::Critic).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
--- Comment #1 from Marcela Mašláňová mmaslano@redhat.com 2011-01-25 11:30:22 EST --- Missing perl(Test::DistManifest).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |672543
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |690569
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Bug 672561 depends on bug 672543, which changed state.
Bug 672543 Summary: Review Request: perl-Test-DistManifest - Author test that validates a package MANIFEST https://bugzilla.redhat.com/show_bug.cgi?id=672543
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mmaslano@redhat.com Flag| |fedora-review+
--- Comment #2 from Marcela Mašláňová mmaslano@redhat.com 2011-03-30 03:40:11 EDT --- - rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK http://koji.fedoraproject.org/koji/taskinfo?taskID=2959749 - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK
rpm -qp --provides ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm perl(Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon) = 46 perl(Perl::Critic::Policy::Compatibility::ConstantPragmaHash) = 46 perl(Perl::Critic::Policy::Compatibility::Gtk2Constants) = 46 perl(Perl::Critic::Policy::Compatibility::PerlMinimumVersionAndWhy) = 46 perl(Perl::Critic::Policy::Compatibility::PodMinimumVersion) = 46 perl(Perl::Critic::Policy::Compatibility::ProhibitUnixDevNull) = 46 perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup) = 46 perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup::Parser) perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup) = 46 perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup::Parser) perl(Perl::Critic::Policy::Documentation::RequireEndBeforeLastPod) = 46 perl(Perl::Critic::Policy::Miscellanea::TextDomainPlaceholders) = 46 perl(Perl::Critic::Policy::Miscellanea::TextDomainUnused) = 46 perl(Perl::Critic::Policy::Modules::ProhibitModuleShebang) = 46 perl(Perl::Critic::Policy::Modules::ProhibitPOSIXimport) = 46 perl(Perl::Critic::Policy::Modules::ProhibitUseQuotedVersion) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::NotWithCompare) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitBarewordDoubleColon) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitFiletest_f) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitUnknownBackslash) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::RequireNumericVersion) = 46 perl(Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral) = 46 perl(Perl::Critic::Pulp) = 46 perl(Perl::Critic::Pulp::PodMinimumVersionViolation) perl(Perl::Critic::Pulp::PodParser) perl(Perl::Critic::Pulp::Utils) = 46 perl(Perl::MinimumVersion) perl(Pod::MinimumVersion) = 46 perl(Pod::MinimumVersion::Parser) perl(Pod::MinimumVersion::Report) perl-Perl-Critic-Pulp = 46-1.fc16
rpm -qp --requires ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm | sort perl >= 0:5.005 perl >= 0:5.006 perl(base) perl(constant) perl(Exporter) perl(IO::String) >= 1.02 perl(List::MoreUtils) >= 0.24 perl(List::Util) perl(:MODULE_COMPAT_5.12.3) perl(overload) perl(Perl::Critic) >= 1.084 perl(Perl::Critic::Policy) >= 1.084 perl(Perl::Critic::Pulp) perl(Perl::Critic::Pulp::PodParser) perl(Perl::Critic::Pulp::Utils) perl(Perl::Critic::Utils) >= 1.100 perl(Perl::Critic::Utils::PPI) perl(Perl::Critic::Violation) perl(Pod::MinimumVersion) perl(Pod::Parser) perl(POSIX) perl(PPI) >= 1.208 perl(PPI::Document) perl(Scalar::Util) perl(strict) perl(Test::More) perl(vars) perl(version) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1
ACCEPT
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
--- Comment #3 from Petr Pisar ppisar@redhat.com 2011-04-04 09:26:51 EDT --- New Package SCM Request ======================= Package Name: perl-Perl-Critic-Pulp Short Description: Some add-on perlcritic policies Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2011-04-05 11:22:05 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Perl-Critic-Pulp-46-1. | |fc16 Resolution| |RAWHIDE Last Closed| |2011-04-05 12:41:14
--- Comment #5 from Petr Pisar ppisar@redhat.com 2011-04-05 12:41:14 EDT --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org