[Bug 447285] New: Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=447285

Summary: Review Request: libx86 - library for making real-mode
                    x86 calls
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.codon.org.uk/~mjg59/libx86/rpms/libx86.spec
SRPM URL: http://www.codon.org.uk/~mjg59/libx86/rpms/libx86-1.1-1.fc9.src.rpm
Description: A library to provide support for making real-mode x86 calls. On 32-bit x86 hardware, vm86 mode is used. x86 emulation is provided on other platforms. This library is primarily used by vbetool for reinitialising graphics hardware on resume from suspend.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

------- Additional Comments From [e-mail]  2008-05-20 10:21 EST -------
One obvious bug before I begin, you want %postun , not %postrun .

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

------- Additional Comments From [e-mail]  2008-05-20 10:34 EST -------
 - Package meets naming and packaging guidelines
 - Spec file matches base package name.
 - Spec has consistent macro usage.
 - Meets Packaging Guidelines.
 - License
 - License field in spec matches
 - License file included in package
 - Spec in American English
 - Spec is legible.
 - Sources match upstream md5sum:
41bee1f8e22b82d82b5f7d7ba51abc2a  libx86-1.1-1.fc9/libx86-1.1.tar.gz
41bee1f8e22b82d82b5f7d7ba51abc2a  libx86-1.1.tar.gz

- Package does not need ExcludeArch
 - BuildRequires correct
 - Package has %defattr and permissions on files is good.
 - Package has a correct %clean section.
 - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 - Package is code or permissible content.
 - Doc subpackage not needed/used.
 - Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
 - Spec has needed ldconfig in post and postun
 - .pc files in -devel subpackage/requires pkgconfig
 - .so files in -devel subpackage.
 - -devel package Requires: %{name} = %{version}-%{release}
 - .la files are removed.

- Package compiles and builds on at least one arch.
 - Package has no duplicate files in %files.
 - Package doesn't own any directories other packages own.
 - Package creates no directories.
 - No rpmlint output.

Builds in mock locally, submitted to koji but that's being a bit laggy.

The %description text is a bit misleading since you're building it with x86emu
everywhere.  Fix that and the %postrun typo and we'll call this approved.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

------- Additional Comments From [e-mail]  2008-05-20 10:38 EST -------
Ok, both fixed.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-20 10:41 EST -------
Approved.  See
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure for the next
steps.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-20 10:44 EST -------
New Package CVS Request
=======================
Package Name: libx86
Short Description: Library for making real-mode x86 calls
Owners: mjg59
Branches: 
InitialCC: 
Cvsextras Commits: yes

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-20 12:13 EST -------
cvs done.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-06-05 15:13 EST -------
Built in rawhide, closing.

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2008-06-11 09:17 EST -------
Package Change Request
======================
Package Name: libx86
New Branches: F-9

[Bug 447285] Review Request: libx86 - library for making real-mode x86 calls

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libx86 - library for making real-mode x86 calls

https://bugzilla.redhat.com/show_bug.cgi?id=447285

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-06-11 12:47 EST -------
cvs done.