Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-daemon - Library to implement a well-behaved Unix daemon process
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Summary: Review Request: python-daemon - Library to implement a well-behaved Unix daemon process Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kushaldas@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://kushal.fedorapeople.org/packages/python-daemon.spec SRPM URL: http://kushal.fedorapeople.org/packages/python-daemon-1.4.6-1.fc11.src.rpm Description: This library implements the well-behaved daemon specification of PEP 3143, "Standard daemon process library".
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1433003
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-06-24 03:57:19 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1433042 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 874e40daa053644e2899f7def181a252087003e3 python-daemon-1.4.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application
Suggestions: 1) I don't get why you need version_info_fix.patch. Better do same in spec as sed -i -e "s|#!/usr/bin/env python||" daemon/version/version_info.py 2) Should use %global instead %define
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Kushal Das kushaldas@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Kushal Das kushaldas@gmail.com 2009-06-24 04:45:53 EDT --- New Package CVS Request ======================= Package Name: python-daemon Short Description: Library to implement a well-behaved Unix daemon process Owners: kushal Branches: F-11 InitialCC: kushal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-06-24 14:20:24 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2009-07-01 02:21:36 EDT --- is this built for requested branches?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
--- Comment #5 from Parag AN(पराग) panemade@gmail.com 2009-07-06 11:54:29 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
--- Comment #6 from Parag AN(पराग) panemade@gmail.com 2009-07-10 05:01:00 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
--- Comment #7 from Parag AN(पराग) panemade@gmail.com 2009-07-15 12:17:54 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
--- Comment #8 from Parag AN(पराग) panemade@gmail.com 2009-07-23 02:20:17 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507773
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #9 from Parag AN(पराग) panemade@gmail.com 2009-10-08 06:10:29 EDT --- Its enough wait from submitter (as he said he will close this) now.
CLOSED.
package-review@lists.fedoraproject.org