[Bug 495246] New: Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors
Alias: perl-POE-Test-Loops

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Summary: Review Request: perl-POE-Test-Loops - Reusable tests
                    for POE::Loop authors
           Product: Fedora
           Version: rawhide
          Platform: All
               URL: http://search.cpan.org/dist/POE-Test-Loops
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://fedorapeople.org/~cweyl/review/perl-POE-Test-Loops.spec
SRPM URL:
http://fedorapeople.org/~cweyl/review/perl-POE-Test-Loops-1.005-1.fc10.src.r...

Description:
POE::Test::Loops contains one function, generate(), which will generate
all the loop tests for one or more POE::Loop subclasses. The SYNOPSIS
example is a version of poe-gen-tests, which is a stand-alone utility
to generate the actual tests. The poe-gen-tests manpage also documents
the POE::Test::Loops system in more detail.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1289744

Additional Comment:

This package is a dep of POE 1.004.

*rt-0.05

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Iain Arnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Iain Arnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell   2009-04-11 00:50:15 EDT ---
+ source files match upstream.  
  85a7b805542ecfae32cec5319a3d4eb8f44e1fd1  POE-Test-Loops-1.005.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1289744

+ package installs properly.
+ rpmlint has no complaints:
  perl-POE-Test-Loops.src: I: checking
  perl-POE-Test-Loops.noarch: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(POE::Test::DondeEstan)  
  perl(POE::Test::Loops) = 1.005
  perl-POE-Test-Loops = 1.005-1.fc11
=
  /usr/bin/perl  
  perl(:MODULE_COMPAT_5.10.0)  
  perl(File::Find)  
  perl(File::Path)  
  perl(File::Spec)  
  perl(Getopt::Long)  
  perl(IO::File)  
  perl(IO::Socket)  
  perl(IO::Socket::INET)  
  perl(POE)  
  perl(POE::NFA)  
  perl(POE::Session)  
  perl(POE::Test::DondeEstan)  
  perl(POE::Test::Loops)  
  perl(POSIX)  
  perl(Socket)  
  perl(Symbol)  
  perl(Test::More)  
  perl(lib)  
  perl(strict)  
  perl(vars)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass.
  All tests successful.
  Files=1, Tests=1,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.06 cusr  0.00
csys =  0.10 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

APPROVED

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

--- Comment #2 from Chris Weyl   2009-04-11 01:00:07 EDT ---
New Package CVS Request
=======================
Package Name: perl-POE-Test-Loops
Short Description: Reusable tests for POE::Loop authors
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Chris Weyl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #3 from Kevin Fenzi   2009-04-12 14:28:18 EDT ---
cvs done.

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Chris Weyl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #4 from Chris Weyl   2009-04-12 15:30:06 EDT ---
Thanks for the review! :-)

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #5 from Steve Traylen   2009-12-01 04:09:55 EDT ---
Package Change Request
======================
Package Name: perl-POE-Test-Loops
New Branches: EL-5
Owners: stevetraylen

Hi
 I contacted Chris a few weeks ago and he was happy for me 
 to take perl-POE* in EPEL.

Also explicitly for perl-POE-Test-Loops I asked again last week to confirm
 and no reply was given.

Steve

[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=495246

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #6 from Kevin Fenzi   2009-12-03 01:45:37 EDT ---
cvs done.