[Bug 708970] New: Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-Platform - Hopefully robust platform sensing

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Summary: Review Request: rubygem-Platform - Hopefully robust
                    platform sensing
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://people.redhat.com/vondruch/rubygem-Platform.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-Platform-0.4.0-1.fc16.src.rpm
Description: Hopefully robust platform sensing

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3100000

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |705515

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|705515                      |

--- Comment #1 from Marcela Mašláňová  2011-05-30 07:33:22 EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license ?
 I found LGPL without version.
- text of the license in its own file must be included in %doc ?
 You should add LGPL statement into doc.
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

resolvedeps-f16 ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm

rpm -qp --provides ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm
rubygem(Platform) = 0.4.0
rubygem-Platform = 0.4.0-1.fc16

rpm -qp --requires ~/Downloads/rubygem-Platform-0.4.0-1.fc16.noarch.rpm
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
ruby  
ruby(abi) = 1.8
rubygems  
rpmlib(PayloadIsXz) <= 5.2-1

So, only problem is the license.

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |705515

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

--- Comment #2 from Vít Ondruch  2011-05-31 06:27:23 EDT ---
(In reply to comment #1)
> license field must match actual license ?
>
> I found LGPL without version.

See the http://fedoraproject.org/wiki/Licensing and you will find that if
somebody states LGPL, it means actually LGPLv2+ and the short name is LGPLv2+.
There is no LGPL short name listed.
> text of the license in its own file must be included in %doc ?
>
> You should add LGPL statement into doc.

What is meant by that? I have no license file, so I have nothing to include. I
may request that file from upstream.

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

--- Comment #3 from Marcela Mašláňová  2011-05-31 06:59:04 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > license field must match actual license ?
> >
> > I found LGPL without version.
>
> See the http://fedoraproject.org/wiki/Licensing and you will find that if
> somebody states LGPL, it means actually LGPLv2+ and the short name is LGPLv2+.
> There is no LGPL short name listed.

Ok.
> > text of the license in its own file must be included in %doc ?
> >
> > You should add LGPL statement into doc.
>
> What is meant by that? I have no license file, so I have nothing to include. I
> may request that file from upstream.

License must be included in every package. Details about sub-packages:
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licen...

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #4 from Marcela Mašláňová  2011-05-31 07:18:37 EDT ---
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

Ok, this package contain almost nothing, so you don't have anything to package
here.

APPROVED

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Vít Ondruch  2011-06-01 09:58:12 EDT ---
Thank you for your review.

New Package SCM Request
=======================
Package Name: rubygem-Platform
Short Description: Hopefully robust platform sensing
Owners: vondruch
Branches: 
InitialCC:

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

--- Comment #6 from Jon Ciesla  2011-06-01 12:10:10 EDT ---
Git done (by process-git-requests).

[Bug 708970] Review Request: rubygem-Platform - Hopefully robust platform sensing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=708970

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-06-03 10:32:14