[Bug 469052] New: Review Request: ris-linux - RIS for Linux - Boot winpe from the net / Ris Windows Installation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ris-linux - RIS for Linux - Boot winpe from the net / Ris Windows Installation
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Summary: Review Request: ris-linux - RIS for Linux - Boot winpe from the net / Ris Windows Installation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kanarip@kanarip.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.kanarip.com/custom/SPECS/ris-linux.spec SRPM URL: http://www.kanarip.com/custom/f9/SRPMS/ris-linux-0.4-1.fc9.src.rpm Description: RIS for Linux - Boot winpe from the net / Ris Windows Installation
rpmlint silent
koji scratch builds:
- dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=910933 - dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=910935 - dist-f10-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=910937 - dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=910939
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #1 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2008-11-02 16:35:51 EDT --- 1 - please fix macros.
replace %{_sysconfdir}/init.d/ with %{_initrddir}
more info here.
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macro...
2 - improve scriptlets
https://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_...
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
also when a more experienced user look your spec, he will ask to use install -p to preserve timestamps :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #2 from Jeroen van Meeuwen kanarip@kanarip.com 2008-11-02 19:27:38 EDT --- (In reply to comment #1)
1 - please fix macros.
replace %{_sysconfdir}/init.d/ with %{_initrddir}
Fixed.
2 - improve scriptlets
https://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_...
Fixed.
also when a more experienced user look your spec, he will ask to use install -p to preserve timestamps :-)
Fixed.
New SPEC: http://www.kanarip.com/custom/SPECS/ris-linux.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/ris-linux-0.4-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #3 from Jeroen van Meeuwen kanarip@kanarip.com 2008-12-05 08:30:01 EDT --- Fixed some other issues with the package:
New SPEC: http://www.kanarip.com/custom/SPECS/ris-linux.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/ris-linux-0.4-3.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2009-01-12 18:01:50 EDT --- As promised....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2009-01-12 22:56:55 EDT --- Could you define "WinPE" in your %description? Just a parenthetical "Windows Preinstallation Environment" should be sufficient. Also, it needs a period at the end.
You're missing Requires(preun): initscripts, and also a python dependency for your %post script.
Does it make sense to include the sample .sif files? What about the manual from the upstream web site (http://oss.netfarm.it/guides/ris-linux.pdf)?
This package is a little odd in that it installs as a service, but doesn't actually put any executables in %path. There isn't anything in the guidelines that would prohibit this as far as I can tell, but it seems a little admin-unfriendly. I don't know what to do about it; maybe a wrapper script that just calls "python /usr/share/ris-linux/binlsrv.py". But I'll leave that up to you.
* source files match upstream. sha256sum: 196c7441f498154d1ae41ef4f1e5107296b7de39f345c763ccce2e913432ae19 ris-linux-0.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. X description could use a bit of work * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: config(ris-linux) = 0.4-3.fc11 ris-linux = 0.4-3.fc11 = /bin/sh /usr/bin/env chkconfig config(ris-linux) = 0.4-3.fc11 initscripts python(abi) >= 2.1 samba tftp-server
* owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files X scriptlet dependencies are off. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #6 from Jeroen van Meeuwen kanarip@kanarip.com 2009-01-14 07:53:01 EDT --- (In reply to comment #5)
Could you define "WinPE" in your %description? Just a parenthetical "Windows Preinstallation Environment" should be sufficient. Also, it needs a period at the end.
Fixed.
You're missing Requires(preun): initscripts, and also a python dependency for your %post script.
Fixed.
Does it make sense to include the sample .sif files? What about the manual from the upstream web site (http://oss.netfarm.it/guides/ris-linux.pdf)?
I've included the sample .sif file, although I'm reluctant to say it's good enough.
The upstream .pdf documentation though I'm not including. Other documentation is in the works that includes using Cobbler to manage the largest part of what is in the upstream documentation, and I'd rather set the record straight then whilst not confusing users of the package now (like with patching in.tftpd).
This package is a little odd in that it installs as a service, but doesn't actually put any executables in %path. There isn't anything in the guidelines that would prohibit this as far as I can tell, but it seems a little admin-unfriendly. I don't know what to do about it; maybe a wrapper script that just calls "python /usr/share/ris-linux/binlsrv.py". But I'll leave that up to you.
Fixed, and actually works way better for "service ris-linuxd status". Maybe this should be a Packaging Guidelines? ;-)
New SPEC: http://www.kanarip.com/custom/SPECS/ris-linux.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/ris-linux-0.4-4.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2009-01-15 20:50:31 EDT --- Looks good to me. No big deal if you don't want to include the PDF docs; I didn't actually verify that they were useful. This seems a useful thing to be able to do and I hope that at some point there's some reasonable documentation explaining the procedure.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Jeroen van Meeuwen kanarip@kanarip.com 2009-01-17 09:48:40 EDT --- Thanks, I owe you a beverage of your choice ;-)
New Package CVS Request ======================= Package Name: ris-linux Short Description: RIS for Linux - Boot winpe from the net / Ris Windows Installation Owners: kanarip Branches: EL-4 EL-5 F9 F-10 InitialCC: kanarip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-01-18 17:32:11 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-01-23 21:37:31 EDT --- ris-linux-0.4-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ris-linux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0904
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-01-23 21:38:37 EDT --- ris-linux-0.4-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update ris-linux'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0913
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-04-06 16:23:02 EDT --- ris-linux-0.4-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.4-4.fc9 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-04-06 16:27:47 EDT --- ris-linux-0.4-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469052
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4-4.fc9 |0.4-4.fc10
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla