Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Bug ID: 884759 Summary: Review Request: toilet - colorful ASCII art generator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: zidkova.zuzana@seznam.cz
Spec URL: http://jnovy.fedorapeople.org/toilet/toilet.spec SRPM URL: http://jnovy.fedorapeople.org/toilet/toilet-0.2-1.fc18.src.rpm
Description:
The TOIlet project attempts to create a free replacement for the FIGlet utility. TOIlet stands for "The Other Implementation's letters", coined after FIGlet's "Frank, Ian and Glen's letters".
TOIlet is in its very early development phase. It uses the powerful libcaca library to achieve various text-based effects. TOIlet implements or plans to implement the following features:
The ability to load FIGlet fonts Support for Unicode input and output Support for colour fonts Support for colour output Support for various output formats: HTML, IRC, ANSI...
TOIlet also aims for full FIGlet compatibility. It is currently able to load FIGlet fonts and perform horizontal smushing. Fedora Account System Username:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org
--- Comment #1 from Michael Scherer misc@zarb.org --- Hi,
you didn't gave your username, and the email you us do not correspond to the one of jnovy in FAS, can you give the info ?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Just some quick comments:
- The latest version of toilet is 0.3 - Please rephrase the summery - There is a test folder in the source tarball. Please consider to run the test in a %check section - There are fonts in the source tarball. Are those fonts bundled?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #3 from Zuzana zidkova.zuzana@seznam.cz --- - FAS username is sysl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #4 from Zuzana zidkova.zuzana@seznam.cz --- - toilet 0.3 build requires new libcaca library still not packaged in Fedora.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #5 from Michael Scherer misc@zarb.org --- Since you are not in any packager group, could you please follow the step on https://fedoraproject.org/wiki/Join_the_package_collection_maintainers ?
I have marked this bug as needing a sponsor.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #6 from Zuzana zidkova.zuzana@seznam.cz --- Ok thaks,
Spec URL: http://jnovy.fedorapeople.org/toilet/toilet.spec SRPM URL: http://jnovy.fedorapeople.org/toilet/toilet-0.2-0.2.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Jindrich Novy jnovy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jnovy@redhat.com Flags| |fedora-review?
--- Comment #7 from Jindrich Novy jnovy@redhat.com --- Taking this review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
Jindrich Novy jnovy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |needinfo?(zidkova.zuzana@se | |znam.cz)
--- Comment #8 from Jindrich Novy jnovy@redhat.com --- rpmlint output on src.rpm:
$ rpmlint toilet-0.2-0.2.fc18.src.rpm toilet.src: W: spelling-error Summary(en_US) figlet -> filet, fillet, piglet -> sane as it references figlet utility
toilet.src: W: summary-not-capitalized C figlet alternative -> could you please rephrase the Summary in a way that it starts with a capital letter?
toilet.src: W: spelling-error %description -l en_US ancronym -> acronym, antonym -> there seems to be a typo in %description here
toilet.src: W: spelling-error %description -l en_US libcaca -> biblical -> sane, it's a library name
toilet.src: W: spelling-error %description -l en_US folowing -> flowing, following, fol owing -> seems that 'l' is missing in "following"
toilet.src: W: spelling-error %description -l en_US colour -> color, co lour, co-lour -> US English prefers "color"
toilet.src: W: spelling-error %description -l en_US smushing -> mushing, smashing, shushing -> not sure here but
IMO the %description seems to me too verbose with a lot of duplicities. Could you please reduce it?
Running rpmlint on built RPM reveals: toilet.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
So it seems it is better to own the man page like this in the %files section: %{_mandir}/man1/%{name}*
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #9 from Michael Schwendt mschwendt@gmail.com ---
Summary: figlet alternative
could you please rephrase the Summary in a way that it starts with a capital letter?
Even better, replace the summary with a clear and concise one. Such as the one used for the title of this ticket:
Summary: Colorful ASCII Art Generator
Taking the summary from the manual page, it would be:
Summary: Display large colorful characters
Referencing the "figlet" utility might be sane in the longer description, although it requires the reader to know the "figlet" utility. In the summary, however, it should be possible to "sum up" what a package does without referring to the name of some other package or piece of software. Don't focus on what the package/software is named. The package %name is for that, and the %description can also expand on the name of the software.
%{_datadir}/figlet/*
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner... https://fedoraproject.org/wiki/Packaging:UnownedDirectories
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Simon Green sgreen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jnovy@redhat.com |pknirsch@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Flags| |needinfo?(pknirsch@redhat.c | |om)
--- Comment #11 from Christopher Meng cickumqt@gmail.com --- Status?
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zidkova.zuzana@seznam.cz Flags| |needinfo?(zidkova.zuzana@se | |znam.cz)
--- Comment #12 from Christopher Meng cickumqt@gmail.com --- What's up?
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #13 from Christopher Meng cickumqt@gmail.com --- ping again.
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Zuzana zidkova.zuzana@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zidkova.zuzana@se | |znam.cz) | |needinfo?(pknirsch@redhat.c | |om) | |needinfo?(zidkova.zuzana@se | |znam.cz) |
--- Comment #14 from Zuzana zidkova.zuzana@seznam.cz --- Packages updated. Thank you for advice and sorry for the delay.
http://jnovy.fedorapeople.org/toilet/toilet.spec http://jnovy.fedorapeople.org/toilet/toilet-0.2-1.fc19.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|pknirsch@redhat.com |nobody@fedoraproject.org Flags|fedora-review? |
--- Comment #15 from Christopher Meng cickumqt@gmail.com --- (In reply to Zuzana from comment #14)
Packages updated. Thank you for advice and sorry for the delay.
No problem. Issues:
1. The latest version is 0.3. Please read comment 3 carefully.
2. Remove rm -rf $RPM_BUILD_ROOT in %install, not needed anymore nowadays.
3. And, you didn't bump the changelog for each change, please do from now on.
4. Michael pointed out the poor summary in the past, and I think the title of this bug contains a good example, however the one you currently use is poor still:
5. Summary: Display large colorful characters is still not perfect.
--------One day--------
Noob A: Is it a library? Noob B: Maybe, but I think it's a utility, bash script? Noob C: Why bash script? Can be javascript as well! Noob D: W** is the "large colorful"? Noob E: Dunno.
Then they go away.
-----------------------
Advice: Since you still need a sponsor, please send a self introduction email to @devel list to introduce yourself.
To assignee: Please keep review flag cohering with the assignee, please re assign this to yourself if you still have interests.
https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #16 from Zuzana zidkova.zuzana@seznam.cz --- (In reply to Christopher Meng from comment #15)
- The latest version is 0.3. Please read comment 3 carefully.
Toilet 0.3 requires libcaca library at least in version 0.99.beta18 but it is not available in any Fedora. Therefore such update is not possible and we need to stick to 0.2:
configure: error: you need libcaca version 0.99.beta18 or later error: Bad exit status from /var/tmp/rpm-tmp.G43QWj (%build)
- Remove rm -rf $RPM_BUILD_ROOT in %install, not needed anymore nowadays.
Done, thanks.
- And, you didn't bump the changelog for each change, please do from now on.
Changelog entry added and release bumped.
- Michael pointed out the poor summary in the past, and I think the title
of this bug contains a good example, however the one you currently use is poor still: 5. Summary: Display large colorful characters is still not perfect.
Summary is now changed to "Colorful ASCII Art Generator".
Advice: Since you still need a sponsor, please send a self introduction email to @devel list to introduce yourself.
To assignee: Please keep review flag cohering with the assignee, please re assign this to yourself if you still have interests.
https://bugzilla.redhat.com/show_bug.cgi?id=884759
--- Comment #17 from Christopher Meng cickumqt@gmail.com --- Then you need to report a bug against libcaca via:
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide...
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Zuzana zidkova.zuzana@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1062632
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1062632 [Bug 1062632] please update to libcaca 0.99.beta18
https://bugzilla.redhat.com/show_bug.cgi?id=884759 Bug 884759 depends on bug 1062632, which changed state.
Bug 1062632 Summary: please update to libcaca 0.99.beta18 https://bugzilla.redhat.com/show_bug.cgi?id=1062632
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com Flags| |needinfo?(zidkova.zuzana@se | |znam.cz)
--- Comment #18 from Miroslav Suchý msuchy@redhat.com --- Ping! Any progress here?
https://bugzilla.redhat.com/show_bug.cgi?id=884759
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(zidkova.zuzana@se | |znam.cz) | Last Closed| |2016-02-08 09:06:40
--- Comment #19 from Miroslav Suchý msuchy@redhat.com --- No response. Closing as dead review. If you ever want to continue, please resubmit.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla