[Bug 903824] New: Review Request: perl-Convert-Age - converts integer seconds into a compact form and back - package-review

List overview All Threads
Download

newer

[Bug 903824] New: Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

older

[Bug 903829] New: Review Request:...

[Bug 904329] New: Review Request:...

Red Hat Bugzilla

24 Jan 2013 24 Jan '13

9:44 p.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Bug ID: 903824 Summary: Review Request: perl-Convert-Age - converts integer seconds into a compact form and back Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv

Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Convert-Age.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Convert-Age-0.04-1.fc16.src.rpm Description: Perl module that converts integer seconds into a compact form and back e.g. 1h2m to 62 or vice-versa. Fedora Account System Username: normunds

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RTCtnkFaG0&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

24 Jan 24 Jan

9:58 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Normunds long@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)

--- Comment #1 from Normunds long@rule.lv --- Bug 903829, Bug 903826, Bug 903824 are my first Fedora packages, yet more to come. I checked them with both Mock and Koji for all Fedora releases (16, 17, 18, 19, rawhide).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5ydpfFydEg&a=cc_unsubscribe

Red Hat Bugzilla

10:06 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Normunds long@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Convert-Age

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2CSwx83Pgv&a=cc_unsubscribe

Red Hat Bugzilla

26 Jan 26 Jan

10:20 a.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #2 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.

Need sponsor.

bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cV8Sr3Fp5u&a=cc_unsubscribe

Red Hat Bugzilla

28 Jan 28 Jan

12:41 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Petr Šabata psabata@redhat.com changed:

--- Comment #3 from Petr Šabata psabata@redhat.com --- I'll look at your packages and possibly sponsor you later :)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D2YIhLTjf2&a=cc_unsubscribe

Red Hat Bugzilla

12:54 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #4 from Petr Šabata psabata@redhat.com --- Issues:

Lines 29-31 are useless. None of those files has executable bits set. Interval.* isn't even present in the archive.

Line 42 is also not needed as this is done automatically by rpmbuild.

Useless build-time dependency: perl(Test::Simple) -- not used anywhere at all.

Missing build-time dependencies: perl(Exporter) from lib/Convert/Age.pm:35 perl(Test::More) from various test files

Simple commands are preferred over command macros. Consider removing them.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iLsdsCK8rM&a=cc_unsubscribe

Red Hat Bugzilla

9:58 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #5 from Normunds long@rule.lv --- Spec file and src package updated.

* Removed useless lines * Fixed dependencies. * Replaced macros with simple commands.

New package overwritten in original location.

Thanks a lot for your review :)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MQvHrZejlv&a=cc_unsubscribe

Red Hat Bugzilla

29 Jan 29 Jan

8:19 a.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #6 from Normunds long@rule.lv --- Could you help me to fully understand how Requires and BuildRequires are used in Fedora?

1) If I enter put requirement in Requires, it will be automatically used also as BuildRequire. Do I understand this correctly?

2) In bug 904328 you mentioned that Some requirements are not needed in Requires field because rpmbuild automatically detects those requirements. How can I detect what rpmbuild detects?

3) In bug 903826 you asked me to add build time dependency perl(base), perl(constant) which actually is Perl pragma not module. When should I add Perl pragmas like perl(warnings) and perl(strict) to Requires, when shouldn't?

4) Shouldn't it be more correct to put all module requirements to Requires field and all testing requirements to BuildRequires filed (if 1st is true)?

Thanks

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sXKSmBWWxN&a=cc_unsubscribe

Red Hat Bugzilla

1:45 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #7 from Petr Šabata psabata@redhat.com --- (In reply to comment #6)

...

Could you help me to fully understand how Requires and BuildRequires are used in Fedora?

If I enter put requirement in Requires, it will be automatically used

also as BuildRequire. Do I understand this correctly?

No, those two are unrelated.

...

In bug 904328 you mentioned that Some requirements are not needed in

Requires field because rpmbuild automatically detects those requirements. How can I detect what rpmbuild detects?

The easiest and most reliable way is to build the package and check the resulting binary (not SRPM) for dependencies, e.g.

rpm -q --requires -p your-package-1.2-3.fc19.noarch.rpm

Currently, in case of perl packages, rpmbuild parses the packaged modules and tries to guess the perl() style dependencies. It works rather well for most cases and therefore you don't need to manually specify them in your spec file (usually).

...

In bug 903826 you asked me to add build time dependency perl(base),

perl(constant) which actually is Perl pragma not module. When should I add Perl pragmas like perl(warnings) and perl(strict) to Requires, when shouldn't?

Surprise, they're modules! :)

https://metacpan.org/module/base https://metacpan.org/module/constant

And requiring true pragmas wouldn't hurt (rpmbuild actually does that too) either since they are listed among the 'perl' package provides --

$ rpm -q --provides perl|grep -E '^perl((strict|warnings))' perl(strict) = 1.07 perl(warnings) = 1.13

-- but given that they are and most likely always be parts of perl, I don't find it necessary. Some people build-require them explicitly, though.

...

Shouldn't it be more correct to put all module requirements to Requires

field and all testing requirements to BuildRequires filed (if 1st is true)?

See 1). The reason why I urge you to add runtime dependencies as buildrequires is that they are actually used during the test phase -- in most cases the module is loaded, e.g. via use_ok() or other means. Of course you always have to see the actual test code.

Generally, for buildtime deps ("BuildRequires"): 1. Check the Makefile.PL or Build.PL, whatever the project uses, and add the file's dependencies to your BRs. 2. If you're running the test suite, check and add the direct test file dependencies. 3. If you're running the test suite, check and add the dependencies of modules tested by the test suite too.

For runtime deps ("Requires"): 1. Build the package and see the resulting binary RPM's "requires" and compare it with what's actually written in the packaged code. If something is missing, add it explicitly.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=erXrHhYuWe&a=cc_unsubscribe

Red Hat Bugzilla

2:03 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #8 from Petr Šabata psabata@redhat.com --- About the new package -- I see you also added the pragmas deps. That's alright. You can also remove the perl macro on the MODULE_COMPAT line, by the way.

Anyhow, the package looks good now and I'll approve it once I sponsor you.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L8xQbLpGE5&a=cc_unsubscribe

Red Hat Bugzilla

2:20 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #9 from Normunds long@rule.lv --- Thanks a lot for your comments. Is it OK if I re-check spec files and re-create packages after I have time to digest your comment about Requires and BuildRequires? Or I should notify you for another review cycle?

Thanks and best regards.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DWtDd57PSP&a=cc_unsubscribe

Red Hat Bugzilla

2:42 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Petr Šabata psabata@redhat.com changed:

--- Comment #10 from Petr Šabata psabata@redhat.com --- Sure, just update the reviews you've submitted.

By the way, I've just sponsored you into the packager group. Now you can submit the SCM request for your approved packages: http://fedoraproject.org/wiki/Package_SCM_admin_requests

Please, mention me (psabata) as one of the owners and put "perl-sig" in the InitialCC field too.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0kBXnUIZwJ&a=cc_unsubscribe

Red Hat Bugzilla

31 Jan 31 Jan

9:57 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #11 from Normunds long@rule.lv --- Package updated (Macro in MODULE_COMPATm, re-checked dependencies according to Requires and BuildRequires practices discussed here, removed e-mail from changelog).

New Package SCM Request ======================= Package Name: perl-Convert-Age Short Description: Perl module that converts integer seconds into a "compact" form and back Owners: normunds psabata Branches: f16 f17 f18 f19 InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FoTi4u93t8&a=cc_unsubscribe

Red Hat Bugzilla

9:58 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Normunds long@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rre3gLrhQp&a=cc_unsubscribe

Red Hat Bugzilla

10:02 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #12 from Normunds long@rule.lv --- Incorrect brances in previous request. Corrected here.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=puIuZsYQjf&a=cc_unsubscribe

Red Hat Bugzilla

1 Feb 1 Feb

1:45 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eQxsvNWIMs&a=cc_unsubscribe

Red Hat Bugzilla

13 Feb 13 Feb

4:12 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TsIKFoJS8y&a=cc_unsubscribe

Red Hat Bugzilla

4:13 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Convert-Age-0.04-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Convert-Age-0.04-1.fc16

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cXqNzBs6jV&a=cc_unsubscribe

Red Hat Bugzilla

6:55 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Convert-Age-0.04-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Convert-Age-0.04-1.fc17

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IkZFrA4ZNl&a=cc_unsubscribe

Red Hat Bugzilla

7:48 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Convert-Age-0.04-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Convert-Age-0.04-1.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MCpolYSgOQ&a=cc_unsubscribe

Red Hat Bugzilla

24 Feb 24 Feb

8:43 a.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-Convert-Age-0.04-1.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sRap1JG71H&a=cc_unsubscribe

Red Hat Bugzilla

8:59 a.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-Convert-Age-0.04-1.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ID6OcrdYT0&a=cc_unsubscribe

Red Hat Bugzilla

3 Apr 3 Apr

4:11 p.m.

New subject: [Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

https://bugzilla.redhat.com/show_bug.cgi?id=903824

Petr Šabata psabata@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4128

Age (days ago)

4562

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla