https://bugzilla.redhat.com/show_bug.cgi?id=1277818
Bug ID: 1277818 Summary: Review Request: vowpal-wabbit - Fast and efficient machine learning system Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit-8.1-1.fc24... Description: The Vowpal Wabbit (VW) project is a fast out-of-core learning system sponsored by Microsoft Research and (previously) Yahoo! Research. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
--- Comment #1 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit-8.1-2.fc24...
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |vowpal-wabbit
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Please extend the %description to say what this package actually does. Who sponsors the project is something that is not normally included in the %description.
Since you install stuff in %{_libdir}, add scriptlets [https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries].
Version 8.1.1 is out.
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
--- Comment #3 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/vowpal-wabbit-8.1.1-1.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- /bin/vw-regr uses ruby. It has #!/usr/bin/env ruby in the header, and there are no dependencies on ruby.
/bin/vm-hypersearch has /usr/bin/env perl, it should have /usr/bin/perl.
Are you sure that active_interactor, ezexample_*, library_exmaple, spanning_tree should be installed in /bin? Maybe those examples should go in /usr/share/doc to avoid polluting the $PATH.
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- What's up with this one?
https://bugzilla.redhat.com/show_bug.cgi?id=1277818
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2018-08-22 03:30:10
--- Comment #6 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Unfortunately I don't have time to work on these review requests anymore, sorry.
package-review@lists.fedoraproject.org