https://bugzilla.redhat.com/show_bug.cgi?id=1420881
Bug ID: 1420881 Summary: Review Request: fife - Multi-platform isometric game engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ignatenko@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/fife.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/fife-0.4.1-1.fc26.src.rpm Description: Flexible Isometric Free Engine (FIFE) is a multi-platform isometric game engine written in C++. It comes with Python bindings allowing users to create games using Python as well as C++. The engine is extendable and enables you to add any feature you can imagine to your project. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com --- Note for reviewers: * It's unretirement review of old fife package in Fedora * To build python bindings you need fifechan >= 0.1.4 (it is available in koji already) * And yes, it will eat your memory when building ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Failed to build in mock:
/builddir/build/BUILD/fifengine-0.4.1/engine/core/video/cursor.cpp:29:10: fatal error: X11/Xcursor/Xcursor.h: No such file or directory #include <X11/Xcursor/Xcursor.h> ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
Are you sure you have all your dependencies declared?
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
--- Comment #4 from Igor Gnatenko ignatenko@redhat.com --- (In reply to Neal Gompa from comment #3)
Failed to build in mock:
/builddir/build/BUILD/fifengine-0.4.1/engine/core/video/cursor.cpp:29:10: fatal error: X11/Xcursor/Xcursor.h: No such file or directory #include <X11/Xcursor/Xcursor.h> ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
Are you sure you have all your dependencies declared?
fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- + /usr/bin/cat /builddir/build/SOURCES/0001-Removed-leftover-stuff-from-Cursor.-Refs-991.patch + /usr/bin/patch -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |From 400636b6fd76e1d65bd1f2e261d51486f422b3b3 Mon Sep 17 00:00:00 2001 |From: helios2000 helios2000@gmx.net |Date: Fri, 10 Feb 2017 17:22:06 +0100 |Subject: [PATCH] Removed leftover stuff from Cursor. Refs #991 I see no reason | to keep XCursor and WMCursor around. Cursor only needs SDL. | |--- | engine/core/video/cursor.cpp | 34 +--------------------------------- | 1 file changed, 1 insertion(+), 33 deletions(-) | |diff --git a/engine/core/video/cursor.cpp b/engine/core/video/cursor.cpp |index 5d4fd4e6..24f7f51c 100644 |--- a/engine/core/video/cursor.cpp |+++ b/engine/core/video/cursor.cpp -------------------------- File to patch: Skip this patch? [y] 2 out of 2 hunks ignored
Patch doesn't apply...
https://bugzilla.redhat.com/show_bug.cgi?id=1420881
--- Comment #6 from Thomas Kowaliczek linuxdonald@posteo.de --- git cherry-pick works without any problems when i checkout the release and then get the commit with cherry-pick.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com