[Bug 743497] New: Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes - package-review

List overview All Threads
Download

newer

[Bug 743497] New: Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

older

[Bug 579299] New: Review Request:...

[Bug 722956] New: Review Request:...

Red Hat Bugzilla

5 Oct 2011 5 Oct '11

1:44 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Summary: Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: eric@brouhaha.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec SRPM URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.1.20111004git59c6097.f... Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3405450 Description: The tcplay utility provides full support for creating and opening/mapping TrueCrypt-compatible volumes.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

6 Oct 6 Oct

5:34 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Michel Alexandre Salim michel+fdr@sylvestre.me changed:

--- Comment #1 from Michel Alexandre Salim michel+fdr@sylvestre.me 2011-10-06 06:34:58 EDT --- Taking this review. From a quick glance (full review forthcoming), everything looks good, but some items are no longer necessary:

- BuildRoot declaration (and clean-up in %install) only necessary if you want to target RHEL 5; you can surround them with %if %{el5} if you do target RHEL 5 - %clean section only needed in RHEL 5 & 6 (use %if %{rhel} if you want to target them) - could you ask upstream for a standalone COPYING or LICENSE text, and put a comment linking to the request (if made on an issue tracker or mailing list) or indicating that the request has been made to the author?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:35 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Michel Alexandre Salim michel+fdr@sylvestre.me changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:51 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #2 from Michel Alexandre Salim michel+fdr@sylvestre.me 2011-10-06 06:51:04 EDT --- * TODO Review [70%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_package... - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines%5D%5Bguidelines]] - [ ] Source files match upstream Please provide your own instructions, so the tarball generation is reproducible, rather than using the latest github snapshot. And perhaps use xz rather than gz? e.g. git clone git://github.com/bwalex/tc-play ( cd tc-play && \ git archive --format=tar --prefix=%{name}-%{githash}/ %{githash} \ ) | xz - > %{name}-%{githash}.tar.xz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries%5D%5BNo bundled libraries]] - [-] License [3/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [ ] License included iff packaged by upstream please ask upstream for this - [X] rpmlint [2/2] - [X] on src.rpm tcplay.src: W: invalid-url Source0: bwalex-tc-play-59c6097.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - [X] on x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [X] Build [3/3] - [X] Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=3405450 - [X] BRs complete - [X] Directory ownership - [-] Spec inspection [5/8] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [ ] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag%5D%5Bexcep... if targeting RHEL5]]) - [ ] [RHEL] %clean section https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) - [ ] [RHEL 5] %buildroot cleaned on %install as noted in previous message, please indicate if you're targeting el5 and/or el6 - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:26 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #3 from Michel Alexandre Salim michel+fdr@sylvestre.me 2011-10-06 10:26:25 EDT --- (In reply to comment #1)

...

Taking this review. From a quick glance (full review forthcoming), everything looks good, but some items are no longer necessary:

BuildRoot declaration (and clean-up in %install) only necessary if you want

to target RHEL 5; you can surround them with %if %{el5} if you do target RHEL 5

%clean section only needed in RHEL 5 & 6 (use %if %{rhel} if you want to

target them)

My bad; I mean %if 0%{?el5} and %if 0%{?rhel}

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:30 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #4 from Eric Smith eric@brouhaha.com 2011-10-06 19:30:05 EDT --- Updated per your comments. Thanks!

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec SRPM URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.2.20111004git59c6097.f... Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3411160

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Oct 7 Oct

10:20 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #5 from Eric Smith eric@brouhaha.com 2011-10-07 23:20:05 EDT --- Updated to latest upstream, which added a LICENSE file.

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec SRPM URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.3.20111007git97ed5f9.f... Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3413307

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Oct 8 Oct

2:27 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #6 from Eric Smith eric@brouhaha.com 2011-10-08 15:27:05 EDT --- I see that I overlooked a few of the requests and have been told that even RHEL6 doesn't need the buildroot cleaned in %install, so I've cleaned the spec up further.

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec SRPM URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.4.20111007git97ed5f9.f...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Oct 12 Oct

5:06 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Michel Alexandre Salim michel+fdr@sylvestre.me changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #7 from Michel Alexandre Salim michel+fdr@sylvestre.me 2011-10-12 06:06:44 EDT --- Snapshot-creating script works; source hashes match, LICENSE file is now included and the macros are cleaned up.

Review APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:47 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Eric Smith eric@brouhaha.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #8 from Eric Smith eric@brouhaha.com 2011-10-12 12:47:32 EDT --- New Package SCM Request ======================= Package Name: tcplay Short Description: Utility to create/open/map TrueCrypt-compatible volumes Owners: brouhaha Branches: f14 f15 f16 el6 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:02 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-10-12 13:02:10 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

19 Oct 19 Oct

3:52 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:52 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-10-19 04:52:30 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:54 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-10-19 04:54:10 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:54 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-10-19 04:54:47 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:24 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-10-19 22:24:03 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been pushed to the Fedora 16 testing repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2 Nov 2 Nov

1:56 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-11-02 02:56:21 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc15 has been pushed to the Fedora 15 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:01 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-11-02 03:01:26 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc14 has been pushed to the Fedora 14 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Nov 4 Nov

8:30 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-11-04 21:30:24 EDT --- tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been pushed to the Fedora 16 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Mar 11 Mar

12:32 a.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

--- Comment #17 from Fedora Update System updates@fedoraproject.org 2012-03-11 01:32:15 EST --- tcplay-0.9-0.5.20111007git97ed5f9.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/tcplay-0.9-0.5.20111007git97ed5f9.el...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

27 Mar 27 Mar

11:55 p.m.

New subject: [Bug 743497] Review Request: tcplay - Utility to create/open/map TrueCrypt-compatible volumes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=743497

Fedora Update System updates@fedoraproject.org changed:

--- Comment #18 from Fedora Update System updates@fedoraproject.org 2012-03-28 00:55:54 EDT --- tcplay-0.9-0.5.20111007git97ed5f9.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4864

Age (days ago)

5039

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla