https://bugzilla.redhat.com/show_bug.cgi?id=1545378
Bug ID: 1545378 Summary: Review Request: libmicrodns - Minimal mDNS resolver library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kwizart@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://dl.kwizart.net/review/libmicrodns.spec SRPM URL: http://dl.kwizart.net/review/libmicrodns-0.0.8-1.fc26.src.rpm Description: Minimal mDNS resolver library Fedora Account System Username: kwizart
https://bugzilla.redhat.com/show_bug.cgi?id=1545378
--- Comment #1 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=25049910
https://bugzilla.redhat.com/show_bug.cgi?id=1545378
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com ---
- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/microdns
You must own this directory:
%dir %{_docdir}/microdns
This is trivial to fix before import, so the package is approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC", "LGPL (v2.1 or later)", "GPL (v2 or later)", "LGPL (v2.1)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/libmicrodns/review- libmicrodns/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/microdns [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/microdns [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: libmicrodns-0.0.8-1.fc28.x86_64.rpm libmicrodns-devel-0.0.8-1.fc28.x86_64.rpm libmicrodns-debuginfo-0.0.8-1.fc28.x86_64.rpm libmicrodns-debugsource-0.0.8-1.fc28.x86_64.rpm libmicrodns-0.0.8-1.fc28.src.rpm libmicrodns.x86_64: W: spelling-error Summary(en_US) mDNS -> mans, mdse libmicrodns.x86_64: W: spelling-error %description -l en_US mDNS -> mans, mdse libmicrodns-devel.x86_64: W: only-non-binary-in-usr-lib libmicrodns-devel.x86_64: W: no-documentation libmicrodns-debugsource.x86_64: W: no-documentation libmicrodns.src: W: spelling-error Summary(en_US) mDNS -> mans, mdse libmicrodns.src: W: spelling-error %description -l en_US mDNS -> mans, mdse 5 packages and 0 specfiles checked; 0 errors, 7 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1545378
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libmicrodns
https://bugzilla.redhat.com/show_bug.cgi?id=1545378
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-04-13 16:29:19
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com