[Bug 1944408] New: Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Bug ID: 1944408
           Summary: Review Request: rust-libsystemd-sys - FFI bindings to
                    libsystemd and libelogind
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3...
Description: FFI bindings to libsystemd and libelogind
Fedora Account System Username: remilauzier

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Rémi Lauzier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |177841 (FE-NEEDSPONSOR),
                   |                            |1941896
         Depends On|                            |1944392

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo
writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1944392
[Bug 1944392] Review Request: rust-build-env - Extract information about the
build process from the environment

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Rémi Lauzier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1944422

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1944422
[Bug 1944422] Review Request: rust-systemd - A rust interface to
libsystemd/libelogind provided APIs

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

--- Comment #1 from Robert-André Mauchin 🐧  ---
Using
https://copr-be.cloud.fedoraproject.org/results/remilauzier/rudo/fedora-34-x...

- You need to Requires: systemd-devel so it is included in the build process
for other packages:

%package        devel
Summary:        %{summary}
BuildArch:      noarch
Requires:       systemd-devel

%description    devel %{_description}

This package contains library source intended for building other packages
which use "%{crate}" crate.

Thus you won't need to add:

echo "systemd-devel"

in dependent packages.

- This needs to be fixed:

# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
License:        LGPLv2+ WITH [identifier] with exceptions
# FIXME: Upstream uses unknown SPDX tag WITH!

- Don't mix tabs and spaces, remove the tabs added here:

Source1:       
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/README.md
Source2:       
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/COPYING

- Macros prefixed by two underscores are for RPM private use only, use the
actual binary instead:

cp %{SOURCE1} README.md
cp %{SOURCE2} COPYING

→

# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
# https://github.com/jmesmon/rust-systemd/issues/185
License:        LGPLv2+ with exceptions

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

--- Comment #2 from Rémi Lauzier  ---
Done!
https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3...

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Robert-André Mauchin 🐧  ---
Package is approved. You still need to find a sponsor (please refer to the mail
I sent you or
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group)

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

--- Comment #5 from Tomas Hrcka  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-libsystemd-sys

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408
Bug 1944408 depends on bug 1944392, which changed state.

Bug 1944392 Summary: Review Request: rust-build-env - Extract information about the build process from the environment
https://bugzilla.redhat.com/show_bug.cgi?id=1944392

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2021-5bac42dc9d has been submitted as an update to Fedora 34.
https://bodhi.fedoraproject.org/updates/FEDORA-2021-5bac42dc9d

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  ---
FEDORA-2021-5bac42dc9d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2021-5bac42dc9d *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-5bac42dc9d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind

https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2021-05-14 17:49:05

--- Comment #8 from Fedora Update System  ---
FEDORA-2021-5bac42dc9d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.