[Bug 2124329] New: Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Bug ID: 2124329
           Summary: Review Request: rust-cssparser - Rust implementation
                    of CSS Syntax Level 3
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-cssparser.spec
SRPM URL: https://kalev.fedorapeople.org/rust-cssparser-0.28.1-4.fc38.src.rpm
Description: Rust implementation of CSS Syntax Level 3.
Fedora Account System Username: kalev

This is a re-review of a retired package, one that is needed for building
librsvg2. My goal here is to switch librsvg2 to build against Fedora packaged
crates instead of the vendored rust crates it's using now.

Note that this depends on two other re-reviews, rust-cssparser-macros and
rust-dtoa-short. The package builds fine locally in mock against locally-built
rust-cssparser-macros and rust-dtoa-short.

Also note that I'm only unretiring the package and I've deliberately left it at
version 0.28.1 that the package was before retirement and haven't updated it to
0.29.6. The reason for this is that librsvg currently needs 0.28.x and it seems
a bit weird to unretire this package because of librsvg, but include an
incompatible version update to 0.29.6 and then immediately have to create a
compat rust-cssparser0.28 package, which would mean that nothing in Fedora uses
rust-cssparser again.

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2124317, 2124326

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2124317
[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for
cssparser
https://bugzilla.redhat.com/show_bug.cgi?id=2124326
[Bug 2124326] Review Request: rust-dtoa-short - Serialize float number and
truncate to certain precision

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2124365

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2124365
[Bug 2124365] Review Request: rust-selectors - CSS Selectors matching for Rust

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #1 from Fabio Valentini  ---
> The reason for this is that librsvg currently needs 0.28.x

Yeah this is completely fine.
We usually only update library-only crates to incompatible versions when
something actually starts to depend on the new version, exactly because it
would make no sense to create a compat package and then have the non-compat
package be unused.

I'll review this package once the other dependencies are built in rawhide, if
that's okay with you.
But if you're in a hurry, I can also do the review with locally built
dependencies.

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

--- Comment #2 from Kalev Lember  ---
I'm in no hurry at all. Thanks!

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329
Bug 2124329 depends on bug 2124326, which changed state.

Bug 2124326 Summary: Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision
https://bugzilla.redhat.com/show_bug.cgi?id=2124326

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329
Bug 2124329 depends on bug 2124317, which changed state.

Bug 2124317 Summary: Review Request: rust-cssparser-macros - Procedural macros for cssparser
https://bugzilla.redhat.com/show_bug.cgi?id=2124317

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

--- Comment #3 from Kalev Lember  ---
OK, dependencies are all built in rawhide now.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=91827537

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Fabio Valentini  ---
Sorry for the delay. The notification that this is ready got lost in my inbox.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (only doctests, as test fixtures
for unit tests are not included in published crates)
- latest (possible) version of the crate is packaged (librsvg2 still requires
v0.28.x)
- license matches upstream specification ( and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

--- Comment #5 from Fabio Valentini  ---
Meh, I pressed "Submit" too fast.
Just skip the post-import tasks that aren't applicable because this is an
un-retirement and not a new package :)

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

--- Comment #6 from Kalev Lember  ---
Awesome, thank you!

Releng unretirement request: https://pagure.io/releng/issue/11056

[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

https://bugzilla.redhat.com/show_bug.cgi?id=2124329

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
   Fixed In Version|                            |rust-cssparser-0.28.1-4.fc3
                   |                            |8
        Last Closed|                            |2022-10-04 10:40:05

--- Comment #7 from Kalev Lember  ---
Package unretired and built.